Creating & Destroying Regions programmatically

I'm trying to figure out how to exercise the CreateRegion and DestoryRegion classes from a client in order to test authorization. I can't figure out what the API would be for a client to trigger the cmdExecute() call on the server. For example, I was able to hit it in ClearRegion by having the

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47146/#review132549 --- Ship it! Ship It! - Kevin Duling On May 9, 2016, 5:30 p.m

Geode Portfile for Mac Ports

Using the geode.rb file for Homebrew as a template, I was able to build a Portfile for macports.org. Does anyone have any feedback before I submit it to the macports repo? No code changes were necessary and it is using the same binary image the Homebrew version is. I've tested it as far as

Re: Geode Portfile for Mac Ports

wrote: > Awesome work, but please consider calling it apache-geode. > > Thanks, > Roman. > > On Tue, May 17, 2016 at 1:23 PM, Kevin Duling <kdul...@pivotal.io> wrote: > > Using the geode.rb file for Homebrew as a template, I was able to build a > > Portfile for macports.

Renaming web api from gemfire-api to geode

There is a story to rename the gemfire-api (Developer API) and gemfire (Management API) to geode and geode-mgmt, respectively. The change itself is rather trivial. Just a couple web.xml changes, rename gemfire-api-servlet.xml, and update unit tests. The non-trivial part is still supporting

Re: Renaming web api from gemfire-api to geode

at 3:05 PM, Jens Deppe <jde...@pivotal.io> wrote: > > > Could you do a redirect instead of forwarding? > > > > --Jens > > > > > On Jul 26, 2016, at 1:57 PM, Kevin Duling <kdul...@pivotal.io> wrote: > > > > > > There is a story to rename t

Swagger UI?

I saw that Geode has the annotations for Swagger. How is the UI launched? In projects I've worked with before, it's been deployed under the "/swagger-ui" context.

Re: Review Request 49331: GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49331/#review139844 --- Ship it! Ship It! - Kevin Duling On June 28, 2016, 11:11

Re: Review Request 50572: GEODE-1701: rename GeodePermission as ResourcePermission

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50572/#review143982 --- Ship it! Ship It! - Kevin Duling On July 28, 2016, 9:53 a.m

Re: Review Request 50462: GEODE-1385: mark testShutDownForTIMEOUT with FlakyTest category

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50462/#review143983 --- Ship it! Ship It! - Kevin Duling On July 26, 2016, 1:53 p.m

Re: Review Request 50141: GEODE-1571: simplify security check and have auth-init accept either a constructor or a static factory method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50141/#review143984 --- Ship it! Ship It! - Kevin Duling On July 18, 2016, 8:57 a.m

Re: Review Request 50051: GEODE-1571: have auth-init accept either a constructor or a static factory method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50051/#review143985 --- Ship it! Ship It! - Kevin Duling On July 14, 2016, 3:19 p.m

Re: Swagger UI?

for GEODE-1467, swagger API is now available at: > /geode/docs/index.html > > On Tue, Aug 9, 2016 at 11:10 AM, Kevin Duling <kdul...@pivotal.io> wrote: > > > I saw that Geode has the annotations for Swagger. How is the UI > launched? > > In projects I've wo

Re: Valid characters in region names?

rincipal Engineer, GemFire Product Manager > Mobile: 631-835-4771 > > On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling <kdul...@pivotal.io> wrote: > > > I'm working on a bug where it is not possible to delete a region that > has a > > hyphen in it. E.g., the region was c

Re: Valid characters in region names?

discussed actually > checking during create. > > -- > Mike Stolz > Principal Engineer, GemFire Product Manager > Mobile: 631-835-4771 > > On Thu, Jun 30, 2016 at 3:30 PM, Kevin Duling <kdul...@pivotal.io> wrote: > > > I found a thread from March of this year where

Trying to upgrade spring-security

I'm working on adding security to the REST methods and wanted to start by upgrading spring-security to the latest version. Bumping the version from 4.1.1 from 3.1.7, I ran in to GfshCommandsOverHttpSecurityTest failing under geode-web. The error was: [warn 2016/08/12 15:37:52.078 PDT tid=0x1]

Re: Trying to upgrade spring-security

n some > gradle commands (dependencies, dependencyInsight, dumpDependencies) to help > sort out the full list of version changes needed. > > Anthony > > > On Aug 16, 2016, at 8:39 AM, Kevin Duling <kdul...@pivotal.io> wrote: > > > > I'm working on a

Re: Review Request 51125: GEODE-1782: stat resources with different time stamps should not be equal

compared. Should they be? - Kevin Duling On Aug. 15, 2016, 6:56 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51098: GEODE-1781: repackage internal statistics classes and refactor statistics tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51098/#review145878 --- Ship it! Ship It! - Kevin Duling On Aug. 15, 2016, 6:39 p.m

Re: git commit messages

The format is very similar to the one most other git shops I've worked in before use. I don't believe we ever had formal length limits. Typically, it was: -: > blank line The Atlassian plugin for IDEA automates a lot of this. There are limits on the length of a jira ticket summary,

Re: Review Request 52269: GEODE-1659: put security properties in the cluster config and applied to all the members in the cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52269/#review150456 --- Ship it! Ship It! - Kevin Duling On Sept. 26, 2016, 1:32

Re: Review Request 52525: GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

each and every test. @BeforeClass is only called once. This is causing you to call preassert() eight times. Then createConfigFile() is called a total of thirty-two times. - Kevin Duling On Oct. 4, 2016, 1:23 p.m., Kirk Lund wrote

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52571/#review151558 --- Ship it! Ship It! - Kevin Duling On Oct. 5, 2016, 2:06 p.m

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

tomatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52571/ > --- > > (Updated Oct. 5, 2016, 2:06 p.m.) > > > Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk > Lund, and Dan

Re: Brew formulae for geode

I'll be updating MacPorts probably this week, too, also calling it apache-geode. On Wed, Aug 24, 2016 at 7:43 AM, Anthony Baker wrote: > Bumping this old thread: > > I’ve updated the brew formula with the 1.0.0-incubating.M3 release and > renamed it to apache-geode. > > `brew

Re: Review Request 52468: Add FlakyTest category to tests with open bugs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52468/#review151174 --- Ship it! Ship It! - Kevin Duling On Oct. 1, 2016, 5:07 p.m

Re: Review Request 53198: GEODE-17: Fix a logical bug that prevents customers to set both Peer and Client authenticator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53198/#review154029 --- Ship it! Ship It! - Kevin Duling On Oct. 26, 2016, 10:42

Re: Review Request 53241: GEODE-1912: make ServerStarter and LocatorStarter as regular rules so that it's easier to use them in a RuleChain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53241/#review154071 --- Ship it! Ship It! - Kevin Duling On Oct. 27, 2016, 2:31 p.m

Re: Review Request 53577: Remove illegal javadoc tag that generates warning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53577/#review155325 --- Ship it! Ship It! - Kevin Duling On Nov. 8, 2016, 9:54 a.m

Re: Review Request 53579: GEODE-1570: add a test to verify rest security with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53579/#review155326 --- Ship it! Ship It! - Kevin Duling On Nov. 8, 2016, 10:13 a.m

Re: Review Request 53553: GEODE-2082: fix flakiness in sameKeepsOneFile

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53553/#review155327 --- Ship it! Ship It! - Kevin Duling On Nov. 7, 2016, 11:25 a.m

Re: Review Request 53587: GEODE-2014: explicitly declare spring-web as a direct dependency rather than a transitive one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53587/#review155379 --- Ship it! Ship It! - Kevin Duling On Nov. 8, 2016, 2:31 p.m

Re: Gfsh Parsing

+1 On Fri, Nov 4, 2016 at 11:14 AM, Jens Deppe wrote: > One of the 'features' of the current output is for the text to be able to > indicate whether the command is currently available or not. Personally I > don't think there's much value to that. If necessary, more

Re: Review Request 53543: GEODE-2079: mark the test as flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53543/#review155159 --- Ship it! Ship It! - Kevin Duling On Nov. 7, 2016, 8:42 a.m

Re: Where should geode example code live

+1 Shouldn't that be org.apache.geode.security.examples? On Thu, Nov 10, 2016 at 11:03 AM, Jinmei Liao wrote: > +1 for both renaming it now and moving it to a separate module going > forward. > > On Thu, Nov 10, 2016 at 10:58 AM, Kirk Lund wrote: > > > We

Re: Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52936/#review152920 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 10:59

Re: Review Request 53171: GEODE-17: mark deprecated security configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53171/#review153809 --- Ship it! Ship It! - Kevin Duling On Oct. 25, 2016, 10:02

Re: [GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

All of those files are the old Swagger-UI, replaced by the following gradle entry in geode-web-api. There is no reason we should be bundling the swagger ui github project in to Geode. I'm not even sure this old UI would work with the Swagger2 API. None of these are related to pulse, that lives

Updating Swagger

I'm updating Swagger to the Swagger2 specification and the new landing page has different fields than the old one. I've populated most of them with some possible values and am looking for feedback. I've placed a screenshot at https://drive.google.com/open?id=0B-lWOyam73gWdWZjVDloVF82VnM Some of

Re: Updating Swagger

I've updated the page to appear as follows. Any feedback is welcome. https://drive.google.com/file/d/0B-lWOyam73gWb0hWT1Jtd1loeFE/view?usp=sharing On Thu, Oct 20, 2016 at 11:40 AM, Kevin Duling <kdul...@pivotal.io> wrote: > I'm updating Swagger to the Swagger2 specification and the ne

Re: Review Request 53079: GEODE-2020: for rest api get request, use utf-8 as response encoding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53079/#review153565 --- Ship it! Ship It! - Kevin Duling On Oct. 21, 2016, 7:29 a.m

Re: Review Request 53079: GEODE-2020: for rest api get request, use utf-8 as response encoding.

to avoid a lot of code duplication. As a result, your changes are incompatible with the changes I have in GEODE-2014. The changes aren't large, but I wanted to point out the merge conflict we're going to have. - Kevin Duling On Oct. 20, 2016, 3:31 p.m., Jinmei Liao wrote

Re: Review Request 52994: GEODE-1959: prompt for password when starting a server if username is specified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52994/#review153173 --- Ship it! Ship It! - Kevin Duling On Oct. 18, 2016, 1:28 p.m

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

JSON mapping code? Or is this a special case where we do some magic serialization we can't do via Jackson? - Kevin Duling On Nov. 15, 2016, 7:06 a.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 53685: GEODE-1955: properly disconnect gfsh session so that it won't leave heartbeat thread around to pollute other tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/#review155926 --- Ship it! Ship It! - Kevin Duling On Nov. 14, 2016, 12:56

Re: Review Request 53784: GEODE-1247: unable to stop server using http connection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53784/#review155990 --- Ship it! Ship It! - Kevin Duling On Nov. 15, 2016, 7:06 a.m

Code Formatting in develop

I just submitted a PR to geode that Travis CI rejected because of code formatting in classes I had not modified. Prior to my commit, I'd merged in the latest develop branch this morning, which picked this up. The error message reads: > > Format violations were found. Run 'gradlew spotlessApply'

Re: Review Request 53274: GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53274/#review154187 --- Ship it! Ship It! - Kevin Duling On Oct. 28, 2016, 2:49 p.m

Re: Coding practices/standards

If we made formatting a warning, then people would probably quickly ignore it. If we made formatting an error, we need to be sure we don't get in to the situation where 's formatter is not in agreement with the build's checker. I can live with an additional 17 seconds as well. And Jared's

Re: Coding practices/standards

Oct 13, 2016, at 9:40 AM, Kevin Duling <kdul...@pivotal.io> wrote: > > > > If we made formatting a warning, then people would probably quickly > ignore > > it. > > If we made formatting an error, we need to be sure we don't get in to the > > situation where

Re: Starting the server, prompt for username/password

w control. I'd > provide a link to Ward Cunningham's wiki but his wiki is currently down. > > There should be a way to determine if the user has credentials before > trying to connect. > > -Kirk > > > On Thu, Oct 13, 2016 at 2:50 PM, Kevin Duling <kdul...@pivotal.io&

Starting the server, prompt for username/password

I'm working on GEODE-1959 and the use case goes like this: Create your gemfire.properites with a security manager. For example: > security-manager=org.apache.geode.security.templates.SampleSecurityManage But do not provide a username and

Re: Review Request 52751: GEODE-1986: correctly set the flag indicating if cluster configuration service is running or not on a locator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52751/#review152345 --- Ship it! Ship It! - Kevin Duling On Oct. 11, 2016, 7:21 p.m

Re: Coding practices/standards

I know I've been guilty of submitting code for review that hasn't matched the code style in the past. As a result, I've checked the "reformat code" box on the 'commit' dialog in IDEA, pointing to the IntelliJ xml formatter. It's frustrating to me that this sort of thing is still an issue in

Re: Review Request 52742: GEODE-1979: refactor tests using LocatorServerConfigurationRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52742/#review152342 --- Ship it! Ship It! - Kevin Duling On Oct. 11, 2016, 6:11 p.m

Re: Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52931/#review152888 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 8:10 a.m

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/#review152890 --- Ship it! Ship It! - Kevin Duling On Oct. 14, 2016, 11:41

Re: Review Request 52956: GEODE-2011: add FlakyTest category to testNonPersistentServerRestartAutoSerializer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52956/#review152945 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 1:03 p.m

Re: Review Request 52937: GEODE-2007: fix unchecked warnings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52937/#review152946 --- Ship it! Huzzah for reducing warnings! - Kevin Duling

Re: Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52949/#review152942 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 12:18