[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode

2019-09-09 Thread GitBox
shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322477750
 
 

 ##
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
 ##
 @@ -196,6 +196,11 @@ public GobblinTaskRunner(String applicationName,
 this.services.addAll(suite.getServices());
 
 this.services.addAll(getServices());
+
+if (ConfigUtils.getBoolean(this.config, 
GobblinClusterConfigurationKeys.CONTAINER_HEALTH_METRICS_SERVICE_ENABLED, 
false)) {
 
 Review comment:
   Create a single static constant for the default value for this config, so 
you don't have to say false in two places?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode

2019-09-09 Thread GitBox
shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322481749
 
 

 ##
 File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
 ##
 @@ -133,4 +131,8 @@ public static void addFileAsLocalResource(FileSystem fs, 
Path destFilePath, Loca
 
 return environmentVariableMap;
   }
+
 
 Review comment:
   javadoc missing. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode

2019-09-09 Thread GitBox
shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322481788
 
 

 ##
 File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
 ##
 @@ -133,4 +131,8 @@ public static void addFileAsLocalResource(FileSystem fs, 
Path destFilePath, Loca
 
 return environmentVariableMap;
   }
+
+  public static String getContainerNum(String containerId) {
+return "container-" + containerId.substring(containerId.lastIndexOf("_") + 
1);
 
 Review comment:
   why are we doing + 1?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode

2019-09-09 Thread GitBox
shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322474783
 
 

 ##
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
 ##
 @@ -167,4 +167,5 @@
 
   public static final String HELIX_JOB_STOPPING_STATE_TIMEOUT_SECONDS = 
GOBBLIN_CLUSTER_PREFIX + "job.stoppingStateTimeoutSeconds";
   public static final long DEFAULT_HELIX_JOB_STOPPING_STATE_TIMEOUT_SECONDS = 
300;
+  public static final String CONTAINER_HEALTH_METRICS_SERVICE_ENABLED = 
GOBBLIN_CLUSTER_PREFIX + "container.health.metrics.service.enabled" ;
 }
 
 Review comment:
   no default?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-gobblin] shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode

2019-09-09 Thread GitBox
shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322481849
 
 

 ##
 File path: 
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/ContainerHealthMetricsServiceTest.java
 ##
 @@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.cluster;
+
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+
+import lombok.extern.slf4j.Slf4j;
+
+
+@Slf4j
+public class ContainerHealthMetricsServiceTest {
+
+  @Test
+  public void testRunOneIteration() throws Exception {
+Config config = ConfigFactory.empty();
+ContainerHealthMetricsService service = new 
ContainerHealthMetricsService(config);
+service.runOneIteration();
+long processCpuTime1 = service.processCpuTime.get();
+Thread.sleep(10);
+service.runOneIteration();
+long processCpuTime2 = service.processCpuTime.get();
+Assert.assertTrue(processCpuTime1 < processCpuTime2);
+  }
+}
 
 Review comment:
   missing newline at end of file. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services