[jira] [Work logged] (GOBBLIN-1048) Provide an option to pass and set System properties via Gobblin Cluster application config

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386290
 ]

ASF GitHub Bot logged work on GOBBLIN-1048:
---

Author: ASF GitHub Bot
Created on: 12/Feb/20 22:45
Start Date: 12/Feb/20 22:45
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #2888: GOBBLIN-1048: 
Provide an option to pass and set System properties via…
URL: https://github.com/apache/incubator-gobblin/pull/2888
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386290)
Time Spent: 1h  (was: 50m)

> Provide an option to pass and set System properties via Gobblin Cluster 
> application config
> --
>
> Key: GOBBLIN-1048
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1048
> Project: Apache Gobblin
>  Issue Type: Improvement
>  Components: gobblin-cluster
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Hung Tran
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) 
> via Java System properties. This task provides an ability to pass system 
> overrides via Gobblin Cluster application configuration and sets these 
> overrides in the cluster manager and task runners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-1048) Provide an option to pass and set System properties via Gobblin Cluster application config

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386285
 ]

ASF GitHub Bot logged work on GOBBLIN-1048:
---

Author: ASF GitHub Bot
Created on: 12/Feb/20 22:31
Start Date: 12/Feb/20 22:31
Worklog Time Spent: 10m 
  Work Description: codecov-io commented on issue #2888: GOBBLIN-1048: 
Provide an option to pass and set System properties via…
URL: 
https://github.com/apache/incubator-gobblin/pull/2888#issuecomment-585451492
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=h1)
 Report
   > Merging 
[#2888](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/3712ec5958d803b8f1a726ab91154f92b0a158a8?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#2888  +/-   ##
   
   + Coverage 45.72%   45.72%   +<.01% 
   - Complexity 9123 9130   +7 
   
 Files  1926 1926  
 Lines 7252772563  +36 
 Branches   7983 7993  +10 
   
   + Hits  3316433182  +18 
   - Misses3633636347  +11 
   - Partials   3027 3034   +7
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `65.5% <100%> (+0.15%)` | `29 <0> (ø)` | :arrow_down: |
   | 
[.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=)
 | `54.95% <100%> (+0.2%)` | `28 <0> (ø)` | :arrow_down: |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `38.93% <100%> (+3.42%)` | `14 <2> (+2)` | :arrow_up: |
   | 
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
 | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
   | 
[...obblin/service/modules/flowgraph/BaseDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvQmFzZURhdGFOb2RlLmphdmE=)
 | `66.66% <0%> (-8.34%)` | `5% <0%> (ø)` | |
   | 
[...modules/flowgraph/datanodes/hive/HiveDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2hpdmUvSGl2ZURhdGFOb2RlLmphdmE=)
 | `63.15% <0%> (-7.44%)` | `4% <0%> (ø)` | |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `85.71% <0%> (-7.15%)` | `3% <0%> (-1%)` | |
   | 
[...hive/entities/TableLikeStageableTableMetadata.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9lbnRpdGllcy9UYWJsZUxpa2VTdGFnZWFibGVUYWJsZU1ldGFkYXRhLmphdmE=)
 | `40% <0%> (-6.16%)` | `2% <0%> (ø)` | |
   | 
[...vice/modules/flowgraph/datanodes/HttpDataNode.java](ht

[jira] [Work logged] (GOBBLIN-1048) Provide an option to pass and set System properties via Gobblin Cluster application config

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386128
 ]

ASF GitHub Bot logged work on GOBBLIN-1048:
---

Author: ASF GitHub Bot
Created on: 12/Feb/20 18:46
Start Date: 12/Feb/20 18:46
Worklog Time Spent: 10m 
  Work Description: autumnust commented on issue #2888: GOBBLIN-1048: 
Provide an option to pass and set System properties via…
URL: 
https://github.com/apache/incubator-gobblin/pull/2888#issuecomment-585358294
 
 
   +1 Approved
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386128)
Time Spent: 40m  (was: 0.5h)

> Provide an option to pass and set System properties via Gobblin Cluster 
> application config
> --
>
> Key: GOBBLIN-1048
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1048
> Project: Apache Gobblin
>  Issue Type: Improvement
>  Components: gobblin-cluster
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Hung Tran
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) 
> via Java System properties. This task provides an ability to pass system 
> overrides via Gobblin Cluster application configuration and sets these 
> overrides in the cluster manager and task runners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-1048) Provide an option to pass and set System properties via Gobblin Cluster application config

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386127
 ]

ASF GitHub Bot logged work on GOBBLIN-1048:
---

Author: ASF GitHub Bot
Created on: 12/Feb/20 18:45
Start Date: 12/Feb/20 18:45
Worklog Time Spent: 10m 
  Work Description: sv2000 commented on pull request #2888: GOBBLIN-1048: 
Provide an option to pass and set System properties via…
URL: https://github.com/apache/incubator-gobblin/pull/2888#discussion_r378441888
 
 

 ##
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
 ##
 @@ -150,6 +150,10 @@ public GobblinClusterManager(String clusterName, String 
applicationId, Config co
 
 this.applicationId = applicationId;
 
+//Helix uses System#getProperty() for ZK configuration overrides such as 
sessionTimeout. The overrides specified
 
 Review comment:
   Modified the comment.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386127)
Time Spent: 0.5h  (was: 20m)

> Provide an option to pass and set System properties via Gobblin Cluster 
> application config
> --
>
> Key: GOBBLIN-1048
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1048
> Project: Apache Gobblin
>  Issue Type: Improvement
>  Components: gobblin-cluster
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Hung Tran
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) 
> via Java System properties. This task provides an ability to pass system 
> overrides via Gobblin Cluster application configuration and sets these 
> overrides in the cluster manager and task runners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-1048) Provide an option to pass and set System properties via Gobblin Cluster application config

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386122
 ]

ASF GitHub Bot logged work on GOBBLIN-1048:
---

Author: ASF GitHub Bot
Created on: 12/Feb/20 18:37
Start Date: 12/Feb/20 18:37
Worklog Time Spent: 10m 
  Work Description: autumnust commented on pull request #2888: 
GOBBLIN-1048: Provide an option to pass and set System properties via…
URL: https://github.com/apache/incubator-gobblin/pull/2888#discussion_r378437965
 
 

 ##
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
 ##
 @@ -150,6 +150,10 @@ public GobblinClusterManager(String clusterName, String 
applicationId, Config co
 
 this.applicationId = applicationId;
 
+//Helix uses System#getProperty() for ZK configuration overrides such as 
sessionTimeout. The overrides specified
 
 Review comment:
   Since this is useful for any configuration, let's fix the comment which 
gives me impression that only ZK configuration's overrides are loaded from 
system configuration. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386122)
Time Spent: 20m  (was: 10m)

> Provide an option to pass and set System properties via Gobblin Cluster 
> application config
> --
>
> Key: GOBBLIN-1048
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1048
> Project: Apache Gobblin
>  Issue Type: Improvement
>  Components: gobblin-cluster
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Hung Tran
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) 
> via Java System properties. This task provides an ability to pass system 
> overrides via Gobblin Cluster application configuration and sets these 
> overrides in the cluster manager and task runners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-1048) Provide an option to pass and set System properties via Gobblin Cluster application config

2020-02-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386115
 ]

ASF GitHub Bot logged work on GOBBLIN-1048:
---

Author: ASF GitHub Bot
Created on: 12/Feb/20 18:30
Start Date: 12/Feb/20 18:30
Worklog Time Spent: 10m 
  Work Description: sv2000 commented on pull request #2888: GOBBLIN-1048: 
Provide an option to pass and set System properties via…
URL: https://github.com/apache/incubator-gobblin/pull/2888
 
 
   … Gobblin Cluster application config
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-1048
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) 
via Java System properties. This task provides an ability to pass system 
overrides via Gobblin Cluster application configuration and sets these 
overrides in the cluster manager and task runners.
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Added unit test in HelixUtilsTest.
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 386115)
Remaining Estimate: 0h
Time Spent: 10m

> Provide an option to pass and set System properties via Gobblin Cluster 
> application config
> --
>
> Key: GOBBLIN-1048
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1048
> Project: Apache Gobblin
>  Issue Type: Improvement
>  Components: gobblin-cluster
>Affects Versions: 0.15.0
>Reporter: Sudarshan Vasudevan
>Assignee: Hung Tran
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) 
> via Java System properties. This task provides an ability to pass system 
> overrides via Gobblin Cluster application configuration and sets these 
> overrides in the cluster manager and task runners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)