[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762764#comment-16762764 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762795#comment-16762795 ] Oleg Kalnichevski commented on HTTPCORE-570: [~garydgregory] This is so much better if you

[GitHub] ok2c closed pull request #134: Always use the cached entity's content length.

2019-02-07 Thread GitBox
ok2c closed pull request #134: Always use the cached entity's content length. URL: https://github.com/apache/httpcomponents-client/pull/134 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762818#comment-16762818 ] Oleg Kalnichevski commented on HTTPCORE-569: [~garydgregory] Could you please squash 

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762830#comment-16762830 ] Gary Gregory commented on HTTPCORE-569: --- Dang, I thought I'd done that, sorry about that. >

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762888#comment-16762888 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[GitHub] ok2c commented on issue #134: Always use the cached entity's content length.

2019-02-07 Thread GitBox
ok2c commented on issue #134: Always use the cached entity's content length. URL: https://github.com/apache/httpcomponents-client/pull/134#issuecomment-461539836 @JaysonRaymond Committed as d150f5abae3fc4a51f18a63d2807bf703fa67dd7

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762999#comment-16762999 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[GitHub] ok2c opened a new pull request #103: HTTPCORE-570

2019-02-07 Thread GitBox
ok2c opened a new pull request #103: HTTPCORE-570 URL: https://github.com/apache/httpcomponents-core/pull/103 classes This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ok2c commented on issue #103: HTTPCORE-570

2019-02-07 Thread GitBox
ok2c commented on issue #103: HTTPCORE-570 URL: https://github.com/apache/httpcomponents-core/pull/103#issuecomment-461533731 @garydgregory Please review the change-set one more time and feel free to merge the PR if everything looks OK to you.

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762912#comment-16762912 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762913#comment-16762913 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762928#comment-16762928 ] ASF subversion and git services commented on HTTPCORE-570: -- Commit

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762932#comment-16762932 ] Oleg Kalnichevski commented on HTTPCORE-569: [~garydgregory] One more reason to not rush

[GitHub] ok2c merged pull request #135: Always use the cached entity's content length.

2019-02-07 Thread GitBox
ok2c merged pull request #135: Always use the cached entity's content length. URL: https://github.com/apache/httpcomponents-client/pull/135 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762911#comment-16762911 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[jira] [Reopened] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened HTTPCORE-569: --- I am re-opening this because I need a new matcher class. The want to enforce the order and

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762765#comment-16762765 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762763#comment-16762763 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762864#comment-16762864 ] Oleg Kalnichevski commented on HTTPCORE-569: [~garydgregory] What you might want to do is

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762865#comment-16762865 ] Oleg Kalnichevski commented on HTTPCORE-570: [~garydgregory] Once you are happy with the

[jira] [Resolved] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved HTTPCORE-569. --- Resolution: Fixed Fix Version/s: 5.0-beta7 Merged. > Create new value in

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762914#comment-16762914 ] ASF subversion and git services commented on HTTPCORE-570: -- Commit

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762891#comment-16762891 ] Gary Gregory commented on HTTPCORE-570: --- I am happy with the branch now. Feel free to merge,

Re: [httpcomponents-core] branch master updated: [HTTPCORE-569] Re-implement feature correctly in a separate class.

2019-02-07 Thread Oleg Kalnichevski
On Thu, 2019-02-07 at 19:25 +, ggreg...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository > https://gitbox.apache.org/repos/asf/httpcomponents-core.git > Gary, could you please avoid

Re: [httpcomponents-core] branch master updated: [HTTPCORE-569] Re-implement feature correctly in a separate class.

2019-02-07 Thread Gary Gregory
On Thu, Feb 7, 2019 at 2:28 PM Oleg Kalnichevski wrote: > On Thu, 2019-02-07 at 19:25 +, ggreg...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > ggregory pushed a commit to branch master > > in repository > >

[jira] [Commented] (HTTPCORE-568) ReactiveDataConsumer receives at most 65k bytes over HTTP/1.1

2019-02-07 Thread Ryan Schmitt (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763280#comment-16763280 ] Ryan Schmitt commented on HTTPCORE-568: --- [~olegk] We're working on it. > ReactiveDataConsumer

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762510#comment-16762510 ] Gary Gregory commented on HTTPCORE-570: --- The changes can be minimized by making instance

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762520#comment-16762520 ] Oleg Kalnichevski commented on HTTPCORE-570: [~garydgregory] I think this is even worse. If

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762472#comment-16762472 ] Oleg Kalnichevski commented on HTTPCORE-569: [~garydgregory] Works for me. You might want

[jira] [Comment Edited] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762474#comment-16762474 ] Oleg Kalnichevski edited comment on HTTPCORE-570 at 2/7/19 8:28 AM:

[jira] [Commented] (HTTPCORE-568) ReactiveDataConsumer receives at most 65k bytes over HTTP/1.1

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762479#comment-16762479 ] Oleg Kalnichevski commented on HTTPCORE-568: [~rschmitt] [~rhernandez] Folks, are you

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762474#comment-16762474 ] Oleg Kalnichevski commented on HTTPCORE-570: [~garydgregory] I think the whole thing is a

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762664#comment-16762664 ] Oleg Kalnichevski commented on HTTPCORE-570: [~garydgregory] I would very much rather

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762652#comment-16762652 ] Gary Gregory commented on HTTPCORE-570: --- Hi [~olegk], Thank you for taking the time to review.

[jira] [Comment Edited] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762652#comment-16762652 ] Gary Gregory edited comment on HTTPCORE-570 at 2/7/19 1:18 PM: --- Hi

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762719#comment-16762719 ] ASF subversion and git services commented on HTTPCORE-570: -- Commit

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762721#comment-16762721 ] Gary Gregory commented on HTTPCORE-570: --- Ok, cool. Please take a look at the HEAD of the

[jira] [Comment Edited] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762721#comment-16762721 ] Gary Gregory edited comment on HTTPCORE-570 at 2/7/19 2:40 PM: --- Ok, cool.

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762726#comment-16762726 ] ASF subversion and git services commented on HTTPCORE-570: -- Commit

[jira] [Commented] (HTTPCORE-570) Add getters to AsyncServerBootstrap and refactor create() impl into protected methods

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762730#comment-16762730 ] ASF subversion and git services commented on HTTPCORE-570: -- Commit

[jira] [Commented] (HTTPCORE-569) Create new value in org.apache.hc.core5.http.protocol.UriPatternType to lookup without an exact match override

2019-02-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762760#comment-16762760 ] ASF subversion and git services commented on HTTPCORE-569: -- Commit