arturobernalg merged PR #424:
URL: https://github.com/apache/httpcomponents-core/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arturobernalg merged PR #423:
URL: https://github.com/apache/httpcomponents-core/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arturobernalg merged PR #426:
URL: https://github.com/apache/httpcomponents-core/pull/426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yndu13 commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1704592623
@ok2c Can someone give a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
yndu13 opened a new pull request, #427:
URL: https://github.com/apache/httpcomponents-core/pull/427
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
arturobernalg merged PR #482:
URL: https://github.com/apache/httpcomponents-client/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c opened a new pull request, #483:
URL: https://github.com/apache/httpcomponents-client/pull/483
Changes:
* improved and simplified internal cache API
* corrected cache update logic after a variant negotiation
* more tests
* fixed regression
--
This is an automated message
ok2c commented on code in PR #428:
URL:
https://github.com/apache/httpcomponents-core/pull/428#discussion_r1325975840
##
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/DefaultH2RequestConverter.java:
##
@@ -208,4 +210,39 @@ public List convert(final HttpRequest
arturobernalg opened a new pull request, #430:
URL: https://github.com/apache/httpcomponents-core/pull/430
- Ensure the presence of 'Range' header when 'If-Range' is specified.
- Enforce strong validator requirements when 'If-Range' is paired with a
Date.
- Exit processing early if
ok2c opened a new pull request, #484:
URL: https://github.com/apache/httpcomponents-client/pull/484
@arturobernalg Please kindly have a look. No functional changes. Mostly
deprecation and removal of outdated / unused code and some javadoc updates.
--
This is an automated message from
ok2c commented on PR #430:
URL:
https://github.com/apache/httpcomponents-core/pull/430#issuecomment-1722452313
@arturobernalg
1. This change-set is definitely useful, but it kind of goes counter to the
overall philosophy of the library. Generally we provide higher level APIs for
ok2c merged PR #483:
URL: https://github.com/apache/httpcomponents-client/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arturobernalg commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312058180
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest
arturobernalg commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311925115
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest
arturobernalg merged PR #418:
URL: https://github.com/apache/httpcomponents-core/pull/418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arturobernalg commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1311941788
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -313,11 +314,14 @@ public URI build() throws URISyntaxException {
arturobernalg commented on PR #425:
URL:
https://github.com/apache/httpcomponents-core/pull/425#issuecomment-1701556124
OK. I din´t see that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
arturobernalg closed pull request #425: HTTPCORE-756 - Enhance HTTP header
handling and deprecate legacy features
URL: https://github.com/apache/httpcomponents-core/pull/425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lacompas commented on code in PR #478:
URL:
https://github.com/apache/httpcomponents-client/pull/478#discussion_r1307790388
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/InternalCacheStorage.java:
##
@@ -0,0 +1,94 @@
+/*
+ *
ok2c commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312747037
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,41 +260,41 @@ public void cancelled() {
@Test
void
michael-o commented on PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#issuecomment-1702420779
Am I stupid or where do I see that the request actually contains content?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
reschke commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312784977
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request,
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312801174
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request, final
arturobernalg commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312860300
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -309,11 +310,14 @@ public URI build() throws URISyntaxException {
ok2c commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1702595456
@arturobernalg What you can do here is move the checks to the `#build`
method and keep `#buildString` as is. That would also enable to remove that
ugly try-catch from the
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312913134
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,21 +112,56 @@ public void process(final HttpRequest request, final
arturobernalg commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312949660
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,21 +112,56 @@ public void process(final HttpRequest
arturobernalg commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312881881
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,41 +260,41 @@ public void cancelled() {
@Test
ok2c commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1702609085
@arturobernalg Please also do not forget to update the description as it
will be used as a commit message
--
This is an automated message from the Apache Git Service.
To
arturobernalg opened a new pull request, #426:
URL: https://github.com/apache/httpcomponents-core/pull/426
- Use AtomicBoolean for future completion tracking.
- Simplify async behavior and improve test determinism.
--
This is an automated message from the Apache Git Service.
To respond
reschke commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1702581449
I'm not sure that changing `toString()` is a good idea here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312913134
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,21 +112,56 @@ public void process(final HttpRequest request, final
ok2c commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313087273
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void
arturobernalg commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313176491
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
ok2c commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313069605
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void
thc202 commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313139826
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void
arturobernalg commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313078700
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
arturobernalg commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1703046218
> @arturobernalg Please also do not forget to update the description as it
will be used as a commit message
@ok2c
Done
--
This is an automated message from
thc202 commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313409461
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void
reschke commented on PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#issuecomment-1702432568
FWIW, as far as I can tell, this PR only checks that there is a Content-Type
field value. It doesn't check its validity, right?
--
This is an automated message from the
ok2c commented on PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#issuecomment-1702444761
> Am I stupid or where do I see that the request actually contains content?
@michael-o This is quite fair. @arturobernalg I think there should be a
check there is actually
reschke commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312857095
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -309,11 +310,14 @@ public URI build() throws URISyntaxException {
return
arturobernalg opened a new pull request, #482:
URL: https://github.com/apache/httpcomponents-client/pull/482
This PR introduces a change to the ProxyClient class to ensure that a port
is always specified when making a CONNECT request, in line with the
requirements set out in [RFC
arturobernalg opened a new pull request, #425:
URL: https://github.com/apache/httpcomponents-core/pull/425
This PR introduces two significant changes to improve our alignment with
modern HTTP standards:
- Trailer Headers with Chunked Transfer Encoding: We've added a check to
arturobernalg opened a new pull request, #424:
URL: https://github.com/apache/httpcomponents-core/pull/424
This pull request introduces changes to ensure our HTTP handling aligns with
the requirements set out in [RFC9110](https://www.rfc-editor.org/rfc/rfc9110).
Specifically, we've added
arturobernalg commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1699651791
> @arturobernalg Is this PR ready for review?
@ok2c yes. Or is there something I'm missing?
--
This is an automated message from the Apache Git Service.
To
ok2c commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1699594902
@arturobernalg Is this PR ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
reschke commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311309977
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request,
ok2c commented on code in PR #425:
URL:
https://github.com/apache/httpcomponents-core/pull/425#discussion_r1311380711
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/MessageSupport.java:
##
@@ -151,6 +152,11 @@ public static void addContentEncodingHeader(final
ok2c commented on code in PR #425:
URL:
https://github.com/apache/httpcomponents-core/pull/425#discussion_r1311380711
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/MessageSupport.java:
##
@@ -151,6 +152,11 @@ public static void addContentEncodingHeader(final
ok2c commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1311292928
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -313,11 +314,14 @@ public URI build() throws URISyntaxException {
return new
kwin opened a new pull request, #479:
URL: https://github.com/apache/httpcomponents-client/pull/479
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin commented on code in PR #479:
URL:
https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311425123
##
pom.xml:
##
@@ -227,8 +227,8 @@
maven-javadoc-plugin
-
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311302155
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request, final
ok2c commented on code in PR #479:
URL:
https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311449084
##
pom.xml:
##
@@ -227,8 +227,8 @@
maven-javadoc-plugin
-
ok2c merged PR #479:
URL: https://github.com/apache/httpcomponents-client/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kwin commented on code in PR #479:
URL:
https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311450127
##
pom.xml:
##
@@ -227,8 +227,8 @@
maven-javadoc-plugin
-
cachescrubber opened a new pull request, #480:
URL: https://github.com/apache/httpcomponents-client/pull/480
Document classic and async exec chain behaviour when automatic retries are
enabled.
https://issues.apache.org/jira/browse/HTTPCLIENT-2291
--
This is an automated message
cachescrubber commented on PR #480:
URL:
https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701081868
@ok2c I removed the snippets. Having implemented a handler myself I remember
having to dig in the source of clientBuilder in order to find the name of the
retry
ok2c commented on PR #480:
URL:
https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701102844
> I think I would at least document the name (ChainElement#RETRY) in order
to place the interceptors relative to it. WDYT?
Makes perfect sense.
--
This is an automated
ok2c merged PR #480:
URL: https://github.com/apache/httpcomponents-client/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on PR #480:
URL:
https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701014744
@cachescrubber Awesome! One thing, though. Do you mind dropping code
snippets out of Javadocs, as code examples often tend to get out of sync with
the actual API usage.
--
ok2c commented on code in PR #482:
URL:
https://github.com/apache/httpcomponents-client/pull/482#discussion_r1325993503
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProxyClient.java:
##
@@ -140,20 +140,19 @@ public Socket tunnel(
ok2c commented on PR #483:
URL:
https://github.com/apache/httpcomponents-client/pull/483#issuecomment-1719549303
@arturobernalg You do not need to understand every detail in the change-set,
just see if you can spot something obviously wrong or crazy
--
This is an automated message from
arturobernalg commented on code in PR #482:
URL:
https://github.com/apache/httpcomponents-client/pull/482#discussion_r1327127150
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProxyClient.java:
##
@@ -140,20 +140,19 @@ public Socket tunnel(
yndu13 commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705190444
> Hi @yndu13 Thank you for your PR. Without a matching test, this change in
behavior can be undone in the future without anyone noticing.
I agree with this opinion, but
ok2c merged PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705224802
> Thanks, you can use this [socks
server](https://github.com/serjs/socks5-server) to verify this problem.
@yndu13 I tested it with [Dante](https://www.inet.no/dante/).
--
garydgregory commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705169527
Hi @yndu13
Thank you for your PR.
Without a matching test, this change in behavior can be undone in the future
without anyone noticing.
--
This is an automated
ok2c commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705145516
@yndu13 Looks correct to me. I am still trying to test the fix locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yndu13 commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705165517
> @yndu13 Looks correct to me. I am still trying to test the fix locally.
Thanks, you can use this [socks
server](https://github.com/serjs/socks5-server) to verify this
dependabot[bot] opened a new pull request, #481:
URL: https://github.com/apache/httpcomponents-client/pull/481
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
Release notes
Sourced from https://github.com/actions/checkout/releases;>actions/checkout's
arturobernalg opened a new pull request, #428:
URL: https://github.com/apache/httpcomponents-core/pull/428
This PR introduces validations for the :path pseudo-header field in
accordance with the HTTP/2 specifications:
1. Ensures the :path pseudo-header field correctly represents
dependabot[bot] opened a new pull request, #429:
URL: https://github.com/apache/httpcomponents-core/pull/429
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
Release notes
Sourced from https://github.com/actions/checkout/releases;>actions/checkout's
Marcono1234 commented on code in PR #492:
URL:
https://github.com/apache/httpcomponents-client/pull/492#discussion_r1355665024
##
httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientCustomSSL.java:
##
@@ -59,6 +59,11 @@ public class AsyncClientCustomSSL {
ok2c commented on PR #441:
URL:
https://github.com/apache/httpcomponents-core/pull/441#issuecomment-1765256846
> Should we aim to make the HTTP component fully compliant with RFC9112?
@arturobernalg Yes, we have to. I just re-used the same JIRA ticket, that is
all. I see no point in
ok2c commented on PR #440:
URL:
https://github.com/apache/httpcomponents-core/pull/440#issuecomment-1762142330
@arturobernalg This does not look right to me. This is a _client-side_
request interceptor that generates the`Expect` header, not the server-side one
that processes it. The logic
arturobernalg opened a new pull request, #440:
URL: https://github.com/apache/httpcomponents-core/pull/440
This change allows HTTP/1.1 endpoints to more accurately handle the "Expect"
header field as per RFC 9110 section
[10.1.1](https://www.rfc-editor.org/rfc/rfc9110#name-expect). by
arturobernalg closed pull request #440: HTTPCORE-756: Support for Configurable
417 Expectation Failed Response in RequestExpectContinue
URL: https://github.com/apache/httpcomponents-core/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please
arturobernalg commented on PR #440:
URL:
https://github.com/apache/httpcomponents-core/pull/440#issuecomment-1762187262
@ok2c, you're absolutely right. My apologies for the oversight; it's an
embarrassing mistake on my part.
--
This is an automated message from the Apache Git Service.
ok2c opened a new pull request, #441:
URL: https://github.com/apache/httpcomponents-core/pull/441
* Stricter parsing of response status line. The status code must consist of
3 digits.
* `Transfer-Encoding` handling and message frame validity improvements
--
This is an automated
ok2c commented on PR #441:
URL:
https://github.com/apache/httpcomponents-core/pull/441#issuecomment-1763325860
@arturobernalg Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ok2c merged PR #441:
URL: https://github.com/apache/httpcomponents-core/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
carterkozak commented on code in PR #499:
URL:
https://github.com/apache/httpcomponents-client/pull/499#discussion_r1379179948
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java:
##
@@ -239,19 +240,7 @@ public Socket connectSocket(
carterkozak opened a new pull request, #499:
URL: https://github.com/apache/httpcomponents-client/pull/499
https://issues.apache.org/jira/browse/HTTPCLIENT-2305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HappyHacker123 opened a new pull request, #500:
URL: https://github.com/apache/httpcomponents-client/pull/500
# Problem Description
The slf4j-api is declared without assigning a dependency scope, leading to a
default scope compile. But it's only used for testing with classes
HappyHacker123 commented on PR #500:
URL:
https://github.com/apache/httpcomponents-client/pull/500#issuecomment-1790294714
@ok2c @arturobernalg Could you look at these changes? Thx :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Sharofiddin commented on PR #500:
URL:
https://github.com/apache/httpcomponents-client/pull/500#issuecomment-1790359752
This project by itself for testing, I think this change is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ok2c commented on PR #498:
URL:
https://github.com/apache/httpcomponents-client/pull/498#issuecomment-1790783519
> Hi all,
>
> Commons Compress depends on the same lib BUT provides a facade API for all
its archive and compressed file formats.
@garydgregory Got it. Thank you.
ok2c merged PR #500:
URL: https://github.com/apache/httpcomponents-client/pull/500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
carterkozak merged PR #499:
URL: https://github.com/apache/httpcomponents-client/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #498:
URL:
https://github.com/apache/httpcomponents-client/pull/498#issuecomment-1790574767
Hi all,
Commons Compress depends on the same lib BUT provides a facade API for all
its archive and compressed file formats.
--
This is an automated message
ok2c commented on PR #500:
URL:
https://github.com/apache/httpcomponents-client/pull/500#issuecomment-1790776621
@HappyHacker123 `httpclient5-testing` depends on `httpclient5` that will
drag in `slf4j-api` as a transitive dependency with `compile` scope no matter
what. I agree though
HappyHacker123 commented on PR #500:
URL:
https://github.com/apache/httpcomponents-client/pull/500#issuecomment-1790736706
> This project by itself for testing, I think this change is redundant.
Thanks for your reply :) .
However, I think how downstream users use this project
carterkozak commented on PR #499:
URL:
https://github.com/apache/httpcomponents-client/pull/499#issuecomment-1790827273
Thanks for the review, @ok2c!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
arturobernalg commented on PR #498:
URL:
https://github.com/apache/httpcomponents-client/pull/498#issuecomment-1791263087
> @arturobernalg [Zstd](https://github.com/luben/zstd-jni#zstd) appears to
be [BSD Licensed](https://github.com/luben/zstd-jni/blob/master/LICENSE). It
_should_ be
ok2c commented on PR #498:
URL:
https://github.com/apache/httpcomponents-client/pull/498#issuecomment-1790504099
@arturobernalg [Zstd](https://github.com/luben/zstd-jni#zstd) appears to be
[BSD Licensed](https://github.com/luben/zstd-jni/blob/master/LICENSE). It
_should_ be compatible
arturobernalg opened a new pull request, #502:
URL: https://github.com/apache/httpcomponents-client/pull/502
This pull request addresses an issue in `BasicHttpClientConnectionManager`
where stale connections were not being handled correctly. Previously, a stale
connection could potentially
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-1793766886
@kkewwei Also there are test failures with Java 1.8
```
Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.008 s <<< FAILURE! - in
ok2c commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382593572
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##
@@ -357,7 +357,19 @@ ManagedHttpClientConnection
1 - 100 of 1230 matches
Mail list logo
