ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179223844
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179224094
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179224094
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a
check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-378683450
Yeah. It is a good point.
I was changing the safe ones only in this PR to be quick. For the CHECK_E
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179223844
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227062
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227062
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
nwangtw commented on a change in pull request #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227579
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@ -0,0
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227062
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227062
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179229234
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
nwangtw commented on a change in pull request #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179229580
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@ -0,0
nwangtw commented on a change in pull request #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179229651
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@ -0,0
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227062
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
nwangtw commented on issue #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#issuecomment-378689421
Overall LGTM. The only concern (not a blocker to me) is about ObjectMapper
which needs other feedbacks.
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227062
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179227062
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179232704
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
ajorgensen commented on a change in pull request #2842: Add json format for
dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179232704
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@
nwangtw commented on a change in pull request #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179236408
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@ -0,0
Yaliang commented on a change in pull request #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179238932
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@ -0,0
nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a
check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-378702937
Just did a test. Seems the checks work with << as expected.
Run 1:
int a = 1, b = 2;
CHECK(a
nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a
check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-378704512
And I will see what description I can add now.
--
Yaliang commented on issue #2847: Replace CHECK() with CHECK_*() so that when a
check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-378704468
Just pass you a document for glog: http://rpg.ifi.uzh.ch/docs/glog.html
-
nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a
check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-378704722
Cool. Thx. @Yaliang
This is an automate
It's official! Karthik will be joining me in St. Louis, MO on June 13 at
the Full Stack Web Development meetup to present Apache Heron. Details are
here ->
https://www.meetup.com/SaintLouis_FullStack_WebDevelopment/events/246318945/
--
Sent from A Mobile Device
nwangtw opened a new pull request #2848: Rate limit needs to be disabled before
the bufferevent_free call
URL: https://github.com/apache/incubator-heron/pull/2848
This is an automated message from the Apache Git Service.
To
Hi Team,
Please join our first meetup.
https://www.meetup.com/Apache-Heron-Bay-Area/events/249414421/
Thanking you.
With Regards
Sree
ashvina commented on a change in pull request #2821: Update Dhalion dependency
version
URL: https://github.com/apache/incubator-heron/pull/2821#discussion_r179298554
##
File path:
heron/healthmgr/src/java/com/twitter/heron/healthmgr/detectors/GrowingWaitQueueDetector.java
nwangtw commented on a change in pull request #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#discussion_r179303684
##
File path:
heron/scheduler-core/src/java/com/twitter/heron/scheduler/dryrun/JsonFormatterUtils.java
##
@@ -0,0
Yaliang closed pull request #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull req
Yaliang commented on issue #2842: Add json format for dry-run
URL: https://github.com/apache/incubator-heron/pull/2842#issuecomment-378770011
Thanks @ajorgensen !
Merged!
This is an automated message from the Apache Git S
kramasamy opened a new pull request #2849: Eco for heron topologies
URL: https://github.com/apache/incubator-heron/pull/2849
This is an automated message from the Apache Git Service.
To respond to the message, please log on G
Hi Team,
I am done rename from 'com.twitter.heron' to 'org.apache.heron'.
https://github.com/apache/incubator-heron/pull/2840
Please rebase and confirm.
Thanking you.
Sree
nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a
check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-378807330
Updated descriptions
This is an automate
sreev closed issue #2834: update README.md
URL: https://github.com/apache/incubator-heron/issues/2834
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL a
sreev closed issue #2843: reduce build time
URL: https://github.com/apache/incubator-heron/issues/2843
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
sreev commented on issue #2843: reduce build time
URL:
https://github.com/apache/incubator-heron/issues/2843#issuecomment-378807709
But reverted back to install.sh script, for cross OS compatibility.
Will visit this another time.
No changes.
--
38 matches
Mail list logo
