Re: [DISCUSS]: Commit guidelines for PRs

2020-07-01 Thread Zoltan Haindrich
Hey, There are quite a few things which have changed lately...and the github merge option have really twisted a few things :) On 6/30/20 9:31 PM, Vihang Karajgaonkar wrote: 1. Whether to standardize on Squash into one commit

Re: [DISCUSS]: Commit guidelines for PRs

2020-06-30 Thread Peter Vary
Hi Vihang, As you, I like the new infra very much! I have opinion /answer for 2 of your questions below: VK > 1. Whether to standardize on Squash into one commit I think we should squash. The final code should not be polluted with the meandering way we sometimes arrive to the final solution in

[DISCUSS]: Commit guidelines for PRs

2020-06-30 Thread Vihang Karajgaonkar
Thanks to all who worked on the new testing infrastructure. It definitely looks like a step up from the older test infrastructure. I wanted to know if there are any new guidelines for a committer for merging the PRs. Earlier we used to create one patch file for each JIRA and push it to the master