Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-29 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/ --- (Updated Aug. 29, 2014, 6:13 a.m.) Review request for hive and Prasanth_J.

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-29 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51875 --- Ship it! Ship It! - Prasanth_J On Aug. 29, 2014, 6:13 a.m.,

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51754 ---

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51762 --- ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51763 ---

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread Jason Dere
On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, line 1 https://reviews.apache.org/r/24472/diff/1/?file=655372#file655372line1 Can you also add a testcase for partitioned table? similar to

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread Jason Dere
On Aug. 28, 2014, 7:59 a.m., Prasanth_J wrote: ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 89 https://reviews.apache.org/r/24472/diff/1/?file=655370#file655370line89 This doesn't look good. Can you use MapString, ColumnStatisticsObj instead? with key

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread Jason Dere
On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java, line 202 https://reviews.apache.org/r/24472/diff/1/?file=655367#file655367line202 Why not just use Warehouse.getFileStatusesForSD(tbl.getSd())? It does the

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51815 ---

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
On Aug. 28, 2014, 7:59 a.m., Prasanth_J wrote: ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 89 https://reviews.apache.org/r/24472/diff/1/?file=655370#file655370line89 This doesn't look good. Can you use MapString, ColumnStatisticsObj instead? with key

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, line 1 https://reviews.apache.org/r/24472/diff/1/?file=655372#file655372line1 Can you also add a testcase for partitioned table? similar to

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread j . prasanth . j
On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, line 396 https://reviews.apache.org/r/24472/diff/1/?file=655368#file655368line396 Is there any reason why you are not using FieldSchema's equals() here?

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread Jason Dere
On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, line 1 https://reviews.apache.org/r/24472/diff/1/?file=655372#file655372line1 Can you also add a testcase for partitioned table? similar to

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-28 Thread Jason Dere
On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, line 396 https://reviews.apache.org/r/24472/diff/1/?file=655368#file655368line396 Is there any reason why you are not using FieldSchema's equals() here?

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

2014-08-26 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/ --- (Updated Aug. 26, 2014, 6:37 p.m.) Review request for hive and Prasanth_J.