Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-20 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/ --- (Updated March 20, 2017, 9:03 a.m.) Review request for hive, Peter Vary,

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-20 Thread Barna Zsombor Klara
> On March 17, 2017, 8:30 p.m., Sergio Pena wrote: > > ql/src/test/queries/clientpositive/msck_repair_0.q > > Lines 19-21 (patched) > > > > > > Is this actually adding new partitios to the metastore? Those are > >

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-17 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/#review169324 --- ql/src/test/queries/clientpositive/msck_repair_0.q Lines 19-21

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-16 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/ --- (Updated March 16, 2017, 3:55 p.m.) Review request for hive, Peter Vary,

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-16 Thread Barna Zsombor Klara
> On March 15, 2017, 4:05 a.m., Naveen Gangam wrote: > > common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java > > Lines 32 (patched) > > > > > > Since we already use common-collections library in

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-16 Thread Barna Zsombor Klara
> On March 15, 2017, 4:05 a.m., Naveen Gangam wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 781 (original), 781 (patched) > > > > > > We already a few config properties around the max

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-16 Thread Barna Zsombor Klara
> On March 14, 2017, 9:35 p.m., Sergio Pena wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > > Line 219 (original), 223-228 (patched) > > > > > > Does this mean that if a user

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-14 Thread Naveen Gangam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/#review168969 ---

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-14 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/#review168942 ---

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-10 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/#review168642 --- Ship it! Thanks for the changes Zsombor. LGTM - Vihang