Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58914/ --- (Updated May 3, 2017, 1:16 a.m.) Review request for hive, Jason Dere and

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58914/ --- (Updated May 2, 2017, 9:01 p.m.) Review request for hive, Jason Dere and

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
> On May 2, 2017, 8:15 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 11192 (patched) > > > > > > Can you give the method name something different than

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58914/#review173628 ---

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
> On May 2, 2017, 6:35 p.m., Vineet Garg wrote: > > ql/src/test/queries/clientpositive/semijoin_hint.q > > Line 38 (original), 38 (patched) > > > > > > Why is returnpath on? > > This feature is not yet fully

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Vineet Garg
> On May 2, 2017, 6:35 p.m., Vineet Garg wrote: > > ql/src/test/queries/clientpositive/semijoin_hint.q > > Line 38 (original), 38 (patched) > > > > > > Why is returnpath on? > > This feature is not yet fully

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
> On May 2, 2017, 6:35 p.m., Vineet Garg wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Line 338 (original), 338 (patched) > > > > > > Can you add comments to explain why are we doing

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58914/#review173558 --- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java