Re: Review Request 72378: HIVE-23201: Improve logging in locking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220456 --- Ship it! Ship It! - Denys Kuzmenko On April 23, 2020, 8:56

Re: Review Request 72378: HIVE-23201: Improve logging in locking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/ --- (Updated April 23, 2020, 8:56 a.m.) Review request for hive, Denys Kuzmenko

Re: Review Request 72378: HIVE-23201: Improve logging in locking

> On April 22, 2020, 11:46 a.m., Denys Kuzmenko wrote: > > Looks good, however I don't really like change with > > REQ_LOCKS_ALIASED_FIELDS as it generats much bigger query (keep in mind > > there 3 of them joined by union, will be 4 for excl_write) + we are > > transfering more data that we

Re: Review Request 72378: HIVE-23201: Improve logging in locking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220419 --- Looks good, however I don't really like change with

Re: Review Request 72378: HIVE-23201: Improve logging in locking

> On April 21, 2020, 10:38 a.m., Denys Kuzmenko wrote: > > LGTM, just number of comments Thanks for the review Denys! As per your comments, I have elevated the log levels, removed the less useful log lines and changed the original statements to prepared statements. - Marton

Re: Review Request 72378: HIVE-23201: Improve logging in locking

> On April 21, 2020, 10:38 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 4427 (patched) > > > > > > I would keep

Re: Review Request 72378: HIVE-23201: Improve logging in locking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220389 --- LGTM, just number of comments

Re: Review Request 72378: HIVE-23201: Improve logging in locking

> On April 17, 2020, 1:46 p.m., Peter Vary wrote: > > Mostly agree, few comments. > > I would like to ask you to go through them, and if there are any places > > where the problem should not happen use at least info level. > > > > Thanks, > > Peter Thanks for the review Peter! I've made

Re: Review Request 72378: HIVE-23201: Improve logging in locking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220347 --- Mostly agree, few comments. I would like to ask you to go through