httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
In r951893, httpd modified a #define for APLOG_MARK to add in a new parameter called APLOG_MODULE_INDEX (in addition to file and line info). This busts Subversion - specifically, mod_authz_svn which has a function called: static void log_access_verdict(const char *file, int line,

Re: HTTPD upgraded on eos - 2.3.8

2010-08-25 Thread Paul Querna
On Tue, Aug 24, 2010 at 10:59 PM, Ruediger Pluem rpl...@apache.org wrote: On 08/25/2010 02:10 AM, Tony Stevenson wrote: On Wed, Aug 25, 2010 at 01:04:01AM +0100, Tony Stevenson wrote: Had to comment out an output filter line in the main httpd.conf (line 117) More specifically had to

Re: HTTPD upgraded on eos - 2.3.8

2010-08-25 Thread Nick Kew
On 25 Aug 2010, at 07:41, Paul Querna wrote: Grump old man mode, this seems moderately disturbing. Previously it was single hash table look up on the content-type, which contained a list of all filters to apply. With lots of brokenness, discussed quite a few times over the years. This was

Re: HTTPD upgraded on eos - 2.3.8

2010-08-25 Thread Nick Kew
On 25 Aug 2010, at 08:01, Nick Kew wrote: With lots of brokenness, discussed quite a few times over the years. This was a long-overdue round tuit. PR 33499 isn't the best reference, but is the first one to come up on a bugzilla search. Bugzilla references go as far back as 2002. I

RE: HTTPD upgraded on eos - 2.3.8

2010-08-25 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Nick Kew [mailto:n...@webthing.com] Sent: Mittwoch, 25. August 2010 09:02 To: dev@httpd.apache.org Subject: Re: HTTPD upgraded on eos - 2.3.8 On 25 Aug 2010, at 07:41, Paul Querna wrote: Grump old man mode, this seems moderately disturbing.

RE: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: justin.erenkra...@gmail.com Sent: Mittwoch, 25. August 2010 08:14 To: dev@httpd.apache.org Cc: Subversion Development Subject: httpd trunk broken with Subversion: ap_log_rerror busted In r951893, httpd modified a #define for APLOG_MARK to add in a

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Rainer Jung
On 25.08.2010 10:59, Plüm, Rüdiger, VF-Group wrote: -Original Message- From: justin.erenkra...@gmail.com Yes, we could fix this by making mod_authz_svn conditional on the new MMN, but - again, it's about even figuring out that the API is changed and what to do about it. The root

RE: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Rainer Jung Sent: Mittwoch, 25. August 2010 11:15 To: dev@httpd.apache.org Cc: Subversion Development Subject: Re: httpd trunk broken with Subversion: ap_log_rerror busted On 25.08.2010 10:59, Plüm, Rüdiger, VF-Group wrote: -Original Message-

Anyone knows how http://httpd.apache.org/docs/current/ works?

2010-08-25 Thread Rainer Jung
BZ 49818 informs us, that the language links on http://httpd.apache.org/docs/current/ are broken. They work for /2.2/, /trunk/ etc. but not for current. I can't find any files for /current/ on people.apache.org, so I assume it is mapped via configuration to the 2.2 docs. Does anyone know

Re: Anyone knows how http://httpd.apache.org/docs/current/ works?

2010-08-25 Thread Rainer Jung
On 25.08.2010 12:15, Rainer Jung wrote: BZ 49818 informs us, that the language links on http://httpd.apache.org/docs/current/ are broken. They work for /2.2/, /trunk/ etc. but not for current. I can't find any files for /current/ on people.apache.org, so I assume it is mapped via

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Rainer Jung
On 25.08.2010 11:19, Plüm, Rüdiger, VF-Group wrote: Maybe we should put a link to http://httpd.apache.org/docs/trunk/developer/new_api_2_4.html in the Module Developer Changes section in http://httpd.apache.org/docs/trunk/new_features_2_4.html Done in r988987. Rainer

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Stefan Fritsch
On Tue, 24 Aug 2010, Justin Erenkrantz wrote: In r951893, httpd modified a #define for APLOG_MARK to add in a new parameter called APLOG_MODULE_INDEX (in addition to file and line info). This busts Subversion - specifically, mod_authz_svn which has a function called: static void

Re: HTTPD upgraded on eos - 2.3.8

2010-08-25 Thread Jim Jagielski
On Aug 25, 2010, at 4:05 AM, Plüm, Rüdiger, VF-Group wrote: I remember these discussions as well (sorry no detailed pointers) that AddOutputFilterByType was broken and that it should be removed or fixed. It is even marked a deprecated in the Apache 2.2 documentation for 2.2 This is an

[VOTE] Release httpd-2.3.8 (alpha)

2010-08-25 Thread Jim Jagielski
The pre-release test tarballs for httpd-2.3.8 (alpha) are available for download, test and fun: http://httpd.apache.org/dev/dist/ Since this is an alpha release, and since we don't want to release over the weekend, I'll close the vote Monday, 9/30 at 9am eastern.

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 1:59 AM, Plüm, Rüdiger, VF-Group ruediger.pl...@vodafone.com wrote: Basicly all this stuff is done to use the advanced features of C99 compilers that allow us to check with low effort whether a call to the error logging function is needed at all given the currently

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 4:48 AM, Stefan Fritsch s...@sfritsch.de wrote: I agree that the comments/documentation should be improved. I will write a how-to for adjusting modules to the new API. Here is a constructive suggestion (*grin*): in APR, for some of the more complex declarations (see

Re: [VOTE] Release httpd-2.3.8 (alpha)

2010-08-25 Thread Rainer Jung
On 25.08.2010 16:23, Jim Jagielski wrote: The pre-release test tarballs for httpd-2.3.8 (alpha) are available for download, test and fun: http://httpd.apache.org/dev/dist/ Since this is an alpha release, and since we don't want to release over the weekend, I'll close the vote Monday,

Re: [PRERELEASE TARBALLS] httpd-2.3.8

2010-08-25 Thread William A. Rowe Jr.
On 8/25/2010 12:50 AM, Ruediger Pluem wrote: Very valid reasons and I am as a 'Unix' guy not hurt that much by the stopped bundling of PCRE. OTOH there seems to be a real problem on Netware and Windows and we might should spend some time in providing better build instructions / scripts how

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread William A. Rowe Jr.
On 8/25/2010 9:56 AM, Justin Erenkrantz wrote: This is the crux of my concern - should improve performance at the very substantial cost of increasing complexity for understanding the codebase (especially without comments). That is nonsense; providing debug-level granularity of one module and

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Eric Covener
On Wed, Aug 25, 2010 at 11:31 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: On Wed, Aug 25, 2010 at 4:48 AM, Stefan Fritsch s...@sfritsch.de wrote: I agree that the comments/documentation should be improved. I will write a how-to for adjusting modules to the new API. Here is a

Re: [PRERELEASE TARBALLS] httpd-2.3.8

2010-08-25 Thread Sander Temme
On Aug 24, 2010, at 3:04 PM, Guenter Knauf wrote: Between your alternatives: [ ] YES - include recent PCRE again with dependencies (means we create a PCRE repo in svn, check in a recent version, and add platform-dependent makefiles which are fully integrated into main build

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Ruediger Pluem
On 08/25/2010 07:57 PM, William A. Rowe Jr. wrote: On 8/25/2010 9:56 AM, Justin Erenkrantz wrote: This is the crux of my concern - should improve performance at the very substantial cost of increasing complexity for understanding the codebase (especially without comments). That is

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 12:14 PM, Ruediger Pluem rpl...@apache.org wrote: I guess his comment was more about the macro wrappers and the C99 stuff, which saves us the function call if we would not log due to the loglevel currently set. I think this is one aspect of the changes and one were we

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Stefan Fritsch
On Wednesday 25 August 2010, Justin Erenkrantz wrote: On Wed, Aug 25, 2010 at 12:14 PM, Ruediger Pluem rpl...@apache.org wrote: I guess his comment was more about the macro wrappers and the C99 stuff, which saves us the function call if we would not log due to the loglevel currently set. I

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 2:51 PM, Stefan Fritsch s...@sfritsch.de wrote: This is a good idea. I have started it in r989377. Thanks! -- justin