Re: svn commit: r1853901 - /httpd/httpd/trunk/modules/filters/mod_reqtimeout.c

2019-02-20 Thread Yann Ylavic
On Wed, Feb 20, 2019 at 8:05 AM Ruediger Pluem wrote: > > On 2019/02/19 17:21:09, yla...@apache.org wrote: > > > > -#define MERGE_INT(cfg, b, a, val) cfg->val = (a->val == UNSET) ? b->val : > > a->val; > > +#define MERGE_INT(cfg, b, a, val) \ > > +cfg->val = (a->val == UNSET) ? b->val : a->va

Re: svn commit: r1853953 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

2019-02-20 Thread Yann Ylavic
On Wed, Feb 20, 2019 at 2:04 PM Ruediger Pluem wrote: > > Shouldn't we add (rb_method == RB_STREAM_CHUNKED) as condition to the above > if as this only seems to make sense in the chunked encoding case? Well, I think it makes no sense in both cases, but it was there in stream_reqbody_cl() so I th

AW: svn commit: r1853953 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

2019-02-20 Thread Plüm , Rüdiger , Vodafone Group
My bad. I misread the diff. It was there in stream_reqbody_chunked and stream_reqbody_cl. So the condition is correct. Regards Rüdiger C2 General > -Ursprüngliche Nachricht- > Von: Yann Ylavic > Gesendet: Mittwoch, 20. Februar 2019 14:25 > An: httpd-dev > Betreff: Re: svn commit: r1

Re: svn commit: r1853939 - /httpd/httpd/branches/2.4.x/STATUS

2019-02-20 Thread ste...@eissing.org
> Am 20.02.2019 um 10:53 schrieb yla...@apache.org: > > Author: ylavic > Date: Wed Feb 20 09:53:30 2019 > New Revision: 1853939 > > URL: http://svn.apache.org/viewvc?rev=1853939&view=rev > Log: > Propose. > > Modified: >httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branches

Re: svn commit: r1853939 - /httpd/httpd/branches/2.4.x/STATUS

2019-02-20 Thread ste...@eissing.org
Ok, I think I understood: - On a h2 slave connection, slave->keepalives is always > 0, to keep certain parts of our server from thinking "Oh, this is the first request!" - mod_reqtimeout interprets this as "we are inbetween requests", ccfg->in_keep_alive != 0 - mod_reqtimeout.c:184+ input filter

Re: svn commit: r1853939 - /httpd/httpd/branches/2.4.x/STATUS

2019-02-20 Thread ste...@eissing.org
Ok, got a fix in r1853967 and propose to include in mod_reqtimeout backport. Cheers, Stefan > Am 20.02.2019 um 16:09 schrieb ste...@eissing.org: > > Ok, I think I understood: > > - On a h2 slave connection, slave->keepalives is always > 0, to keep certain > parts of our server from thinking "O

Re: svn commit: r1853939 - /httpd/httpd/branches/2.4.x/STATUS

2019-02-20 Thread Yann Ylavic
Included, thanks Stefan! On Wed, Feb 20, 2019 at 4:57 PM ste...@eissing.org wrote: > > Ok, got a fix in r1853967 and propose to include in mod_reqtimeout backport. > > Cheers, Stefan > > > Am 20.02.2019 um 16:09 schrieb ste...@eissing.org: > > > > Ok, I think I understood: > > > > - On a h2 slave

Anyone interested in a freelance opportunity?

2019-02-20 Thread Daniel Ruggeri
Hi, all; I was approached to see if I would be interested/willing to work on code to support encrypted client keys for the proxy. Unfortunately, I had to pass since I just don't have the time, but figured I'd reach out here to see if anyone here has the time/expertise/interest. I know it'

Re: HTTP Method Patch

2019-02-20 Thread Christophe JAILLET
Le 20/02/2019 à 14:58, Hajo Locke a écrit : Hello list, this is Apache 2.4.34 I was asked if Apache is supporting HTTP Request Methode PATCH. To be honest i did not really found something useful in the web. Is Apache supporting this method and is an additionally modul required? Iam not aware of