http and http/1.x separation

2022-01-24 Thread Stefan Eissing
FYI: I am busy hacking away at the separation between our HTTP and HTTP/1.x handling code. I'll make a PR once all tests have passed, so we can talk about the changes. The goals are pretty simple: 1. have mod_http focus on HTTP semantics, header checks, ap_die conversions, not chunking and

Re: http and http/1.x separation

2022-01-24 Thread Stefan Eissing
> Am 24.01.2022 um 15:40 schrieb Yann Ylavic : > > On Mon, Jan 24, 2022 at 3:28 PM Stefan Eissing wrote: >> >> FYI: I am busy hacking away at the separation between our HTTP and HTTP/1.x >> handling code. I'll make a PR once all tests have passed, so w

trunk test failure, SSL handshake

2022-01-25 Thread Stefan Eissing
Failure in https://app.travis-ci.com/github/apache/httpd/jobs/556778281 indicates that the SSL handshake timeout no longer is working. Also logs mpm:error several times. The test opens a socket and sends one byte, then waits for the connection to close with the configured timeout. Run locally wit

mpm event assertion failures

2022-01-25 Thread Stefan Eissing
Also, while running the http2 test suite, I get repeated assert failures in event.c:1230 if (rv != APR_SUCCESS && !APR_STATUS_IS_EEXIST(rv)) { -> AP_DEBUG_ASSERT(0); TO_QUEUE_REMOVE(cs->sc->wc_q, cs); apr_thread_mutex_unlock(timeout_mutex); ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_

Re: http and http/1.x separation

2022-01-25 Thread Stefan Eissing
> Am 25.01.2022 um 17:42 schrieb Roy T. Fielding : > >> On Jan 24, 2022, at 6:53 AM, Stefan Eissing wrote: >> >> >> >>> Am 24.01.2022 um 15:40 schrieb Yann Ylavic : >>> >>> On Mon, Jan 24, 2022 at 3:28 PM Stefan Eissing wrote:

Re: trunk test failure, SSL handshake

2022-01-26 Thread Stefan Eissing
> Am 25.01.2022 um 21:59 schrieb Yann Ylavic : > > Stefan, > > On Tue, Jan 25, 2022 at 12:58 PM Stefan Eissing wrote: >> >> Failure in https://app.travis-ci.com/github/apache/httpd/jobs/556778281 >> indicates that the SSL handshake timeout no longer i

Re: mpm event assertion failures

2022-01-26 Thread Stefan Eissing
> Am 25.01.2022 um 22:25 schrieb Graham Leggett : > > On 25 Jan 2022, at 14:11, Stefan Eissing wrote: > >> Also, while running the http2 test suite, I get repeated assert failures in >> event.c:1230 >> >> if (rv != APR_SUCCESS && !APR_STAT

Re: mpm event assertion failures

2022-01-27 Thread Stefan Eissing
> Am 26.01.2022 um 17:06 schrieb Graham Leggett : > > On 26 Jan 2022, at 13:49, Stefan Eissing wrote: > >> Guys, we have changes in a central part of the server and our CI fails.=20= >> >> It is not good enough to give other people unspecific homework to fix =

Re: mpm event assertion failures

2022-01-27 Thread Stefan Eissing
a branch with the changes by Graham, so we can inspect it and discuss via github? Graham, is that ok with you? I am open to other ideas. Kind Regards, Stefan > Am 27.01.2022 um 10:50 schrieb Stefan Eissing : > > > >> Am 26.01.2022 um 17:06 schrieb Graham Leggett : >>

Re: mpm event assertion failures

2022-01-29 Thread Stefan Eissing
> Am 28.01.2022 um 13:44 schrieb Yann Ylavic : > > On Thu, Jan 27, 2022 at 3:17 PM Stefan Eissing wrote: >> >> Testing my changes, I noticed that the poxy/ssl tests now take about 4 >> minutes to complete. I reverted and it stays the same on current trunk: >

HTTP and HTTP/1.x separation

2022-02-03 Thread Stefan Eissing
My PR regarding separation of HTTP/1.1 and generic HTTP filters: https://github.com/apache/httpd/pull/291 There is more to be done, but I think this is a good start. Kind Regards, Stefan

SSL handshake nonblocking as PR

2022-02-04 Thread Stefan Eissing
https://github.com/apache/httpd/pull/293 is the PR that contains the changes I just reverted in trunk regarding the non-blocking SSL handshake. I did not like to revert a set of changes by anyone here. But our trunk CI is failing for some time now and I felt this needs to be analyzed without int

Re: svn commit: r1897760 - in /httpd/httpd/trunk: ./ changes-entries/ include/ modules/generators/ modules/ssl/ server/mpm/event/ support/ test/modules/http2/

2022-02-04 Thread Stefan Eissing
> Am 04.02.2022 um 15:49 schrieb Yann Ylavic : > > On Fri, Feb 4, 2022 at 1:22 PM wrote: >> >> Author: icing >> Date: Fri Feb 4 12:22:26 2022 >> New Revision: 1897760 >> >> URL: http://svn.apache.org/viewvc?rev=1897760&view=rev >> Log: >> *) core/mod_ssl/mpm_event: reverting changes to non

Re: svn commit: r1897760 - in /httpd/httpd/trunk: ./ changes-entries/ include/ modules/generators/ modules/ssl/ server/mpm/event/ support/ test/modules/http2/

2022-02-04 Thread Stefan Eissing
> Am 04.02.2022 um 16:18 schrieb Yann Ylavic : > > On Fri, Feb 4, 2022 at 1:22 PM wrote: >> >> Modified: httpd/httpd/trunk/modules/ssl/mod_ssl.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/mod_ssl.c?rev=1897760&r1=1897759&r2=1897760&view=diff >>

Re: svn commit: r1897760 - in /httpd/httpd/trunk: ./ changes-entries/ include/ modules/generators/ modules/ssl/ server/mpm/event/ support/ test/modules/http2/

2022-02-04 Thread Stefan Eissing
FYI: out trunk travis is green again: https://app.travis-ci.com/github/apache/httpd/builds/245924953 > Am 04.02.2022 um 17:05 schrieb Stefan Eissing : > > > >> Am 04.02.2022 um 16:18 schrieb Yann Ylavic : >> >> On Fri, Feb 4, 2022 at 1:22 PM wrote: >&g

Re: mpm event assertion failures

2022-02-07 Thread Stefan Eissing
> Am 06.02.2022 um 23:00 schrieb Graham Leggett : > > On 25 Jan 2022, at 23:25, Graham Leggett wrote: > >> Is the http2 code doing anything to work around mod_ssl trying to read, >> failing, throwing away the error, and then pretending nothing happened? > > The http2 code doesn't try to wor

Re: Python test suite - failures on Fedora Rawhide / MacOS

2022-02-07 Thread Stefan Eissing
Graham, could you attach a complete failed output of your pytest run? I use it on MacOS all the time and it seems most likely that some prerequisites have not been documented well enough or checks must add more information in output. Kind Regards, Stefan > Am 07.02.2022 um 11:14 schrieb Graha

Re: SSL handshake nonblocking as PR

2022-02-07 Thread Stefan Eissing
> Am 06.02.2022 um 21:20 schrieb Graham Leggett : > > On 04 Feb 2022, at 14:49, Stefan Eissing wrote: > >> https://github.com/apache/httpd/pull/293 >> >> is the PR that contains the changes I just reverted >> in trunk regarding the non-blocking SSL

Re: mpm event assertion failures

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 11:31 schrieb Graham Leggett : > > On 07 Feb 2022, at 12:18, Stefan Eissing wrote: > >>>> Is the http2 code doing anything to work around mod_ssl trying to read, >>>> failing, throwing away the error, and then pretending nothing happe

Re: Python test suite - failures on Fedora Rawhide / MacOS

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 11:26 schrieb Graham Leggett : > > On 07 Feb 2022, at 12:23, Stefan Eissing wrote: > >> could you attach a complete failed output of your pytest run? I use it on >> MacOS all the time and >> it seems most likely that some prerequisites

Re: Python test suite - failures on Fedora Rawhide / MacOS

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 11:42 schrieb Stefan Eissing : > > > >> Am 07.02.2022 um 11:26 schrieb Graham Leggett : >> >> On 07 Feb 2022, at 12:23, Stefan Eissing wrote: >> >>> could you attach a complete failed output of your pytest run? I use it on

Re: mpm event assertion failures

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 12:19 schrieb Graham Leggett : > > On 07 Feb 2022, at 12:35, Stefan Eissing wrote: > >>> There are two parts that hook into the process_connection hook, the code >>> you’ve cited above, and this code: >>> >>> void h2_

Re: Python test suite - failures on Fedora Rawhide / MacOS

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 12:21 schrieb Graham Leggett : > > On 07 Feb 2022, at 12:42, Stefan Eissing wrote: > >>> curl -V >> curl 7.77.0 (x86_64-apple-darwin21.0) libcurl/7.77.0 (SecureTransport) >> LibreSSL/2.8.3 zlib/1.2.11 nghttp2/1.42.0 >> Release-Date:

Re: mpm event assertion failures

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 12:46 schrieb Yann Ylavic : > > On Mon, Feb 7, 2022 at 12:41 PM Yann Ylavic wrote: >> >> On Tue, Jan 25, 2022 at 1:12 PM Stefan Eissing wrote: >>> >>> Also, while running the http2 test suite, I get repeated assert failur

Re: mpm event assertion failures

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 13:47 schrieb Yann Ylavic : > > On Mon, Feb 7, 2022 at 1:29 PM Yann Ylavic wrote: >> >> On Mon, Feb 7, 2022 at 1:01 PM Stefan Eissing wrote: >>> > [] >> >> there are still failures for >> mod_md still I hav

Re: mpm event assertion failures

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 14:44 schrieb Stefan Eissing : > > > >> Am 07.02.2022 um 13:47 schrieb Yann Ylavic : >> >> On Mon, Feb 7, 2022 at 1:29 PM Yann Ylavic wrote: >>> >>> On Mon, Feb 7, 2022 at 1:01 PM Stefan Eissing wrote: >>>>

Re: mpm event assertion failures

2022-02-07 Thread Stefan Eissing
> Am 07.02.2022 um 17:13 schrieb Yann Ylavic : > > On Mon, Feb 7, 2022 at 3:41 PM Stefan Eissing wrote: >> >> >> >>> Am 07.02.2022 um 14:44 schrieb Stefan Eissing : >>> >>> >>> >>>> Am 07.02.2022 um 13:47 schrieb

release vibes?

2022-02-08 Thread Stefan Eissing
Is there any consensus in doing a release this month?

Re: svn commit: r1897858 - in /httpd/httpd/trunk: ./ changes-entries/

2022-02-08 Thread Stefan Eissing
> Am 08.02.2022 um 13:14 schrieb Yann Ylavic : > > On Tue, Feb 8, 2022 at 12:47 PM Rainer Jung wrote: >> >> Small typo below ... >> >> Am 08.02.2022 um 12:04 schrieb yla...@apache.org: >>> + >>> + *) mom_reqtimeout: Fix missing handshake= timeout enforcement. [Yann >>> Ylavic] >> >> s/mo

Re: svn commit: r1897872 - in /httpd/httpd/trunk: changes-entries/http2_request_scheme.txt modules/http2/h2_stream.c test/modules/http2/test_003_get.py

2022-02-09 Thread Stefan Eissing
> Am 09.02.2022 um 10:15 schrieb Ruediger Pluem : > > > > On 2/8/22 7:10 PM, Roy T. Fielding wrote: >> As noted in >> >> https://github.com/icing/mod_h2/issues/230#issuecomment-1032905432 >> >> This doesn't look right to me. I think what you want is to verify that https >> is >> in a sec

Re: mpm event assertion failures

2022-02-10 Thread Stefan Eissing
> Am 09.02.2022 um 22:49 schrieb Graham Leggett : > > On 09 Feb 2022, at 17:43, Yann Ylavic wrote: > >> So ab is (appropriately?) reporting errors for kept-alive connections >> that had to be shutdown earlier than KeepAliveTimeout, although I >> suspect that it would report the same after the

Re: svn commit: r1897872 - in /httpd/httpd/trunk: changes-entries/http2_request_scheme.txt modules/http2/h2_stream.c test/modules/http2/test_003_get.py

2022-02-10 Thread Stefan Eissing
> Am 10.02.2022 um 00:57 schrieb Roy T. Fielding : > >> On Feb 9, 2022, at 1:28 AM, Stefan Eissing wrote: >>> Am 09.02.2022 um 10:15 schrieb Ruediger Pluem : >>> On 2/8/22 7:10 PM, Roy T. Fielding wrote: >>>> As noted in >>>> >>

Re: svn commit: r1897940 - in /httpd/httpd/trunk: changes-entries/http2_request_scheme.txt modules/http2/h2_c2.c modules/http2/h2_request.c modules/http2/h2_stream.c test/modules/http2/test_003_get.py

2022-02-10 Thread Stefan Eissing
> Am 10.02.2022 um 14:00 schrieb Ruediger Pluem : > > > > On 2/10/22 11:59 AM, ic...@apache.org wrote: >> Author: icing >> Date: Thu Feb 10 10:59:08 2022 >> New Revision: 1897940 >> >> URL: http://svn.apache.org/viewvc?rev=1897940&view=rev >> Log: >> *) mod_http2: :scheme pseudo-header valu

Re: svn commit: r1897940 - in /httpd/httpd/trunk: changes-entries/http2_request_scheme.txt modules/http2/h2_c2.c modules/http2/h2_request.c modules/http2/h2_stream.c test/modules/http2/test_003_get.py

2022-02-10 Thread Stefan Eissing
> Am 10.02.2022 um 15:26 schrieb Ruediger Pluem : > > > > On 2/10/22 2:18 PM, Stefan Eissing wrote: >> >> >>> Am 10.02.2022 um 14:00 schrieb Ruediger Pluem : >>> >>> >>> >>> On 2/10/22 11:59 AM, ic...@apache.or

opinion poll, stale issues

2022-02-16 Thread Stefan Eissing
How about we close stale issues on our bugzilla after a year without changes with WONTFIX We are sorry, but no one found the interest/time to work on this. ideally as an automated job somewhere? Kind Regards, Stefan

Re: opinion poll, stale issues

2022-02-17 Thread Stefan Eissing
> Am 16.02.2022 um 14:12 schrieb Ruediger Pluem : > > > > On 2/16/22 10:32 AM, Stefan Eissing wrote: >> How about we close stale issues on our bugzilla after a year without changes >> with >> >> WONTFIX >> We are sorry, but no one found the int

Re: svn commit: r1898146 - in /httpd/httpd/trunk: changes-entries/pr65881.txt modules/http2/h2_request.c test/modules/http2/htdocs/cgi/hello.py test/modules/http2/test_502_proxy_port.py

2022-02-17 Thread Stefan Eissing
> Am 17.02.2022 um 11:49 schrieb Ruediger Pluem : > > > > On 2/17/22 11:06 AM, ic...@apache.org wrote: >> Author: icing >> Date: Thu Feb 17 10:06:31 2022 >> New Revision: 1898146 >> >> URL: http://svn.apache.org/viewvc?rev=1898146&view=rev >> Log: >> *) mod_http2: preserve the port number g

Re: opinion poll, stale issues

2022-02-21 Thread Stefan Eissing
n the "older than a year" basket, almost all of them > are still valid - just we haven't had time to address them yet. It would be a > shame to lose this information, as it's what I pick away at when I have spare > moments now and then. > > --Rich > > On

Re: svn commit: r1898255 - in /httpd/httpd/trunk/modules/proxy: mod_proxy_ftp.c proxy_util.c

2022-02-21 Thread Stefan Eissing
Hero! > Am 20.02.2022 um 16:08 schrieb jaillet...@apache.org: > > Author: jailletc36 > Date: Sun Feb 20 15:08:30 2022 > New Revision: 1898255 > > URL: http://svn.apache.org/viewvc?rev=1898255&view=rev > Log: > Remove some APR 0.x stuff. > > The minimum supported version is 1.3 in 2.4.x > > Mod

module threads and mpm lifecycle

2022-02-23 Thread Stefan Eissing
One thing that is currently missing is a way to shutdown/reap/join module threads when the mpm exits. Example: mod_watchdog creates several threads post_config which are only joined on pool destruction. Problem: pool destruction is not ordered between modules and dependencies on order are n

Re: module threads and mpm lifecycle

2022-02-23 Thread Stefan Eissing
> Am 23.02.2022 um 11:52 schrieb Ruediger Pluem : > > > > On 2/23/22 11:39 AM, Stefan Eissing wrote: >> One thing that is currently missing is a way to shutdown/reap/join module >> threads when the mpm exits. >> >> Example: >> >> mod_wat

Re: module threads and mpm lifecycle

2022-02-23 Thread Stefan Eissing
> Am 23.02.2022 um 13:24 schrieb Stefan Eissing : > > > >> Am 23.02.2022 um 11:52 schrieb Ruediger Pluem : >> >> >> >> On 2/23/22 11:39 AM, Stefan Eissing wrote: >>> One thing that is currently missing is a way to shutdown/reap/join modul

Re: module threads and mpm lifecycle

2022-02-24 Thread Stefan Eissing
Added in r1898369 on trunk as `child_stopped`. Kind Regards, Stefan > Am 23.02.2022 um 15:49 schrieb Niklas Edmundsson : > > On Wed, 23 Feb 2022, Stefan Eissing wrote: > >>>> On 2/23/22 11:39 AM, Stefan Eissing wrote: >>>>> One thing that is currently

Re: module threads and mpm lifecycle

2022-02-25 Thread Stefan Eissing
> Am 25.02.2022 um 14:15 schrieb Graham Leggett : > > On 23 Feb 2022, at 12:39, Stefan Eissing wrote: > >> One thing that is currently missing is a way to shutdown/reap/join module >> threads when the mpm exits. >> >> Example: >> >> mod_wa

intent to make a release candidate on Monday

2022-03-03 Thread Stefan Eissing
There are some important fixes pending release. Work does not appear to slow down in the foreseeable future, so I'd like us to make them available. Looking at 2.4.x STATUS, there are 3 backport proposals lacking 1 vote: - dbm: Split the loading of a dbm driver - mod_proxy: Bump shared worker name

Re: intent to make a release candidate on Monday

2022-03-03 Thread Stefan Eissing
> Am 03.03.2022 um 14:32 schrieb Jim Jagielski : > > All three promoted. I went ahead and merged the 'dbm' patch Thanks, Jim! > >> On Mar 3, 2022, at 4:37 AM, Stefan Eissing wrote: >> >> There are some important fixes pending release. Wor

Re: svn commit: r1898566 - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/cache/ modules/dav/fs/ modules/dav/lock/ modules/mappers/ modules/proxy/

2022-03-04 Thread Stefan Eissing
> Am 04.03.2022 um 08:32 schrieb Ruediger Pluem : > > > > On 3/3/22 5:40 PM, Joe Orton wrote: >> On Thu, Mar 03, 2022 at 05:11:52PM +0100, Ruediger Pluem wrote: >>> On 3/3/22 4:49 PM, Joe Orton wrote: Folks (in no way pointing a finger at Jim who just did merging duty), it is not h

Re: svn commit: r1898566 - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/cache/ modules/dav/fs/ modules/dav/lock/ modules/mappers/ modules/proxy/

2022-03-04 Thread Stefan Eissing
> Am 04.03.2022 um 09:46 schrieb Ruediger Pluem : > > > > On 3/4/22 9:24 AM, Stefan Eissing wrote: >> >> >>> Am 04.03.2022 um 08:32 schrieb Ruediger Pluem : >>> >>> >>> >>> On 3/3/22 5:40 PM, Joe Orton wrote: >&

Re: svn commit: r1898586 - in /httpd/httpd/branches/2.4.x: ./ changes-entries/pr65881.txt modules/http2/h2_request.c test/modules/http2/env.py test/modules/http2/htdocs/cgi/hello.py test/modules/http2

2022-03-04 Thread Stefan Eissing
> Am 04.03.2022 um 10:22 schrieb Ruediger Pluem : > > > > On 3/4/22 9:51 AM, ic...@apache.org wrote: >> Author: icing >> Date: Fri Mar 4 08:51:47 2022 >> New Revision: 1898586 >> >> URL: http://svn.apache.org/viewvc?rev=1898586&view=rev >> Log: >> merge of 1898146,1898173 from trunk: >> >>

backports

2022-03-04 Thread Stefan Eissing
We should improve our backport procedure and provide guidance on how to use it after the next release. Post-mortem dbm backport: - the patch pointed to the in 2.4.x/STATUS was incomplete, lacking APLOGNO() - the incomplete patch was voted on and accepted, as local tests do not have the full CI c

Re: svn commit: r1898586 - in /httpd/httpd/branches/2.4.x: ./ changes-entries/pr65881.txt modules/http2/h2_request.c test/modules/http2/env.py test/modules/http2/htdocs/cgi/hello.py test/modules/http2

2022-03-04 Thread Stefan Eissing
> Am 04.03.2022 um 11:09 schrieb Ruediger Pluem : > > > > On 3/4/22 10:50 AM, Stefan Eissing wrote: >> >> >>> Am 04.03.2022 um 10:22 schrieb Ruediger Pluem : >>> >>> >>> >>> On 3/4/22 9:51 AM, ic...@apache.or

Re: backports

2022-03-05 Thread Stefan Eissing
> Am 04.03.2022 um 18:40 schrieb Roy T. Fielding : > >> On Mar 4, 2022, at 6:17 AM, Eric Covener wrote: >> >> On Fri, Mar 4, 2022 at 9:05 AM Jim Jagielski wrote: >>> >>> A question: Would it be easier for all this if we moved to being Github >>> canon? >> >> I think it is much more straig

Re: backports

2022-03-07 Thread Stefan Eissing
> Am 07.03.2022 um 02:53 schrieb Yann Ylavic : > > On Sat, Mar 5, 2022 at 12:17 PM Stefan Eissing wrote: >> >>> Am 04.03.2022 um 18:40 schrieb Roy T. Fielding : >>> >>>> On Mar 4, 2022, at 6:17 AM, Eric Covener wrote: >>>>

candidate branch/tag names

2022-03-07 Thread Stefan Eissing
Joe, I'll change the release candidate tag/branch names and if that works, you can strip some regex from the travis setup. Kind Regards, Stefan

[VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-07 Thread Stefan Eissing
Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.53-rc1 as 2.4.53: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a

Re: backports

2022-03-08 Thread Stefan Eissing
> Am 08.03.2022 um 14:34 schrieb Jim Jagielski : > >> On Mar 8, 2022, at 7:58 AM, Graham Leggett wrote: >> >> >> I would far rather the empty APLOGNO check was part of the build. >> >> Vastly simpler. >> > > I agree w/ that... I have the feeling that the work that has went into making ou

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-08 Thread Stefan Eissing
For anyone thinking about testing rc1, there is a high chance of an rc2 coming soon. Will announce here, Stefan > Am 08.03.2022 um 16:33 schrieb Rainer Jung : > > > Am 07.03.2022 um 16:55 schrieb Stefan Eissing: >> Hi all, >> Please find below the proposed releas

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-09 Thread Stefan Eissing
CANCELLED. Due to errors/warnings found during your tests, I cancel the vote on rc1. Thanks for giving us these feedbacks! I'll put up the rc2 vote as soon as we're ready. Thanks, Stefan > Am 09.03.2022 um 08:50 schrieb Ruediger Pluem : > > > > On 3/8/22 10:09 PM, Rainer Jung wrote: >> >

Re: backports

2022-03-09 Thread Stefan Eissing
> Am 09.03.2022 um 13:11 schrieb Yann Ylavic : > > On Tue, Mar 8, 2022 at 2:34 PM Jim Jagielski wrote: >> >>> On Mar 8, 2022, at 7:58 AM, Graham Leggett wrote: >>> >>> I would far rather the empty APLOGNO check was part of the build. >>> >>> Vastly simpler. >> >> >> I agree w/ that... >

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-09 Thread Stefan Eissing
> Am 09.03.2022 um 14:25 schrieb Yann Ylavic : > > On Tue, Mar 8, 2022 at 6:22 PM Rainer Jung wrote: >> >> - configure for APR in the dependency tarball still fails for me due to >> a bug in autoconf 2.71 used to create the configure script. That problem >> was already reported by me during a

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-09 Thread Stefan Eissing
Are we ready for an rc2 for 2.4.53? > Am 09.03.2022 um 14:44 schrieb Stefan Eissing : > > > >> Am 09.03.2022 um 14:25 schrieb Yann Ylavic : >> >> On Tue, Mar 8, 2022 at 6:22 PM Rainer Jung wrote: >>> >>> - configure for APR in the dependenc

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-09 Thread Stefan Eissing
> Am 09.03.2022 um 15:05 schrieb Ruediger Pluem : > > > > On 3/9/22 2:46 PM, Stefan Eissing wrote: >> Are we ready for an rc2 for 2.4.53? > > With r1898786 I would say yes. Thanks everyone, will do. > > Regards > > Rüdiger >

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-09 Thread Stefan Eissing
> Am 09.03.2022 um 15:07 schrieb Stefan Eissing : > > > >> Am 09.03.2022 um 15:05 schrieb Ruediger Pluem : >> >> >> >> On 3/9/22 2:46 PM, Stefan Eissing wrote: >>> Are we ready for an rc2 for 2.4.53? >> >> With r1898786 I wo

[VOTE] Release httpd-2.4.53-rc2 as httpd-2.4.53

2022-03-09 Thread Stefan Eissing
Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.53-rc2 as 2.4.53: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a

Re: [VOTE] Release httpd-2.4.53-rc2 as httpd-2.4.53

2022-03-10 Thread Stefan Eissing
> Am 09.03.2022 um 17:19 schrieb Stefan Eissing : > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candida

Re: [VOTE] Release httpd-2.4.53-rc2 as httpd-2.4.53

2022-03-11 Thread Stefan Eissing
? > Am 09.03.2022 um 17:19 schrieb Stefan Eissing : > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarb

Re: [VOTE] Release httpd-2.4.53-rc2 as httpd-2.4.53

2022-03-11 Thread Stefan Eissing
Thank you all! With 7 +1 votes and no other, I announce rc2 has passed. I will do the release of 2.4.53 on Monday. Kind Regards and a nice weekend to you all, Stefan > Am 09.03.2022 um 17:19 schrieb Stefan Eissing : > > Hi all, > > Please find below the proposed rele

CVE-2022-23943: Apache HTTP Server: mod_sed: Read/write beyond bounds

2022-03-14 Thread Stefan Eissing
Severity: important Description: Out-of-bounds Write vulnerability in mod_sed of Apache HTTP Server allows an attacker to overwrite heap memory with possibly attacker provided data. This issue affects Apache HTTP Server 2.4 version 2.4.52 and prior versions. Credit: Ronald Crane (Zippenhop LL

CVE-2022-22721: Apache HTTP Server: core: Possible buffer overflow with very large or unlimited LimitXMLRequestBody

2022-03-14 Thread Stefan Eissing
Severity: low Description: If LimitXMLRequestBody is set to allow request bodies larger than 350MB (defaults to 1M) on 32 bit systems an integer overflow happens which later causes out of bounds writes. This issue affects Apache HTTP Server 2.4.52 and earlier. Credit: Anonymous working with

CVE-2022-22720: HTTP request smuggling vulnerability in Apache HTTP Server 2.4.52 and earlier

2022-03-14 Thread Stefan Eissing
Severity: important Description: Apache HTTP Server 2.4.52 and earlier fails to close inbound connection when errors are encountered discarding the request body, exposing the server to HTTP Request Smuggling Credit: James Kettle

CVE-2022-22719: Apache HTTP Server: mod_lua Use of uninitialized value of in r:parsebody

2022-03-14 Thread Stefan Eissing
Severity: moderate Description: A carefully crafted request body can cause a read to a random memory area which could cause the process to crash. This issue affects Apache HTTP Server 2.4.52 and earlier. Credit: Chamal De Silva

HTTP and HTTP/1.x separation

2022-03-24 Thread Stefan Eissing
You are invited to have a look at my PR for separating HTTP/1.x processing from generic HTTP protocol handling and verification: https://github.com/apache/httpd/pull/291 I made a description of the changes in the PR that helps reviewing it (I hope). "Changes appear larger than they really are"

Re: Support JSON output in mod_status and mod_info

2022-03-28 Thread Stefan Eissing
> Am 28.03.2022 um 14:28 schrieb Rainer Jung : > > > I am thinking about adding a JSON output format to mod_status and mod_info as > an option controlled by a query string parameter. > > Since writing simple data structures from these modules is much simpler than > parsing and processing a

Re: HTTP and HTTP/1.x separation

2022-03-28 Thread Stefan Eissing
> Am 28.03.2022 um 15:52 schrieb jean-frederic clere : > > On 24/03/2022 13:21, Stefan Eissing wrote: >> You are invited to have a look at my PR for separating HTTP/1.x processing >> from >> generic HTTP protocol handling and verification: >> https://github.co

Re: HTTP and HTTP/1.x separation

2022-03-28 Thread Stefan Eissing
> Am 28.03.2022 um 17:15 schrieb jean-frederic clere : > > On 28/03/2022 16:03, Stefan Eissing wrote: >>> Am 28.03.2022 um 15:52 schrieb jean-frederic clere : >>> >>> On 24/03/2022 13:21, Stefan Eissing wrote: >>>> You are invited to have a

Re: HTTP and HTTP/1.x separation

2022-03-30 Thread Stefan Eissing
> Am 28.03.2022 um 15:52 schrieb jean-frederic clere : > > On 24/03/2022 13:21, Stefan Eissing wrote: >> You are invited to have a look at my PR for separating HTTP/1.x processing >> from >> generic HTTP protocol handling and verification: >> https://github.co

Re: svn commit: r1899390 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h

2022-03-31 Thread Stefan Eissing
> Am 31.03.2022 um 11:55 schrieb Ruediger Pluem : > > > > On 3/31/22 11:11 AM, Ruediger Pluem wrote: >> >> >> On 3/30/22 4:42 PM, jfcl...@apache.org wrote: >>> Author: jfclere >>> Date: Wed Mar 30 14:42:14 2022 >>> New Revision: 1899390 >>> >>> URL: http://svn.apache.org/viewvc?rev=1899390

Re: svn commit: r1899390 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h

2022-04-01 Thread Stefan Eissing
> Am 01.04.2022 um 08:47 schrieb jean-frederic clere : > > On 31/03/2022 12:59, Ruediger Pluem wrote: >> On 3/31/22 12:34 PM, Stefan Eissing wrote: >>> >>> >>>> Am 31.03.2022 um 11:55 schrieb Ruediger Pluem : >>>> &

Re: HTTP and HTTP/1.x separation

2022-04-01 Thread Stefan Eissing
one sitting here locally and will publish that once our CI is working again (and I can be sure that they do as well). Kind Regards, Stefan > Am 31.03.2022 um 09:40 schrieb jean-frederic clere : > > On 30/03/2022 11:11, Stefan Eissing wrote: >>> Am 28.03.2022 um 15:52 schrieb j

PR291 is dead, long live PR306!

2022-04-01 Thread Stefan Eissing
The first PR to separate HTTP and HTTP/1.x processing is in: https://github.com/apache/httpd/pull/306 This is a small subset of PR291 that is easier to read. While it has all API additions from PR291, it only uses a subset in the implementation. With further use coming in future PRs. This PRs f

Re: svn commit: r1899550 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_protocol.h modules/http/http_protocol.c modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2022-04-04 Thread Stefan Eissing
> Am 04.04.2022 um 15:43 schrieb Ruediger Pluem : > > > > On 4/4/22 11:41 AM, ic...@apache.org wrote: >> Author: icing >> Date: Mon Apr 4 09:41:25 2022 >> New Revision: 1899550 >> >> URL: http://svn.apache.org/viewvc?rev=1899550&view=rev >> Log: >> *) core: add ap_h1_append_header() for sing

RESPONSE meta buckets in core

2022-04-04 Thread Stefan Eissing
https://github.com/apache/httpd/pull/307 is my PR on using the new RESPONSE meta bucket in general HTTP processing. Up for review if you like. Kind Regards, Stefan

Re: svn commit: r1899552 - in /httpd/httpd/trunk: modules/http/ modules/proxy/ test/modules/http1/ test/modules/http1/htdocs/ test/modules/http1/htdocs/cgi/ test/modules/http1/htdocs/cgi/files/ test/m

2022-04-05 Thread Stefan Eissing
> Am 04.04.2022 um 16:07 schrieb Ruediger Pluem : > > > > On 4/4/22 1:08 PM, ic...@apache.org wrote: >> Author: icing >> Date: Mon Apr 4 11:08:58 2022 >> New Revision: 1899552 >> >> URL: http://svn.apache.org/viewvc?rev=1899552&view=rev >> Log: >> *) mod_http: genereate HEADERS buckets for

Re: svn commit: r1899552 - in /httpd/httpd/trunk: modules/http/ modules/proxy/ test/modules/http1/ test/modules/http1/htdocs/ test/modules/http1/htdocs/cgi/ test/modules/http1/htdocs/cgi/files/ test/m

2022-04-05 Thread Stefan Eissing
> Am 05.04.2022 um 09:34 schrieb Ruediger Pluem : > > > > On 4/5/22 9:13 AM, Stefan Eissing wrote: >> >> >>> Am 04.04.2022 um 16:07 schrieb Ruediger Pluem : >>> >>> >>> >>> On 4/4/22 1:08 PM, ic...@apache.org wrote:

Re: svn commit: r1899552 - in /httpd/httpd/trunk: modules/http/ modules/proxy/ test/modules/http1/ test/modules/http1/htdocs/ test/modules/http1/htdocs/cgi/ test/modules/http1/htdocs/cgi/files/ test/m

2022-04-05 Thread Stefan Eissing
> Am 05.04.2022 um 10:20 schrieb Ruediger Pluem : > > > > On 4/5/22 9:53 AM, Stefan Eissing wrote: >> >> >>> Am 05.04.2022 um 09:34 schrieb Ruediger Pluem : >>> >>> >>> >>> On 4/5/22 9:13 AM, Stefan Eissin

Re: Current status of mod_h2 test suite?

2022-04-05 Thread Stefan Eissing
Which test suite, the one in trunk or the one from github? Both work best against the respective source. > Am 05.04.2022 um 13:47 schrieb Rainer Jung : > > I try to make the mod_h2 test suite run for me. Some difficulties are > expected due to my non-standard setup, but the first test that seem

Re: Current status of mod_h2 test suite?

2022-04-05 Thread Stefan Eissing
> Am 05.04.2022 um 14:01 schrieb Rainer Jung : > > Hi Stefan, > > Am 05.04.2022 um 13:49 schrieb Stefan Eissing: >> Which test suite, the one in trunk or the one from github? Both work best >> against the respective source. > > the test suite in > >

Re: Current status of mod_h2 test suite?

2022-04-05 Thread Stefan Eissing
> Am 05.04.2022 um 14:08 schrieb Rainer Jung : > > Thaks, will switch to that one. Should have reembered it ... All fine. Hit me with questions if it gives you problems. > > Am 05.04.2022 um 14:04 schrieb Stefan Eissing: >>> Am 05.04.2022 um 14:01 schrieb Rainer J

Re: Adding a2md to httpd sources?

2022-04-08 Thread Stefan Eissing
> Am 07.04.2022 um 13:04 schrieb Rainer Jung : > > Hi there, > > during my experiments with the nice pytest based test suite against 2.4.x I > noticed, that many mod_md tests need "a2md". The sources for this commandline > tool ar in Stefan's GitHub repos for mod_md, but not inside the httpd

REQUEST buckets in core

2022-04-08 Thread Stefan Eissing
With https://github.com/apache/httpd/pull/311 I present my PR for using REQUEST meta buckets in httpd core to split HTTP from HTTP/1.x processing and have core ready for all HTTP versions. 7 files are affected by this PR. Most changed lines are moved from server/protocol.c to modules/http I inv

Re: Adding a2md to httpd sources?

2022-04-08 Thread Stefan Eissing
back from anyone about it….If I >> remember correctly, no one was around to make the cmake and Windows builds >> for it. >> I had given feedback and was able to build it on windows in 2017. In the >> beginning some crashes, but Stefan solved. >>> Op 8 apr. 2022

Re: svn commit: r1899777 - /httpd/httpd/trunk/server/mpm/event/event.c

2022-04-14 Thread Stefan Eissing
> Am 13.04.2022 um 17:33 schrieb Yann Ylavic : > > On Wed, Apr 13, 2022 at 4:22 PM Ruediger Pluem wrote: >> >> On 4/12/22 2:08 PM, yla...@apache.org wrote: >> >>> @@ -3447,9 +3480,11 @@ static void server_main_loop(int remaini >>> continue; >>> } >>> >>> +max_dae

Re: svn commit: r1899648 - in /httpd/httpd/trunk: changes-entries/core_response_buckets.txt include/mod_core.h modules/http/http_core.c modules/http/http_filters.c modules/http/http_protocol.c server/

2022-04-14 Thread Stefan Eissing
> Am 13.04.2022 um 17:16 schrieb Ruediger Pluem : > > > > On 4/7/22 12:41 PM, ic...@apache.org wrote: >> Author: icing >> Date: Thu Apr 7 10:41:46 2022 >> New Revision: 1899648 >> >> URL: http://svn.apache.org/viewvc?rev=1899648&view=rev >> Log: >> *) core/mod_http: use RESPONSE meta bucke

Re: svn commit: r1899777 - /httpd/httpd/trunk/server/mpm/event/event.c

2022-04-14 Thread Stefan Eissing
> Am 14.04.2022 um 10:19 schrieb Yann Ylavic : > > On Thu, Apr 14, 2022 at 9:12 AM Stefan Eissing wrote: >> >> I have the feeling we are in need of some sort of stress tests on >> the overall child management scenarios. Offering my help. > > Thanks Stefan

Re: svn commit: r1899777 - /httpd/httpd/trunk/server/mpm/event/event.c

2022-04-15 Thread Stefan Eissing
> Am 14.04.2022 um 17:54 schrieb Yann Ylavic : > > On Thu, Apr 14, 2022 at 1:43 PM Stefan Eissing wrote: >> >> >> In test/modules/core/test_002_restarts.py there is now a start of this. >> Invoked >> specifically with: >> >> trunk>

Re: svn commit: r1899777 - /httpd/httpd/trunk/server/mpm/event/event.c

2022-04-15 Thread Stefan Eissing
In r1899885 the test checks on dynamic child behaviour on a graceful reload. Is this a setup that allows us to verify behaviour that troubled us in the past? Cheers, Stefan > Am 15.04.2022 um 10:41 schrieb Stefan Eissing : > > > >> Am 14.04.2022 um 17:54 schrieb Yann Ylav

Re: svn commit: r1899609 - in /httpd/httpd/trunk: changes-entries/core_ap_escape_quotes.txt server/util.c test/unit/util.c

2022-04-15 Thread Stefan Eissing
> Am 15.04.2022 um 15:24 schrieb Yann Ylavic : > > On Wed, Apr 6, 2022 at 11:17 AM wrote: >> >> Modified: httpd/httpd/trunk/server/util.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util.c?rev=1899609&r1=1899608&r2=1899609&view=diff >> ===

Re: svn commit: r1899609 - in /httpd/httpd/trunk: changes-entries/core_ap_escape_quotes.txt server/util.c test/unit/util.c

2022-04-16 Thread Stefan Eissing
> Am 15.04.2022 um 18:20 schrieb Yann Ylavic : > > On Fri, Apr 15, 2022 at 6:19 PM Yann Ylavic wrote: >> >> On Fri, Apr 15, 2022 at 4:21 PM Stefan Eissing wrote: >>> >>>> Am 15.04.2022 um 15:24 schrieb Yann Ylavic : >>>> >>>

Re: pytest: test_101_ssl_reneg.py with OpenSSL 3.0.2 triggers error in TestBuffering.test_h2_712_03

2022-04-24 Thread Stefan Eissing
Hi Rainer, there is a list of patterns and APLOGNOs that are allowed to happen. In the http2 tests, those are defined in env.py, lines 88-97. If we get new ones with openssl 3.0.2, we need to add them there. Could you give this a shot? Kind Regards, Stefan > Am 24.04.2022 um 22:03 schrieb Ra

Re: Trouble in rusttls land?

2022-05-10 Thread Stefan Eissing
Will look at it tomorrow. > Am 10.05.2022 um 15:17 schrieb Ruediger Pluem : > > The latest build 0f 2.4.x on Travis failed with mod_tls. Ideas? > > https://app.travis-ci.com/github/apache/httpd/jobs/569587665 > > Regards > > Rüdiger

  1   2   3   4   5   6   7   8   9   10   >