Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On 07/24/2015 02:09 PM, ic...@apache.org wrote: > Author: icing > Date: Fri Jul 24 12:09:44 2015 > New Revision: 1692486 > > URL: http://svn.apache.org/r1692486 > Log: > new Protocols directive and core API changes to enable protocol switching on > HTTP Upgrade or ALPN, implemented in mod_ssl

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On Wed, Sep 2, 2015 at 4:31 PM, Stefan Eissing wrote: > >> Am 02.09.2015 um 16:19 schrieb Yann Ylavic : >> >> On Wed, Sep 2, 2015 at 4:04 PM, Eric Covener wrote: >>> On Wed, Sep 2, 2015 at 10:01 AM, Stefan Eissing >>>

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

But would it have an "Upgrade: + Connection:" header? I might be wrong, but I thought mod_proxy_wstunnel adds those headers before sending the request to a backend. So the core_ugprade_handler would not see those. > Am 02.09.2015 um 16:04 schrieb Eric Covener : > > On Wed,

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

> Am 02.09.2015 um 15:16 schrieb Yann Ylavic : > > I wonder how these handlers interact with mod_proxy_wstunnel which > needs to handle the Upgrade by itself (after the HTTP header has been > forwarded to the backend). > > I'm not sure we can upgrade unconditionally really

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On Wed, Sep 2, 2015 at 10:01 AM, Stefan Eissing wrote: > Hmm. Is the > ap_hook_handler(core_upgrade_handler,NULL,NULL,APR_HOOK_REALLY_FIRST); > called for requests that mod_proxy_wstunnel makes against a backend? yes, the guts of mod_proxy is just a handler, so

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On Fri, Jul 24, 2015 at 2:09 PM, wrote: > Author: icing > Date: Fri Jul 24 12:09:44 2015 > New Revision: 1692486 > > URL: http://svn.apache.org/r1692486 > Log: > new Protocols directive and core API changes to enable protocol switching on > HTTP Upgrade or ALPN, implemented in

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On Wed, Sep 2, 2015 at 4:04 PM, Eric Covener wrote: > On Wed, Sep 2, 2015 at 10:01 AM, Stefan Eissing > wrote: >> Hmm. Is the >> ap_hook_handler(core_upgrade_handler,NULL,NULL,APR_HOOK_REALLY_FIRST); >> called for requests that

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

> Am 02.09.2015 um 16:12 schrieb Eric Covener : > > On Wed, Sep 2, 2015 at 10:09 AM, Stefan Eissing > wrote: >> But would it have an "Upgrade: + Connection:" header? I might be wrong, but >> I thought mod_proxy_wstunnel adds those headers before

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On Wed, Sep 2, 2015 at 10:09 AM, Stefan Eissing wrote: > But would it have an "Upgrade: + Connection:" header? I might be wrong, but I > thought mod_proxy_wstunnel adds those headers before sending the request to a > backend. So the core_ugprade_handler would not

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

> Am 02.09.2015 um 16:19 schrieb Yann Ylavic : > > On Wed, Sep 2, 2015 at 4:04 PM, Eric Covener wrote: >> On Wed, Sep 2, 2015 at 10:01 AM, Stefan Eissing >> wrote: >>> Hmm. Is the >>>

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

Done in r1696266. Am 24.07.2015 um 15:54 schrieb Ruediger Pluem rpl...@apache.org: + +/* make sure httpd closes the connection after this */ +c-keepalive = AP_CONN_CLOSE; +ap_lingering_close(c); + +

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On 07/24/2015 03:50 PM, Stefan Eissing wrote: Am 24.07.2015 um 15:40 schrieb Ruediger Pluem rpl...@apache.org: On 07/24/2015 02:09 PM, ic...@apache.org wrote: Author: icing Date: Fri Jul 24 12:09:44 2015 New Revision: 1692486 +static int core_upgrade_handler(request_rec *r) +{ +

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

Am 24.07.2015 um 15:54 schrieb Ruediger Pluem rpl...@apache.org: The c-keepalive = AP_CONN_CLOSE looks fine to me, but why should we do the other stuff in a handler. IMHO that should be done by the existing code. Not sure I understand. You mean the interim response or the whole handler?

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

On 07/24/2015 02:09 PM, ic...@apache.org wrote: Author: icing Date: Fri Jul 24 12:09:44 2015 New Revision: 1692486 URL: http://svn.apache.org/r1692486 Log: new Protocols directive and core API changes to enable protocol switching on HTTP Upgrade or ALPN, implemented in mod_ssl and

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

Am 24.07.2015 um 15:40 schrieb Ruediger Pluem rpl...@apache.org: On 07/24/2015 02:09 PM, ic...@apache.org wrote: Author: icing Date: Fri Jul 24 12:09:44 2015 New Revision: 1692486 + static const char *set_http_protocol(cmd_parms *cmd, void *dummy,