[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539510#comment-14539510 ] ASF GitHub Bot commented on JENA-938: - Github user rvesse commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user rvesse commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-101187792 I not declaring unthrown checked exceptions is a Java 8-ism? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539517#comment-14539517 ] ASF GitHub Bot commented on JENA-938: - Github user rvesse commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user rvesse commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-101188048 Looking at this I realise that Java 8 potentially presents a problem for Elephas because the entire Jena 3 stack is Java 8 and so Elephas has to be Java 8 yet most Hadoop

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-101331810 Hi, I'm not against your suggestion, it's probably easier to deal with one index. So, I made some positive tests that cover the points discussed previously (index a

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

Github user osma commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-101336857 Oh, right. Hmm. How about this: TextIndexLucene currently calls IndexWriter.addDocument() and IndexWriter.updateDocument(). But there are versions of these methods

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-101387550 Thanks a lot, I had not seen this method. Well, it seems to work and all tests pass. Should I propose the OneIndex branch in a new pull request ? --- If your

[GitHub] jena pull request: Kill dead things

Github user kinow commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101428998 @ajs6f we've requested SonarQube for Jena about three weeks ago https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-9469 Waiting for infra :smile: --- If

Re: Code policies

I think that something like checkstyle, PMD and FindBugs, and update the contribution page asking contributors to review their changes before sending PR's or patches would help.  It would be good to avoid replicating unnecessary policies in the web site though. Like suggesting that we expect

[jira] [Created] (JENA-939) Regression - incorrect rewriting of bnodes

Alan Ruttenberg created JENA-939: Summary: Regression - incorrect rewriting of bnodes Key: JENA-939 URL: https://issues.apache.org/jira/browse/JENA-939 Project: Apache Jena Issue Type: Bug

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user kinow commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-101210065 Umbrella ticket in Hadoop to support Java 8 https://issues.apache.org/jira/browse/HADOOP-11090 Guess it will still take a while. --- If your project is set up for

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539573#comment-14539573 ] ASF GitHub Bot commented on JENA-938: - Github user kinow commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101221776 This PR looks easier to process (it does not mix a lot of modules; sometimes that mix means several people are going to be interested, but in different parts). How

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

Github user osma commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-101232751 But how to change correctly the existent code to target Lucene taking that extra language into account ? You are currently already parsing the property function

[GitHub] jena pull request: Kill dead things

Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101236372 This is all good info, although I feel a bit unfortunate for having done these speculative PRs to get it. Can some kind of policy be published for these rules-of-thumb? Even

[GitHub] jena pull request: Kill dead things

Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101213856 JENA-938 (using this PR to cover #60, #61, #62, #63) Some of these are style points: Unthrown checked exceptions: many (not all but most in my sampling) of

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101235688 They are, I hope, okay to merge in arbitrary order. I made these PRs based on the idea that each covers enough ground to be substantive without being too large to

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539649#comment-14539649 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request:

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539591#comment-14539591 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-101215479 One possibility is to keep Java8-isms out of Elephas (on a practical basis) for the moment so backporting to 2.13.0 is a low barrier. Obviously, bug fixes that go into 3.0.0

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539619#comment-14539619 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539587#comment-14539587 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

Re: What can be removed/simplified ?

The current Capabilities doesn't express that so woudl I be right in guessing that the permission is testing for these on the action? If so, how could the graph capabilities help without assuming they are guaranteed true (they be wrong! and as a security attack?) On 08/05/15 21:50, Claude

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539752#comment-14539752 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[GitHub] jena pull request: Kill dead things

Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101256776 Good point. I wasn't able to catch on this PR before the JENA-938 ones emerged over the weekend so you have got ahead of me and everyone else. My apologies. Finding

Code policies

From comments on some clean up PRs I submitted over this past weekend, it seems that it would be nice to have some rough code standards that could help newcomers _without_ inhibiting anyone from contributing. Possible policies that came up included: • Don't give a method signature that

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-101214478 Actually, it looks like there is quite an impetus to get Hadoop on Java8 (even if Java6/7 bytecodes). EOL is making it a focus of attention. --- If your project is set up for

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539597#comment-14539597 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[jira] [Commented] (JENA-927) Add transition support to ja:loadClass loading.

[ https://issues.apache.org/jira/browse/JENA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539636#comment-14539636 ] ASF subversion and git services commented on JENA-927: -- Commit

Commons RDF

At: http://commonsrdf.incubator.apache.org/implementations.html It says Apache Jena is considering a compatibility interface that provides and consumes Commons RDF objects. I'm wondering if there have been any experiments to that end, or whether Jena is waiting for some resources to explore

[GitHub] jena pull request: Kill dead things

Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101273013 I don't think you owe me any apologies. It's just a case of a new guy showing up to an open source project who has to spend some time getting to know the rhythm before

[jira] [Commented] (JENA-927) Add transition support to ja:loadClass loading.

[ https://issues.apache.org/jira/browse/JENA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539637#comment-14539637 ] Andy Seaborne commented on JENA-927: Good idea - added code to print a WARN (with some

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

Github user afs commented on the pull request: https://github.com/apache/jena/pull/63#issuecomment-101322670 When I applied the changes, I get a lot of hiding warnings. Seems to me the root cause is the hiding in the first place, not the use of `@SuppressWarnings(hiding)` which,

[jira] [Commented] (JENA-938) Clean up dead code

[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540054#comment-14540054 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request: