Github user FSchumacher commented on the pull request:
https://github.com/apache/jmeter/pull/21#issuecomment-107363216
Thanks for looking at the comments, but the most important one is still
left.
I still haven't seen a jini project anywhere in real life, so please
di
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42307968
--- Diff: build.xml ---
@@ -391,6 +391,8 @@
+
+
--- End diff --
too many whitespaces :)
---
If
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42307977
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONManager.java ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42307982
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONManager.java ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42307988
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONManager.java ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42307995
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308008
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308068
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308124
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308147
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308220
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308226
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308247
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/JSONPostProcessor.java
---
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308272
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/gui/JSONPostProcessorGui.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308284
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/gui/JSONPostProcessorGui.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308320
--- Diff:
src/components/org/apache/jmeter/extractor/json/jsonpath/gui/JSONPostProcessorGui.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308330
--- Diff:
src/components/org/apache/jmeter/extractor/json/render/RenderAsJsonRenderer.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308367
--- Diff:
src/components/org/apache/jmeter/extractor/json/render/RenderAsJsonRenderer.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308417
--- Diff:
src/components/org/apache/jmeter/extractor/json/render/RenderAsJsonRenderer.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308430
--- Diff:
src/components/org/apache/jmeter/extractor/json/render/RenderAsJsonRenderer.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308450
--- Diff: xdocs/usermanual/component_reference.xml ---
@@ -2957,6 +2957,9 @@ may download images, style-sheets, etc. referenced by
the HTML code
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308465
--- Diff: xdocs/usermanual/component_reference.xml ---
@@ -6070,7 +6073,6 @@ The JDBC PostProcessor enables you to run some SQL
statement just after a
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/28#discussion_r42308498
--- Diff: xdocs/usermanual/component_reference.xml ---
@@ -6078,6 +6080,34 @@ This can be useful if your JDBC Sample changes some
data and you want to
Github user FSchumacher commented on the pull request:
https://github.com/apache/jmeter/pull/96#issuecomment-177472243
I think the patch does too much in one. The javadoc formatting is
debatable. My eclipse format would re-format it to the orig form. I will try to
look at your
Github user FSchumacher commented on the pull request:
https://github.com/apache/jmeter/pull/162#issuecomment-194429250
Thanks for your contribution.
I have two comments.
The formatting seems to be broken by this change.
I think jmeter should not skip the missing
Github user FSchumacher commented on the pull request:
https://github.com/apache/jmeter/pull/131#issuecomment-198908905
I applied all of your formatting, typo and boolean expression changes (I
think). The change of APPLIABLE to APPLICABLE seems correct, but that mistake
is in all
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/210
Thanks for your contribution.
As you can see, the checks for this PR are failing. You can find the reason
by following the link (small red cross next to the commit id) to the travis ci
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/174
For me, the patch does too many different things at once. I like to
separate them into
- formatting issues
- changing `indexOf(..)` into `contains(..)`
- converting to `for
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/174
Many thanks for the contribution and the splitting up of the patches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/212#discussion_r69008032
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java ---
@@ -53,8 +53,8 @@
import org.apache.jmeter.util.JMeterUtils
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/211#discussion_r69012681
--- Diff:
src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/AbstractJDBCTestElement.java
---
@@ -147,17 +147,24 @@ protected AbstractJDBCTestElement
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/211
The SNI test is quite flaky, but as you suspected, that is not your fault.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/214
Thanks for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/211
The jobs fail because of the flaky sni test. They are not your fault.
Thanks for the contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/212
Thanks for your contribution. I left the the changes to logging out, since
I believe there is still some discussion around that ongoing.
---
If your project is set up for it, you can reply to
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/215
Many thanks for the contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/218
Thanks for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/221
I like the idea of the smaller library (cache) instead of rushing into
guava for this use case only.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/222
This problem was fixed on trunk with r1754436 (f933590417bc for git).
Thanks for the report and the fix, though.
---
If your project is set up for it, you can reply to this email and
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/228
There is StringUtils#startsWithIgnoreCase, that does the same and is
clearly named.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/230
Add README.md
Add a markdown annotated Readme file, that will be displayed formatted,
when looked at on the github mirror.
We could drop the plain Readme, if we add this one.
You can
GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/234
Try to get travis-ci back to green.
The (default) servername is bound to the loopback device, which
gives us an exception.
You can merge this pull request into a Git repository by
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/232
Thanks for your contribution and sorry we took so long to give a bit of
feedback.
I would advise you to discuss the introduction of this feature on the dev
mailing list first
Github user FSchumacher closed the pull request at:
https://github.com/apache/jmeter/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/234
Changes are committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/235
Thanks for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/237#discussion_r91858269
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/SamplerMetric.java ---
@@ -88,8 +110,18 @@ private void addHits(SampleResult res
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/237#discussion_r91858252
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/WindowMode.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/237#discussion_r91858285
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/SamplerMetric.java ---
@@ -88,8 +110,18 @@ private void addHits(SampleResult res
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/237#discussion_r91858364
--- Diff: bin/jmeter.properties ---
@@ -917,6 +917,8 @@ summariser.name=summary
# BackendListener - configuration
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/237#discussion_r91858293
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/SamplerMetric.java ---
@@ -28,24 +34,39 @@
* @since 2.13
*/
public class
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/241
Thanks for your contribution. Could you resubmit your PR based on current
trunk? It is really hard to see your changes otherwise.
On the addition of a cache: we have added caffeine. You
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/241
Well, try a current one. It would be great if there is no conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/244#discussion_r94225584
--- Diff:
src/core/org/apache/jmeter/report/processor/Top5ErrorsSummaryData.java ---
@@ -29,7 +29,7 @@
*/
public class Top5ErrorsSummaryData
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/255
Thanks for your contribution.
Looks good, but as usual, I would have liked to see the different cleanups
in different commits.
---
If your project is set up for it, you can reply to
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/254#discussion_r99488229
--- Diff: src/core/org/apache/jmeter/NewDriver.java ---
@@ -276,4 +276,106 @@ private static String
exceptionsToString(List exceptionsInInit
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/254#discussion_r99488425
--- Diff: src/core/org/apache/jmeter/gui/logging/GuiLogEventBus.java ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/254#discussion_r99488452
--- Diff: src/core/org/apache/jmeter/gui/logging/GuiLogEventBus.java ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/254#discussion_r99488610
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java
---
@@ -159,14 +192,84 @@ public Exception getException
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/254#discussion_r99488717
--- Diff: src/core/org/apache/jmeter/NewDriver.java ---
@@ -276,4 +276,106 @@ private static String
exceptionsToString(List exceptionsInInit
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/288
Looks good to me. I think we should include it in 3.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/293
Great. Thanks for your analysis and your fix.
I tend to change the behaviour of normalizeList, even if it is a change in
the unwritten contract. The current behaviour seems wrong to me
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/293
As Emilan suggested, we could change normalizeList to always create a new
collection, instead of introducing a new method, that has configurable
behaviour.
I consider the current
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113537122
--- Diff: xdocs/usermanual/functions.xml ---
@@ -1499,6 +1502,36 @@ becomes:
+
+
+
+The timeShifting function
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113539596
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113536574
--- Diff: xdocs/usermanual/functions.xml ---
@@ -1499,6 +1502,36 @@ becomes:
+
+
+
+The timeShifting function
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113537173
--- Diff: xdocs/usermanual/functions.xml ---
@@ -1499,6 +1502,36 @@ becomes:
+
+
+
+The timeShifting function
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113534765
--- Diff: xdocs/usermanual/functions.xml ---
@@ -1499,6 +1502,36 @@ becomes:
+
+
+
+The timeShifting function
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113541037
--- Diff: xdocs/usermanual/functions.xml ---
@@ -1499,6 +1502,36 @@ becomes:
+
+
+
+The timeShifting function
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113540403
--- Diff: src/core/org/apache/jmeter/resources/messages.properties ---
@@ -1179,6 +1180,7 @@ throughput_control_perthread_label=Per User
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113538522
--- Diff: xdocs/usermanual/functions.xml ---
@@ -1499,6 +1502,36 @@ becomes:
+
+
+
+The timeShifting function
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113539786
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113540245
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113540671
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113539922
--- Diff:
src/functions/org/apache/jmeter/functions/TimeShiftingFunction.java ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113539229
--- Diff:
test/src/org/apache/jmeter/functions/TestTimeShiftingFunction.java ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/293
Great, I wonder if we should change the return value from `null` to
`Collections.emptyList()` in case of an Exception, too.
I will add a test case to the bugzilla entry for
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/291
You might want to look at `Duration#parse(CharSequence)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/294
Looks useful to me.
Something I always try, when something is expandable/collapsable is to use
the left/right cursor to expand/collapse. Maybe this would be useful and simple
to
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/296#discussion_r115304397
--- Diff: src/jorphan/org/apache/jorphan/math/StatCalculator.java ---
@@ -162,7 +162,7 @@ public T getPercentPoint(double percent
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/297
What did you want to get changed? We generally only update the current
documentation.
I didn't find any change in this pull request.
---
If your project is set up for it, you can
GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/298
Vary header cache
First try on an implementation to support vary header as asked for in
https://bz.apache.org/bugzilla/show_bug.cgi?id=61176
Do not merge.
I haven't wr
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r123043201
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -127,19 +163,28 @@ public Date getExpires
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r123043982
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -152,22 +197,18 @@ private boolean hasVaryHeader
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/298
@undera there are still a few tests missing, mainly the ones for vary
headers for multiple and different headers. But you are welcome to give this
some testing on real sites.
@pmouawad
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/298
I think this feature can be tested now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r125741694
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPJavaImpl.java ---
@@ -626,6 +627,19 @@ protected HTTPSampleResult sample(URL url
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/299
Thanks for your work. I have just had a glance and will look into it as
soon as I have a bit more time.
But I like the general direction, especially that we can (hopefully)
migrate from ant
GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/301
First stab at a whitelist for the xstream library.
`ant test` will run with the current whitelist, but I fear that most
plugins would fail.
It would probably be cumbersome for users to
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130236483
--- Diff: src/core/org/apache/jmeter/gui/action/CheckDirty.java ---
@@ -64,11 +64,12 @@
public CheckDirty() {
previousGuiItems
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130235880
--- Diff: src/core/org/apache/jmeter/gui/SimpleCompoundEdit.java ---
@@ -0,0 +1,14 @@
+package org.apache.jmeter.gui;
+
+import
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130235898
--- Diff: src/core/org/apache/jmeter/gui/SimpleCompoundEdit.java ---
@@ -0,0 +1,14 @@
+package org.apache.jmeter.gui;
+
+import
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130236267
--- Diff: src/core/org/apache/jmeter/gui/UndoHistoryItem.java ---
@@ -35,31 +36,48 @@
private final HashTree tree;
// TODO: find a way
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130236542
--- Diff: src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java ---
@@ -258,6 +259,7 @@ private void doSearch(ActionEvent e
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130236022
--- Diff: src/core/org/apache/jmeter/gui/TreeState.java ---
@@ -0,0 +1,84 @@
+package org.apache.jmeter.gui;
+
+import java.util.ArrayList
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130236378
--- Diff: src/core/org/apache/jmeter/gui/action/ActionRouter.java ---
@@ -67,6 +72,9 @@ public void actionPerformed(final ActionEvent e
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130235928
--- Diff: src/core/org/apache/jmeter/gui/TreeState.java ---
@@ -0,0 +1,84 @@
+package org.apache.jmeter.gui;
+
+import java.util.ArrayList
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r130236104
--- Diff: src/core/org/apache/jmeter/gui/UndoHistory.java ---
@@ -118,8 +87,12 @@ public void clear() {
return
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/300
I think I can reproduce Philippes problem. And it will probably look really
strange to a user. My steps where:
* start a new test plan `Ctrl+L`
* add a thread group `Ctrl+0`
* add a
Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/300#discussion_r131244988
--- Diff: src/core/org/apache/jmeter/gui/SimpleCompoundEdit.java ---
@@ -0,0 +1,14 @@
+package org.apache.jmeter.gui;
+
+import
1 - 100 of 190 matches
Mail list logo
