Re: [ANNOUNCE] New Committer: Manikumar Reddy

2018-10-11 Thread Matthias J. Sax
Congrats! On 10/11/18 2:31 PM, Yishun Guan wrote: > Congrats Manikumar! > On Thu, Oct 11, 2018 at 1:20 PM Sönke Liebau > wrote: >> >> Great news, congratulations Manikumar!! >> >> On Thu, Oct 11, 2018 at 9:08 PM Vahid Hashemian >> wrote: >> >>> Congrats Manikumar! >>> >>> On Thu, Oct 11, 2018 a

Re: [VOTE] KIP-376: Implement AutoClosable on appropriate classes that want to be used in a try-with-resource statement

2018-10-18 Thread Matthias J. Sax
+1 (binding) Thanks for the KIP. And thanks for bumping the thread regularly. As 2.1.0 and 2.0.1 releases are running atm, it takes some time to get attention. -Matthias On 10/18/18 11:47 AM, Yishun Guan wrote: > Bumping this thread up again, thanks! > On Tue, Oct 16, 2018 at 11:24 AM Yishun Gua

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

2018-10-19 Thread Matthias J. Sax
I just realized that there is not Jira for this KIP. Can you please create one? All KIPs need to have a Jira for tracking. Thanks. On 10/10/18 6:51 AM, Damian Guy wrote: > Hi Wladimir, > > Of the two approaches in the KIP - i feel the second approach is cleaner. > However, am i correct in assumi

Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-10-19 Thread Matthias J. Sax
M M. Manna wrote: >>> >>>> Since this has been open for a while, I am assuming that it's good to >>> go? >>>> >>>> if so, I will update the KIP page - and start coding this. I would >>> prefer >>>> re-using existing te

Re: Request for contributor permissions

2018-10-19 Thread Matthias J. Sax
Done. On 10/18/18 6:51 PM, Stone Huang wrote: > JIRA ID: godisren > Cwiki ID: Ren Jr Huang > > Thanks in advance! > signature.asc Description: OpenPGP digital signature

Re: Throwing away prefetched records optimisation.

2018-10-19 Thread Matthias J. Sax
Just my 2 cents. I am not 100% sure if we would need to change the consumer for this. While I still think, that KIP-349 might be valuable, it seems to be complementary/orthogonal to the issue discussed here. For Kafka Streams, we have a related scenario and what Kafka Streams does is, to add its

Re: [DISCUSS]KIP-216: IQ should throw different exceptions for different errors

2018-10-19 Thread Matthias J. Sax
king over your KIP again, it seems valuable to introduce >>> "retriable store exception" and "fatal store exception" marker interfaces >>> that the various exceptions can mix in. It would be nice from a usability >>> perspective to be able to just l

Re: [VOTE] KIP-334 Include partitions in exceptions raised during consumer record deserialization/validation

2018-10-19 Thread Matthias J. Sax
I am not 100% familiar with the details of the consumer code, however I tend to disagree with: > There's no difference between the two cases -- if (and only if) the message > is corrupt, it can't be deserialized. If (and only if) it can't be > deserialized, it is corrupt. Assume that a user co

Re: [DISCUSS] KIP-262 Metadata should include the number of state stores for task

2018-10-19 Thread Matthias J. Sax
Any thought on my last email about discarding this KIP? -Matthias On 9/14/18 11:44 AM, Matthias J. Sax wrote: > Hi, > > we recently had a discussion on a different ticket to reduce the size of > the metadata we need to send: > https://issues.apache.org/jira/browse/KAFKA-714

Re: [DISCUSSION] KIP-300: Add Windowed KTable API in StreamsBuilder

2018-10-19 Thread Matthias J. Sax
intermediate topic, and read from this topic to > form a KTable, V>, you will materialize this store again, and > the two materialized state stores will contain completely the same data. > Have you thought about whether you really need to materialize it twice? > > > Guozhang

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2018-10-19 Thread Matthias J. Sax
>>>> static Predicate named(final String name, final >>>> Predicate predicate) { >>>> return new Predicate() { >>>> @Override >>>> public boolean test(final K key, final V value) { >>>>

Re: Throwing away prefetched records optimisation.

2018-10-21 Thread Matthias J. Sax
t; longer fetchable...". Maybe I am not fully understanding your suggested > approach, but I dont think it would solve this problem. > > Zahari > > On Fri, Oct 19, 2018 at 8:10 PM Matthias J. Sax > wrote: > >> Just my 2 cents. >> >> I am not

Re: Throwing away prefetched records optimisation.

2018-10-21 Thread Matthias J. Sax
m convinced we would like to do. > > Zahari > > On Sun, Oct 21, 2018 at 10:11 PM Matthias J. Sax > wrote: > >>> You have one consumer that is quite >>>> slow so lets say it call poll every 5 seconds, while you need to call >> poll >>>>

Re: Throwing away prefetched records optimisation.

2018-10-23 Thread Matthias J. Sax
Thanks for the detailed explanation. -Matthias On 10/23/18 12:38 PM, Zahari Dichev wrote: > Hi there Matthias, I looked through the code of Kafka Streams. Quite > impressive work ! If I have to put the logic of buffering within the > context of what we are doing in Akka though, I might end up wit

Re: Requesting wiki permissions

2018-10-24 Thread Matthias J. Sax
Done. On 10/24/18 11:49 AM, Zahari Dichev wrote: > Hi there Can I get permissions for > WIKI id: zaharidichev > > Zahari > signature.asc Description: OpenPGP digital signature

Re: KAFKA-3932 - Consumer fails to consume in a round robin fashion

2018-10-24 Thread Matthias J. Sax
CH, Thanks for contributing to Kafka. Do you have a Jira account already? If yes, what is your account id? If not, you need to create one first and share your id so we can grant permission to self-assign tickets. I was just looking into the ticket itself, and it's marked as 0.10.0.0. You say you

Re: Request for contributor permission

2018-10-25 Thread Matthias J. Sax
Done. On 10/25/18 7:27 AM, Andrew Schofield wrote: > Please could I have contributor permission to Apache Kafka. Here are my > details: > > JIRA ID: schofielaj > Wiki ID: schofielaj > > Thanks, > Andrew Schofield > IBM Event Streams > signature.asc Description: OpenPGP digital signature

Re: [EXTERNAL] - Re: KAFKA-3932 - Consumer fails to consume in a round robin fashion

2018-10-30 Thread Matthias J. Sax
sume in a > round robin fashion > > Hi Matthias, > > Sorry about the late reply. > > I have a Jira account. It's chienhsw. I am using the latest version 2.0. > Would it be possible to add that to 2.0 as a minor release? > > Thanks, ChienHsing > >

Re: KSQL with changelog topic

2018-11-01 Thread Matthias J. Sax
I am not sure if I understand the question. Can you elaborate? -Matthias On 11/1/18 10:38 AM, Boyang Chen wrote: > Hey there, > > > a dumb question that I haven't found the answer anywhere: does KSQL support > query towards Stream applications' > > changelog topic? Especially window store ch

Re: request for wiki permission to create KIP

2018-11-01 Thread Matthias J. Sax
Done. On 10/31/18 9:49 AM, ChienHsing Wu wrote: > Hi, my ID is chienhsw. > > Please enable me to add KIP pages using this URL: > https://cwiki.apache.org/confluence?templateId=54329345&spaceKey=KAFKA&newSpaceKey=KAFKA&title=KIP-NEXT%3A+Insert+Title+Here. > I would like to add a KIP to discuss K

Re: KSQL with changelog topic

2018-11-02 Thread Matthias J. Sax
query like > > ``` > > select * from > > changelog_topic > > limit 10 > > ``` > > I'm not sure because the serde for window store changelog is compound > Windowed. > > > Hope this makes sense. Thank you! > > >

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-06 Thread Matthias J. Sax
gt;>> change > > >>>>>> group state, and return its cached member.id and current > > >> assignment. > > >>>>>> (unless this is leader, we shall trigger rebalance) > > >>>>>> 3. Although Guozhang has mentioned we could re

Re: [DISCUSS]KIP-216: IQ should throw different exceptions for different errors

2018-11-06 Thread Matthias J. Sax
Hey Vito, I saw that you updated your PR, but did not reply to my last comments. Any thoughts? -Matthias On 10/19/18 10:34 AM, Matthias J. Sax wrote: > Glad to have you back Vito :) > > Some follow up thoughts: > > - the current `InvalidStateStoreException` is documents as be

Re: [DISCUSS] KIP-362: Dynamic Session Window Support

2018-11-06 Thread Matthias J. Sax
Any update on this KIP? On 9/20/18 3:30 PM, Matthias J. Sax wrote: > Thanks for following up. Very nice examples! > > I think, that the window definition for Flink is semantically > questionable. If there is only a single record, why is the window > defined as [ts, ts+ga

Re: Permissions

2018-11-09 Thread Matthias J. Sax
Thanks for contribution! Check out https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes For writing a KIP, follow the instruction: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals Please share you Jira an Wiki account IDs (it's two separate ac

Re: Permissions

2018-11-09 Thread Matthias J. Sax
Done. On 11/9/18 7:06 PM, kamal kaur wrote: > Thanks Matthias! > > Both are kamalkang > > Kamal Kang > > On Fri, Nov 9, 2018 at 3:07 PM Matthias J. Sax > wrote: > >> Thanks for contribution! >> >> Check out >> https://cwiki.apache.org

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-11-11 Thread Matthias J. Sax
.g. called >> KeyValueWithTwoTimestampsStore)? >> >> Thanks >> Eno >> >> On Thu, Aug 9, 2018 at 2:30 PM, Matthias J. Sax >> wrote: >> >>> Thanks for your input Guozhang and John. >>> >>> I see your point, that the upgrade AP

Re: Request for permissions to add KIP for user shnguyen

2018-11-19 Thread Matthias J. Sax
Done. On 11/19/18 8:46 PM, Shawn Nguyen wrote: > Hey folks, > Any chance I could get permissions to add a KIP > ? > > > Thanks a bunch, > Shawn > > On Fri, Nov 16, 2018 a

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-11-20 Thread Matthias J. Sax
don't think I have the full picture > though, because that issue seems to be easy to fix with a simple versioned > header or accompanying file, forcing the app to rebuild the state if the > version is incompatible. Can you elaborate or add a scenario to the KIP > that illustrates the nee

Re: Need to subscribe to mail list and get access to contribute to jira tickets

2018-11-20 Thread Matthias J. Sax
Mailing list subscription is self-service: https://kafka.apache.org/contact On 11/20/18 8:39 AM, Manikumar wrote: > Hi, > > I have given JIRA permissions for "kaushik srinivas" JIRA username. > > On Tue, Nov 20, 2018 at 3:29 PM KAUSHIK SRINIVAS < > kaushiksrinivas...@gmail.com> wrote: > >> Hi,

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-11-20 Thread Matthias J. Sax
> have read the link to (https://issues.apache.org/jira/browse/KAFKA-3522) >> in >> the KIP, and I can understand that a state-store on disk may not represent >> what the application is expecting. I don't think I have the full picture >> though, because that issue seem

Re: [DISCUSS] KIP-394: Require member.id for initial join group request

2018-11-27 Thread Matthias J. Sax
Thanks for the KIP Boyang. I guess I am missing something, but I am still learning more details about the rebalance protocol, so maybe you can help me out? Assume a client sends UNKNOWN_MEMBER_ID in its first joinGroup request. The broker generates a `member.id` and sends it back via `MEMBER_ID_R

Re: [DISCUSS] KIP-394: Require member.id for initial join group request

2018-11-29 Thread Matthias J. Sax
ld too many stale ones. > This isn't mentioned in the KIP though so it is worth to wait for Boyang to > confirm > > On Wed, Nov 28, 2018 at 3:10 AM Matthias J. Sax > wrote: > >> Thanks for the KIP Boyang. >> >> I guess I am missing something, but I

Re: [DISCUSS] KIP-394: Require member.id for initial join group request

2018-11-30 Thread Matthias J. Sax
gt;> set called `registeredMemberIds` which >> will be cleared out every time a group finishes one round of rebalance. >> Since storing one id is pretty trivial, using >> purgatory to track the id removal is a bit wasteful in my opinion. >>

Re: KAFKA-6144(or other ticket to resolve)

2018-12-04 Thread Matthias J. Sax
Thanks Nikolay, of course we would like to get this ticket resolved! Just a heads up: it's a complex beast and we need to lay out a sound design. Thus, I expect a long KIP discussion. If this does (hopefully) not scare you, feel free to pick it up. Also note, related https://issues.apache.org/jir

Re: [VOTE] KIP-394: Require member.id for initial join group request

2018-12-05 Thread Matthias J. Sax
Thanks for the KIP. +1 (binding) -Matthias On 12/5/18 7:53 AM, Mayuresh Gharat wrote: > +1 (non-binding) > > Thanks, > > Mayuresh > > > On Wed, Dec 5, 2018 at 3:59 AM Boyang Chen wrote: > >> Hey friends, >> >> I would like to start a vote for KIP-394< >> https://cwiki.apache.org/confluenc

Re: Kafka Help

2018-12-05 Thread Matthias J. Sax
You will need to write a custom deserializer that is able to convert he `byte[]` of key and value into the desired Scala/Java object. Interface: org.apache.kafka.common.serialization.Deserializer You can provide your custom deserializer via config to console consumer and KafkaConsumer in your Sca

Re: [DISCUSS] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2018-12-06 Thread Matthias J. Sax
Well, that's exactly the point. The serializer should not be altered IMHO because this would have impact on other components. Also, for applications that use KafkaProducer directly, they can catch any serialization exception and react to it. Hence, I don't don't see a reason to change the serialize

Re: [DISCUSS] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2018-12-06 Thread Matthias J. Sax
/internals/SinkNode.java#L93> > on > hitting `ClassCastException`, we are halting the streams as it's a fatal > error. > To keep the original behavior, I've to distinguish the exceptions. > > > On Thu, Dec 6, 2018 at 10:44 PM Matthias J. Sax > wrote: > >

Re: KIP creation permission

2018-12-07 Thread Matthias J. Sax
Done. Looking forward to you KIP :) On 12/7/18 11:23 AM, Paul Whalen wrote: > Based on some other messages the mailing list seems like this is the best > place to ask for permissions. Can it be granted on the wiki for pgwhalen? > Gonna try to write something up for this: > https://issues.apache.or

Re: contributor list

2018-12-08 Thread Matthias J. Sax
What is your JIRA ID? -Matthias On 12/8/18 7:21 AM, david greenfield wrote: > Hi, > > I'd like to be added to the contributor list. I am interested in getting > started contributing. I thought I'd start with some of the "starter" jira > tickets. > > > Thanks! > signature.asc Descripti

Re: [DISCUSS] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2018-12-13 Thread Matthias J. Sax
internal-repartition topics ? So, that I can look into it. > > On Fri, Dec 7, 2018 at 12:07 AM Matthias J. Sax > wrote: > >>>> To accept different types of records from multiple topologies, I have to >>>> define the ProducerRecord without generics. >>

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2018-12-13 Thread Matthias J. Sax
gt; } >>> } >>> >>> Note that the generic parameter gets filled in properly in the >> implementing >>> class, so that you get the right return type out. >>> >>> It doesn't work at all with a static factory method at the interf

Re: [DISCUSS] KIP-401 TransformerSupplier/ProcessorSupplier enhancements

2018-12-13 Thread Matthias J. Sax
Just a meta comment: do we really need to deprecate existing `transform()` etc methods? The last argument is a vararg, and thus, just keeping the existing API for this part seems to work too, allowing to implement both patterns? Also, instead of adding a default method, we could also add a new in

Re: Request permission to create KIP

2018-12-14 Thread Matthias J. Sax
Done. On 12/14/18 7:05 AM, hu wenze wrote: > Hi! Thanks for reading the email; > I want to create a new KIP, but I don't have permisiion; > > My wiki Id: laomei > > Thanks! > signature.asc Description: OpenPGP digital signature

Re: what happens when a vote ends with no votes?

2018-12-15 Thread Matthias J. Sax
John, feel free to update the wiki accordingly. On 12/14/18 10:48 PM, John Roesler wrote: > I guess it would be different if you had one vote instead of none. The norm > seems to be to just continue nagging people in the [VOTE] thread until you > accrue the needed votes. > > If I understand the p

Re: [DISCUSS] KIP-401 TransformerSupplier/ProcessorSupplier enhancements

2018-12-16 Thread Matthias J. Sax
default List stateStoreNames() { > return Collections.singletonList(storeName); > <https://cwiki.apache.org/confluence/pages/Collections.emptyList();> > } > } > > Basically, we move the parameters from the caller of `transform` to inside > the Transfor

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-12-17 Thread Matthias J. Sax
myself, so if I can help on this one in any > way please let me know. > > Thanks > Adam > > > > On Tue, Nov 20, 2018 at 5:26 PM Matthias J. Sax > wrote: > >> It's an interesting idea to use second store, to maintain the >> timestamps

Re: Vote for KIP-393 (Fix time windowed serde to deserialize changelog topic)

2018-12-19 Thread Matthias J. Sax
Sorry for the delay. Needed to read the KIP and code multiple times to wrap my head around it. Thanks for the KIP. +1 (binding) -Matthias On 12/13/18 1:19 PM, Damian Guy wrote: > +1 (binding) > > On Wed, 12 Dec 2018 at 13:27, Adam Bellemare > wrote: > >> +1 (non-binding) from me. Looks li

Re: SessionWindows type base class

2018-12-23 Thread Matthias J. Sax
`Windows` is not a generic window type for all windows. It's only used for windows that can be "pre computed", ie, the window boundaries are know a-priory (like TimeWindow or UnlimitedWindow). We need to distinguish between TimeWindow/UnlimitedWindow and SessionWindows in the API. There are two ov

Re: Permission to Create Content

2019-01-02 Thread Matthias J. Sax
What is your wiki ID? On 12/30/18 11:36 PM, Jamie wrote: > Hi All,  > Could you please grant me permission to create content so that I can create a > KIP?  > Many Thanks,  > Jamie > signature.asc Description: OpenPGP digital signature

Re: Suggestion to make 0 grace period the default for suppress

2019-01-03 Thread Matthias J. Sax
Kafka Streams does not change topic configs if a topic exists already. Thus, there should be no impact in existing application if they are upgraded. However, I share the backward compatibility concern in general. Furthermore, for windowing, retention period must be at least window size IIRC, thus,

Re: [DISCUSS] KIP-262 Metadata should include the number of state stores for task

2019-01-05 Thread Matthias J. Sax
s On 1/3/19 10:41 PM, Richard Yu wrote: > Hi Matthias, > > I guess this is no longer necessary. I am open to anything honestly. > I suppose we should close it (if its not already). > > > On Fri, Oct 19, 2018 at 11:06 AM Matthias J. Sax > wrote: > >> Any th

[DISCUSS] Kafka 2.2.0 in February 2018

2019-01-08 Thread Matthias J. Sax
Hi all, I would like to propose a release plan (with me being release manager) for the next time-based feature release 2.2.0 in February. The recent Kafka release history can be found at https://cwiki.apache.org/confluence/display/KAFKA/Future+release+plan. The release plan (with open issues and

Re: [VOTE] KIP-349 Priorities for Source Topics

2019-01-12 Thread Matthias J. Sax
Thanks for the summary Colin. One remark from my side: I have my doubts that topic priorities make sense for Kafka Streams (at least not for the DSL). Thus, I would suggest to limit this KIP to the consumer only, otherwise, the scope will be too large and this KIP will drag on even longer. If we

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-12 Thread Matthias J. Sax
gt;>>>> simply to keep the Named interface as: >>>>>>> >>>>>>> public interface Named> { >>>>>>> String name(); >>>>>>> T withName(String name); >>>>>>> } >>>>>&

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-12 Thread Matthias J. Sax
Thanks for the KIP. One side comment about rejected alternatives. I would remove the sentence, because `StreamsMetadata` is part of IQ feature and not related at all to this change -- thus, it does not seem to be a valid alternative. +1 (binding) -Matthias On 1/11/19 5:47 AM, Bill Bejeck wrot

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-12 Thread Matthias J. Sax
i, Jan 11, 2019 at 1:19 PM John Roesler wrote: > >> Hi Matthias, >> >> Thanks for the updates to the KIP. I've just read it over, and am >> personally quite happy with it. >> >> Thanks for tackling this dicey issue and putting in a huge amount of desig

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-12 Thread Matthias J. Sax
ou think? -Matthias On 1/12/19 6:43 PM, Matthias J. Sax wrote: > Bill, > > I left the question about legacy column family out, because as a matter > of fact, we use the default column family atm that cannot be deleted. > Thus, this old column family will always be there. > > N

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-12 Thread Matthias J. Sax
Do you want to get this into 2.2 release? KIP deadline is 1/24, so quite soon. Overall, the KIP is very useful. I can review again in more details if you aim for 2.2 -- did you address all previous comment about the KIP already? -Matthias On 1/8/19 2:50 PM, Boyang Chen wrote: > Hey folks, >

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-15 Thread Matthias J. Sax
I'll try to review the KIP before the deadline, but as I am acting as release manager and also working on KIP-258, I cannot promise. Even if we make the voting deadline, it might also be tight to review the PR, as it seems to be big and complicated. I'll try my very best to get it into 2.2... -M

Re: [ANNOUNCE] New Committer: Vahid Hashemian

2019-01-15 Thread Matthias J. Sax
Congrats! On 1/15/19 3:34 PM, Boyang Chen wrote: > This is exciting moment! Congrats Vahid! > > Boyang > > > From: Rajini Sivaram > Sent: Wednesday, January 16, 2019 6:50 AM > To: Users > Cc: dev > Subject: Re: [ANNOUNCE] New Committer: Vahid Hashemian > > Cong

[VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-15 Thread Matthias J. Sax
Hi, I would like to start the vote for KIP-258: https://cwiki.apache.org/confluence/display/KAFKA/KIP-258%3A+Allow+to+Store+Record+Timestamps+in+RocksDB The KIP adds new stores that allow to store record timestamps next to key and value. Additionally, we will allow to upgrade exiting stores to t

Re: imamba_kafka request permission to Create KIP

2019-01-15 Thread Matthias J. Sax
Done. On 1/15/19 7:13 PM, Imamba Sun wrote: > Wiki ID: imamba_kafka > Full Name: Fangbin Sun > thanks! > > > > > > signature.asc Description: OpenPGP digital signature

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-15 Thread Matthias J. Sax
X > - > Changelog Topic| X | X| X > | X > - > > Le di

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-16 Thread Matthias J. Sax
e bounced > / re-launched frequently so just having this check logic upon starting up > should be a good trade-off between complexity and efficiency. > > > Guozhang > > > > > Guozhang > > > On Sat, Jan 12, 2019 at 6:46 PM Matthias J. Sax > wrote: > >>

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-16 Thread Matthias J. Sax
ting tests a lot easier for everyone. > > All around, I would advocate for moving toward this design for all the > config interfaces, as I've previously demonstrated how we've made an > intractable mess out of the window config hierarchy by trying to be clever > a

Re: [DISCUSS] KIP-165: Extend Interactive Queries for return latest update timestamp per key

2019-01-16 Thread Matthias J. Sax
Hi, This issue seems to be resolved as part of KIP-258. Thus, I close this discussion and mark this KIP as discarded. Let me know if there is any objection. Thanks. -Matthias On 12/4/17 4:06 PM, Matthias J. Sax wrote: > Jeyhun, > > is there any update regarding this KIP? > &g

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-16 Thread Matthias J. Sax
Boyang > ________ > From: Matthias J. Sax > Sent: Sunday, January 13, 2019 10:53 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder > > Do you want to get this into 2.2 release? KIP deadline is 1/24, so q

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

2019-01-17 Thread Matthias J. Sax
the processing node. For me, it comes down to the >>> fact >>>> that Materialized is used to configure the state store for an >> individual >>>> processing node and knows nothing of the operation itself. So I'll go >>> with >>>>

Re: [DISCUSS] KIP-300: Add Windowed KTable API in StreamsBuilder

2019-01-18 Thread Matthias J. Sax
ypo, and I already fixed it. > > I will let you know when the KIP updates are done. > > Best, > Boyang > > From: Matthias J. Sax > Sent: Thursday, January 17, 2019 7:52 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-300

Re: [DISCUSS] Kafka 2.2.0 in February 2018

2019-01-18 Thread Matthias J. Sax
to help streamlining the release process. Thanks a lot for you support! -Matthias On 1/8/19 7:27 PM, Ismael Juma wrote: > Thanks for volunteering Matthias! The plan sounds good to me. > > Ismael > > On Tue, Jan 8, 2019, 1:07 PM Matthias J. Sax >> Hi all, >> &

Re: [DISCUSS] Kafka 2.2.0 in February 2018

2019-01-18 Thread Matthias J. Sax
Thank you! Added to the wiki page for tracking. -Matthias On 1/18/19 11:59 AM, Tom Bentley wrote: > Hi Matthias, > > Hopefully we can get the work for KIP 183 merged too. > > Thanks, > > Tom > > On Fri, 18 Jan 2019, 19:33 Matthias J. Sax >> Just a quick u

Re: [VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB

2019-01-18 Thread Matthias J. Sax
t; >>> On Wed, 16 Jan 2019 at 05:09, Patrik Kleindl wrote: >>> >>>> +1 (non-binding) >>>> Thanks too >>>> Best regards >>>> Patrik >>>> >>>>> Am 16.01.2019 um 03:30 schrieb Bill Bejeck : >>>>>

Re: [VOTE] KIP-420: Add Single Value Fetch in Session Stores

2019-01-19 Thread Matthias J. Sax
Thanks for the KIP Guozhang! Would it make sense to add a default implementation for the new method? I am not sure, and I actually think it would not make sense: - Kafka Streams provided stores will implement the method anyway - Kafka Streams relies on a proper implementation for custom stores

Re: [DISCUSS] Kafka 2.2.0 in February 2018

2019-01-19 Thread Matthias J. Sax
Alex D wrote: > >> KIP-379? >> >> On Fri, 18 Jan 2019, 22:33 Matthias J. Sax > >>> Just a quick update on the release. >>> >>> >>> We have 22 KIP atm: >>> >>> 81, 207, 258, 289, 313, 328, 331, 339, 341, 351, 359, 36

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-05-06 Thread Matthias J. Sax
Hi, I just updated myself on this KIP. One question (maybe it was discussed and I missed it). What is the motivation to not use the offset as tie breaker for the "timestamp" case? Isn't this inconsistent behavior? -Matthias On 5/2/18 2:07 PM, Guozhang Wang wrote: > Hello Luís, > > Sorry for t

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-06 Thread Matthias J. Sax
Andy, thanks for the KIP. I don't have any further comments. My 2cents about Guozhang's questions: as I like consistent behavior, I think transfromValues() should behave the same way as filter() and mapValues(). -Matthias On 5/2/18 2:24 PM, Guozhang Wang wrote: > Hello Andy, > > Thanks for th

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-06 Thread Matthias J. Sax
that the headers would be available in the >>>>> ProcessorContext, (like "context.headers()"). It also says that >>>>> implementers would need to implement the method "void process(K key, >> V >>>>> value, Headers headers);". I

Re: Requesting wiki access for creating a KIP

2018-05-06 Thread Matthias J. Sax
What's your user id? Could not find a user `j...@jeffwidman.com` -Matthias On 5/6/18 11:12 AM, Jeff Widman wrote: > I thought I already had wiki access, but apparently I don't... > > Can someone give j...@jeffwidman.com proper permissions for creating a new > KIP? > > Thanks! > signature.as

Re: [DISCUSS] KIP-280: Enhanced log compaction

2018-05-06 Thread Matthias J. Sax
; > Guozhang > > On Sun, May 6, 2018 at 9:37 AM, Matthias J. Sax > wrote: > >> Hi, >> >> I just updated myself on this KIP. One question (maybe it was discussed >> and I missed it). What is the motivation to not use the offset as tie >> breaker for th

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-06 Thread Matthias J. Sax
rators and 2) sending to any topics. > > > Guozhang > > On Sun, May 6, 2018 at 10:24 AM, Matthias J. Sax > wrote: > >> Making the inheritance protocol a public contract seems reasonable to me. >> >> In the current implementation, all output records inherits the off

Re: Requesting wiki access for creating a KIP

2018-05-06 Thread Matthias J. Sax
NP. :) Done. You should be able to create and edit pages now. -Matthias On 5/6/18 9:18 PM, Jeff Widman wrote: > My apologies, my username is "jeffwidman". > > > > I forgot confluence isn't a search by user email system. > > On Sun, May 6, 2018

Re: Permission to edit KIP page

2018-05-07 Thread Matthias J. Sax
Done :) On 5/7/18 2:30 PM, Arjun Satish wrote: > Could someone please grant me the permissions to submit a KIP? My username > on apache.org is wicknicks. > > Thanks very much, > Arjun > signature.asc Description: OpenPGP digital signature

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-07 Thread Matthias J. Sax
nywhere in the store. > > > Guozhang > > > On Sun, May 6, 2018 at 9:03 PM, Matthias J. Sax > wrote: > >> I agree, that we should not block this KIP if possible. Nevertheless, we >> should try to get a reasonable default strategy for inheriting the >>

Re: please subscribe me to dev list

2018-05-08 Thread Matthias J. Sax
It's self-service: https://kafka.apache.org/contact -Matthias On 5/7/18 5:13 PM, Ravi Chinoy wrote: signature.asc Description: OpenPGP digital signature

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-08 Thread Matthias J. Sax
One thought I want to bring up about switching optimization on/off: While for the initial release, a boolean flag seems to be sufficient, I could imagine that we apply different and potentially upgrade-incompatible optimizations in future releases. Thus, to me it would make sense to use a String t

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-08 Thread Matthias J. Sax
allowed values, > like what we did for EOS. But I think in 2.0 allowing any not-null string > values as enabled is still a bit odd, so how about we make two string > values, like `none` (default value) and `all`? > > > Guozhang > > > On Tue, May 8, 2018 at 3:35

Re: Use of a formatter like Scalafmt

2018-05-09 Thread Matthias J. Sax
Joan, thanks for starting this initiative. I am overall +1 However, I am worried about applying it to `core` module as the change is massive. For the Kafka Streams Scala module, that is new and was not released yet, I am +1. A personal thing about the style: the 2-space indention for JavaDocs is

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-10 Thread Matthias J. Sax
rent protocol and how to enable users > override those rule, and how to expose them in the DSL layer in a future > KIP. > > > > Guozhang > > > On Mon, May 7, 2018 at 5:49 PM, Matthias J. Sax > wrote: > >> Guozhang, >> >> if you advocate to

Re: Request to create KIP

2018-05-10 Thread Matthias J. Sax
What is your Wiki ID ? -Matthias On 5/10/18 3:36 AM, Anurag Jain wrote: > Hi, > > I would like to create KIP for > *https://issues.apache.org/jira/browse/KAFKA-2200 > *. > > Can you please give me permission to create KIP for this? > > Thanks,

Re: KIP-244: Add Record Header support to Kafka Streams

2018-05-11 Thread Matthias J. Sax
gt; >> About this, should this be managed on KIP-159 or a new one? >> >> El jue., 10 may. 2018 a las 17:46, Matthias J. Sax (>> ) >> escribió: >> >>> Thanks Guozhang! Sounds good to me! >>> >>> -Matthias >>> >>> O

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Matthias J. Sax
gt;>>> stateStoreNames, >>>>>>>>final Materialized>>>>>>> VR, KeyValueStore materialized); >>>>>>>> >>>>>>>> KTable transformValues(final >>>&g

Re: [DISCUSS] KIP-292: Add transformValues() method to KTable

2018-05-11 Thread Matthias J. Sax
d >> and wonderful bugs, and become a common source of bugs and another 'thing' >> developers need to know not to do, or would it 'just work'? If its the >> former, then I think that's a strong case to have the code explicitly stop >> users doing dumb

Re: [VOTE] KIP-292: Add KTable#transformValues() method in Kafka Streams DSL

2018-05-11 Thread Matthias J. Sax
+1 (binding) On 5/11/18 2:17 PM, Ted Yu wrote: > +1 > > On Fri, May 11, 2018 at 2:16 PM, Guozhang Wang wrote: > >> +1 (binding) >> >> Also slightly changed the title beyond changing [DISCUSS] to [VOTE] since >> Gmail will collapse these two threads into one, so people may not realize >> there

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

2018-05-14 Thread Matthias J. Sax
+1 (binding) Thanks a lot for the KIP! -Matthias On 5/14/18 10:17 AM, Guozhang Wang wrote: > +1 from me > > One more comment on the wiki: while reviewing the PR I realized that in ` > MockProcessorContext.java >

Re: Can anyone take a look at this KIP and Jira?

2018-05-14 Thread Matthias J. Sax
I agree with Ted. This change does not require a KIP. If ok with you, I can delete the KIP page in the Wiki for you. -Matthias On 5/10/18 11:59 AM, Ted Yu wrote: > Since the change is internal to *SensorAccess class, looks like KIP is not > required.* > > On Thu, May 10, 2018 at 11:54 AM, qingj

Re: Kafka system tests contribution

2018-05-14 Thread Matthias J. Sax
Hard to say why it fails. Note, that some system tests a flaky (we are working constantly to stabilize them) What helps debugging is to look into the ducktape log itself. You can find it in the file `test_log.debug` that is written into `resutls/` Also inspect the actual test log files, as we

Re: Exactly Once, Producer configuration

2018-05-14 Thread Matthias J. Sax
Hi, I don't think that the `producer.properties` file exist once per broker, because this file should not be at the broker machine at all. It should be on the application side (ie, your "modules"). For transactions to work correctly, each `Producer` instance needs a cluster wide unique transactio

Re: [VOTE] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

2018-05-15 Thread Matthias J. Sax
+1 (binding) On 5/15/18 1:45 PM, Bill Bejeck wrote: > Hi all, > > I'd like to start a vote on KIP-295: Add Streams Configuration Allowing for > Optional Topology Optimization. > > KIP wiki page: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-295%3A+Add+Streams+Configuration+Allowing+fo

  1   2   3   4   5   6   7   8   9   10   >