Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-05 Thread Vahid S Hashemian
Hi Jason, Sure, I'll do that shortly. Thanks. --Vahid From: Jason Gustafson <ja...@confluent.io> To: dev@kafka.apache.org Date: 01/05/2017 09:59 AM Subject: Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update Hey Vahid, Since there haven't been any additional co

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-05 Thread Jason Gustafson
Hey Vahid, Since there haven't been any additional comments, perhaps start a new vote? -Jason On Tue, Jan 3, 2017 at 2:14 PM, Ismael Juma wrote: > I also prefer option 1. > > Ismael > > On Fri, Dec 16, 2016 at 7:11 PM, Jason Gustafson > wrote: > > >

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-03 Thread Ismael Juma
I also prefer option 1. Ismael On Fri, Dec 16, 2016 at 7:11 PM, Jason Gustafson wrote: > Thanks Vahid. To clarify the impact of this issue, since we have no way to > send an error code in the OffsetFetchResponse when requesting all offsets, > we cannot detect when the

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-03 Thread Ewen Cheslack-Postava
; > From: Vahid S Hashemian/Silicon Valley/IBM@IBMUS > To: dev@kafka.apache.org > Date: 12/19/2016 01:25 PM > Subject:Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update > > > > Happy Monday, > > Jason, thanks for further explaining the issue. > > I have

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2017-01-03 Thread Vahid S Hashemian
. Thanks. Regards, --Vahid From: Vahid S Hashemian/Silicon Valley/IBM@IBMUS To: dev@kafka.apache.org Date: 12/19/2016 01:25 PM Subject:Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update Happy Monday, Jason, thanks for further explaining the issue. I have updated the KIP

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-12-19 Thread Vahid S Hashemian
version here: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=66849788=26=25 Feedback and comments are welcome. Thanks. --Vahid From: Jason Gustafson <ja...@confluent.io> To: dev@kafka.apache.org Date: 12/16/2016 11:11 AM Subject: Re: [DISCUSS]

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-12-16 Thread Jason Gustafson
Thanks Vahid. To clarify the impact of this issue, since we have no way to send an error code in the OffsetFetchResponse when requesting all offsets, we cannot detect when the coordinator has moved to another broker or when it is still in the process of loading the offsets. This means we cannot

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-12-15 Thread Vahid S Hashemian
Hi all, Even though KIP-88 was recently approved, due to a limitation that comes with the proposed protocol change in KIP-88 I'll have to re-open it to address the problem. I'd like to thank Jason Gustafson for catching this issue. I'll explain this in the KIP as well, but to summarize, KIP-88

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-11-30 Thread Vahid S Hashemian
, and then put it up for a vote if no concern is raised by then. Regards, --Vahid From: Jason Gustafson <ja...@confluent.io> To: dev@kafka.apache.org Date: 11/30/2016 04:00 PM Subject: Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update Hey Vahid, Sorry to getting to this s

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-11-30 Thread Jason Gustafson
BMUS > To: dev@kafka.apache.org > Date: 11/09/2016 11:21 AM > Subject:Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update > > > > Jason, > For some reason I did not receive your earlier response to the thread. > I just saw it when I went to > https://www.mail-a

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-11-15 Thread Vahid S Hashemian
e: 11/09/2016 11:21 AM Subject: Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update Jason, For some reason I did not receive your earlier response to the thread. I just saw it when I went to https://www.mail-archive.com/dev@kafka.apache.org/msg59608.html In the updated KIP I exposed the

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-11-09 Thread Vahid S Hashemian
it to AdminClient in the next round if you think that's the better approach. Thanks. --Vahid From: Vahid S Hashemian/Silicon Valley/IBM@IBMUS To: dev@kafka.apache.org Date: 11/09/2016 11:12 AM Subject:Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update Hi Jason (et al.), I

Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update

2016-11-09 Thread Vahid S Hashemian
Hi Jason (et al.), I modified the KIP towards a change in OffsetFetch protocol, as per your suggestion. https://cwiki.apache.org/confluence/display/KAFKA/KIP-88%3A+OffsetFetch+Protocol+Update I'd appreciate it if you could take another look and share your thoughts. Thanks. --Vahid From: