Thanks Guozhang and Matthias! https://github.com/apache/kafka/pull/5307 is
merged now.
We can close this thread now since we have a total of 3 binding votes (and
3 additional non-binding votes).
On Fri, Jan 4, 2019 at 11:59 AM Guozhang Wang wrote:
> Hello Shawn,
>
> Could you close this voting
Hello Shawn,
Could you close this voting thread with a tally on the votes (you can
search for other voting threads as a reference)?
Guozhang
On Wed, Dec 19, 2018 at 1:15 AM Matthias J. Sax
wrote:
> Sorry for the delay. Needed to read the KIP and code multiple times to
> wrap my head around
Sorry for the delay. Needed to read the KIP and code multiple times to
wrap my head around it.
Thanks for the KIP.
+1 (binding)
-Matthias
On 12/13/18 1:19 PM, Damian Guy wrote:
> +1 (binding)
>
> On Wed, 12 Dec 2018 at 13:27, Adam Bellemare
> wrote:
>
>> +1 (non-binding) from me. Looks
+1 (binding)
On Wed, 12 Dec 2018 at 13:27, Adam Bellemare
wrote:
> +1 (non-binding) from me. Looks like a pretty clear-cut case.
>
>
>
> On Tue, Dec 11, 2018 at 1:11 AM Shawn Nguyen
> wrote:
>
> > Thanks for the feedback Guozhang! I updated the KIP.
> >
> > In the meantime, could I ask for
+1 (non-binding) from me. Looks like a pretty clear-cut case.
On Tue, Dec 11, 2018 at 1:11 AM Shawn Nguyen
wrote:
> Thanks for the feedback Guozhang! I updated the KIP.
>
> In the meantime, could I ask for additional binding votes/approval on this
> KIP proposal?
>
> Shawn
>
> On Thu, Dec 6,
Thanks for the feedback Guozhang! I updated the KIP.
In the meantime, could I ask for additional binding votes/approval on this
KIP proposal?
Shawn
On Thu, Dec 6, 2018 at 1:22 PM Liquan Pei wrote:
> +1 (non-binding)
>
> On Wed, Dec 5, 2018 at 4:51 PM Guozhang Wang wrote:
>
>> Hello Shawn,
>>
for KIP-393 (Fix time windowed serde to deserialize changelog
topic)
+1 (non-binding)
On Wed, Dec 5, 2018 at 4:51 PM Guozhang Wang wrote:
> Hello Shawn,
>
> Thanks for the writeup. I've made a pass over it and here are some minor
> comments:
>
> 1) As we discussed in the PR
+1 (non-binding)
On Wed, Dec 5, 2018 at 4:51 PM Guozhang Wang wrote:
> Hello Shawn,
>
> Thanks for the writeup. I've made a pass over it and here are some minor
> comments:
>
> 1) As we discussed in the PR: https://github.com/apache/kafka/pull/5307,
> the public APIs that we will add is
>
> In
Hello Shawn,
Thanks for the writeup. I've made a pass over it and here are some minor
comments:
1) As we discussed in the PR: https://github.com/apache/kafka/pull/5307,
the public APIs that we will add is
In WindowedSerdes:
```
static public Serde> timeWindowedChangelogSerdeFrom(final
Class
