Re: Review Request 52028: LENS-1308: User config loader database calls not inserting entries

2016-10-04 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52028/ --- (Updated Oct. 4, 2016, 1:55 p.m.) Review request for lens. Bugs: LENS-1308

Re: Review Request 52028: LENS-1308: User config loader database calls not inserting entries

2016-10-03 Thread Rajat Khandelwal
> On Sept. 28, 2016, 12:26 p.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java, > > line 84 > > > > > > Can we confirm that before this patch

Re: Review Request 52028: LENS-1308: User config loader database calls not inserting entries

2016-10-03 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52028/ --- (Updated Oct. 3, 2016, 3:40 p.m.) Review request for lens. Bugs: LENS-1308

Re: Review Request 52028: LENS-1308: User config loader database calls not inserting entries

2016-09-28 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52028/#review150689 --- Fix it, then Ship it! Ship It!