Re: Changes to how hack/build-go.sh uses GOPATH

2016-02-16 Thread Dan Mace
On Tue, Feb 16, 2016 at 5:31 AM, Michalis Kargakis wrote: > If I have a tool in my GOPATH that uses a different version of say cobra, > wont there be a conflict? > > You still need to configure GOPATH in your tooling to prefix origin/Godeps/_workspace so that the vendored deps take precedence ove

Re: OpenShift go client library

2016-10-11 Thread Dan Mace
On Tue, Oct 11, 2016 at 9:12 AM, Andy Goldstein wrote: > We don't currently have a standalone go client library. Your best bet, for > now, is to use Godeps to vendor in the same versions of dependencies that > OpenShift currently uses. > > Andy > ​The way we handle this for various OpenShift Onl

Re: OpenShift go client library

2016-10-12 Thread Dan Mace
Oct 11, 2016 at 9:05 PM, Clayton Coleman > wrote: > > Once it settles, yes. > > > >> On Oct 11, 2016, at 9:34 AM, Jimmi Dyson wrote: > >> > >>> On 11 October 2016 at 17:23, Tomas Kral wrote: > >>>> On Tue, Oct 11, 2016 at 3:26 PM, Dan

Re: [aos-devel] optimizing go guru

2017-12-05 Thread Dan Mace
slow, but then again it's hard to gauge exactly how narrow that scope is without looking at a full import dependency graph... Guru has always been really slow for lots of useful pointer analysis queries, so I'm not entirely surprised. This is why vscode-go uses a variety of more optimized

Re: [3.x]: openshift router and its own metrics

2019-08-15 Thread Dan Mace
metrics points are counters which were being reset across reloads. The patch was (I think) to enable counter metrics to correctly aaccumulate across reloads. As to how the image itself is built, the pkg directly is part of the router controller code included with the