Re: Building log4j2 from console supporting ANSI colors fails

2018-03-21 Thread Remko Popma
Sorry it took me so long to get around to it. > On Mar 21, 2018, at 20:59, Apache wrote: > > Obviously I didn’t see Remko’s reply before sending mine. > > Ralph > >> On Mar 21, 2018, at 4:57 AM, Apache wrote: >> >> Please do. Thanks! >> >> Ralph >> >>> On Mar 20, 2018, at 11:20 PM, Atle

Re: Building log4j2 from console supporting ANSI colors fails

2018-03-21 Thread Apache
Obviously I didn’t see Remko’s reply before sending mine. Ralph > On Mar 21, 2018, at 4:57 AM, Apache wrote: > > Please do. Thanks! > > Ralph > >> On Mar 20, 2018, at 11:20 PM, Atle Tokle wrote: >> >> I made a fresh clone from master today, and looked into it myself. >> In CommandLineHelpTe

Re: Building log4j2 from console supporting ANSI colors fails

2018-03-21 Thread Apache
Please do. Thanks! Ralph > On Mar 20, 2018, at 11:20 PM, Atle Tokle wrote: > > I made a fresh clone from master today, and looked into it myself. > In CommandLineHelpTest.java all the tests that is failing is instanciating > a Help class. In all cases it have an alternative constructor where yo

Re: Building log4j2 from console supporting ANSI colors fails

2018-03-21 Thread Remko Popma
These tests have been removed. On Wed, Mar 21, 2018 at 7:39 PM, Remko Popma wrote: > We will probably just remove these tests; there is no need to bring the > picocli tests in to the Log4j2 project. > > On Wed, Mar 21, 2018 at 3:20 PM, Atle Tokle wrote: > >> I made a fresh clone from master tod

Re: Building log4j2 from console supporting ANSI colors fails

2018-03-21 Thread Remko Popma
We will probably just remove these tests; there is no need to bring the picocli tests in to the Log4j2 project. On Wed, Mar 21, 2018 at 3:20 PM, Atle Tokle wrote: > I made a fresh clone from master today, and looked into it myself. > In CommandLineHelpTest.java all the tests that is failing is i

Re: Building log4j2 from console supporting ANSI colors fails

2018-03-20 Thread Atle Tokle
I made a fresh clone from master today, and looked into it myself. In CommandLineHelpTest.java all the tests that is failing is instanciating a Help class. In all cases it have an alternative constructor where you can specify Help.Ansi.OFF to avoid that the test depends on the console it run from.

Re: Building log4j2 from console supporting ANSI colors fails

2018-03-11 Thread Remko Popma
Thanks for reporting this. I’ll take a look. Remko > On Mar 11, 2018, at 17:32, Atle Tokle wrote: > > I tried to build from GIT bash on windows 10, and first test that failed > was > > testSynopsisOrderCorrectWhenParametersDeclaredOutOfOrder in > > org.apache.logging.log4j.core.tools.picocl

Building log4j2 from console supporting ANSI colors fails

2018-03-11 Thread Atle Tokle
I tried to build from GIT bash on windows 10, and first test that failed was testSynopsisOrderCorrectWhenParametersDeclaredOutOfOrder in org.apache.logging.log4j.core.tools.picocli. CommandLineHelpTest:2008 It seems like the expected result format(" %n") on line 2014 always assumes that no A