Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r201222488
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -120,25 +122,41 @@ public void before() throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-12441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538078#comment-16538078
]
mosh commented on SOLR-12441:
-
{quote}Having a query by ancestor ability would allow me to filter where
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537381#comment-16537381
]
David Smiley commented on SOLR-12519:
-
bq. my query is for all the children of "a:b", which contain
[
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537479#comment-16537479
]
Steve Rowe commented on SOLR-12412:
---
Policeman Jenkins found a reproducing seed
Build: https://builds.apache.org/job/Lucene-Solr-repro/945/
[...truncated 47 lines...]
[repro] Jenkins log URL:
https://builds.apache.org/job/Lucene-Solr-Tests-7.x/668/consoleText
[repro] Revision: 3fccbf9c39636ba1f53fd422154ca7a51016e93d
[repro] Repro line: ant test
Build: https://builds.apache.org/job/Lucene-Solr-Tests-7.x/669/
9 tests failed.
FAILED:
org.apache.solr.cloud.LeaderTragicEventTest.testOtherReplicasAreNotActive
Error Message:
Jetty Connector is not open: -2
Stack Trace:
java.lang.IllegalStateException: Jetty Connector is not open: -2
Nandakishore Krishna created SOLR-12541:
---
Summary: Metrics handler throws an error if there are transient
cores
Key: SOLR-12541
URL: https://issues.apache.org/jira/browse/SOLR-12541
Project:
Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-7.x/258/
8 tests failed.
FAILED:
org.apache.solr.cloud.AliasIntegrationTest.testDeleteAliasWithExistingCollectionName
Error Message:
collection_old should point to collection_new
Stack Trace:
java.lang.AssertionError:
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/22427/
Java: 64bit/jdk1.8.0_172 -XX:+UseCompressedOops -XX:+UseSerialGC
18 tests failed.
FAILED:
junit.framework.TestSuite.org.apache.solr.client.solrj.embedded.TestSolrProperties
Error Message:
Suite timeout exceeded (>= 720
Well, the list is getting smaller, which is A Good Thing. Here's the
list currently, full report attached.
Let me know if there are objections.
I may be overly optimistic, but we might finally be approaching the
point where we can start thinking about the backlog.
**Annotations will be
[
https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537367#comment-16537367
]
Erick Erickson commented on SOLR-12008:
---
All tests pass on Windows, so I'll commit this probably
[
https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537904#comment-16537904
]
Yonik Seeley commented on SOLR-12343:
-
Looks good, thanks for tracking that down!
> JSON Field Facet
[
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537875#comment-16537875
]
Cao Manh Dat edited comment on SOLR-12412 at 7/10/18 2:02 AM:
--
Thanks
[
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537875#comment-16537875
]
Cao Manh Dat commented on SOLR-12412:
-
Thanks [~steve_rowe], I will take a look at the failure.
[
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537901#comment-16537901
]
ASF subversion and git services commented on SOLR-12412:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537903#comment-16537903
]
ASF subversion and git services commented on SOLR-12412:
Commit
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/1960/
Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseG1GC
10 tests failed.
FAILED:
junit.framework.TestSuite.org.apache.solr.handler.component.SuggestComponentTest
Error Message:
Suite timeout exceeded (>= 720 msec).
[
https://issues.apache.org/jira/browse/LUCENE-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-8390:
--
Attachment: LUCENE-8390.patch
> Replace MatchesIteratorSupplier with IOSupplier
>
Alan Woodward created LUCENE-8390:
-
Summary: Replace MatchesIteratorSupplier with IOSupplier
Key: LUCENE-8390
URL: https://issues.apache.org/jira/browse/LUCENE-8390
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/SOLR-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536722#comment-16536722
]
dennis lucero commented on SOLR-9882:
-
The issue is still happening on 7.3.1.
Can the patches be
[
https://issues.apache.org/jira/browse/SOLR-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536721#comment-16536721
]
dennis lucero commented on SOLR-7864:
-
The issue is still happening on 7.3.1.
Can the patches be
Adrien Grand created LUCENE-8392:
Summary: TieredMergePolicy has broken assumptions when
maxMergeAtOnce is greater than segmentsPerTier
Key: LUCENE-8392
URL: https://issues.apache.org/jira/browse/LUCENE-8392
[
https://issues.apache.org/jira/browse/LUCENE-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8392:
-
Attachment: LUCENE-8392.patch
> TieredMergePolicy has broken assumptions when maxMergeAtOnce is
[
https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536709#comment-16536709
]
Cao Manh Dat commented on SOLR-12297:
-
Hi, I skimmed through
[
https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536709#comment-16536709
]
Cao Manh Dat edited comment on SOLR-12297 at 7/9/18 9:00 AM:
-
Hi, I skimmed
[
https://issues.apache.org/jira/browse/LUCENE-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536715#comment-16536715
]
Adrien Grand commented on LUCENE-8390:
--
+1
I'd remove it directly without a deprecation phase
Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-master/1580/
4 tests failed.
FAILED: org.apache.solr.cloud.FullSolrCloudDistribCmdsTest.test
Error Message:
Test abandoned because suite timeout was reached.
Stack Trace:
java.lang.Exception: Test abandoned because suite timeout was
[
https://issues.apache.org/jira/browse/LUCENE-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536789#comment-16536789
]
Adrien Grand commented on LUCENE-8392:
--
Here is a patch. It computes {{mergeFactor=min(segsPerTier,
[
https://issues.apache.org/jira/browse/LUCENE-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8391:
-
Attachment: LUCENE-8391.patch
> Better tests for merge policies
>
Adrien Grand created LUCENE-8391:
Summary: Better tests for merge policies
Key: LUCENE-8391
URL: https://issues.apache.org/jira/browse/LUCENE-8391
Project: Lucene - Core
Issue Type: Test
[
https://issues.apache.org/jira/browse/SOLR-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536577#comment-16536577
]
Lucene/Solr QA commented on SOLR-12458:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536567#comment-16536567
]
Erick Erickson commented on SOLR-12008:
---
Well, I'm getting there. I've set up a Windows VM and
[
https://issues.apache.org/jira/browse/LUCENE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536633#comment-16536633
]
Alan Woodward commented on LUCENE-8229:
---
Simon added IOSupplier rather than IOConsumer, which
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r201059845
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537172#comment-16537172
]
Andrzej Bialecki commented on SOLR-10648:
--
These properties are also exposed via
Adrien Grand created LUCENE-8393:
Summary: TieredMergePolicy needs to take into account the maximum
segment size when computing the allowed number of segments
Key: LUCENE-8393
URL:
Build: https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-master/93/
11 tests failed.
FAILED: org.apache.solr.cloud.BasicDistributedZkTest.test
Error Message:
distrib-dup-test-chain-explicit: doc#3 has wrong value for regex_dup_A_s
expected: but was:
Stack Trace:
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r200996646
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/NestedUpdateProcessorFactory.java
---
@@ -72,8 +72,8 @@ public void
[
https://issues.apache.org/jira/browse/LUCENE-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-8390.
---
Resolution: Fixed
Fix Version/s: 7.5
Thanks for the review Adrien. I did as you
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/4724/
Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseParallelGC
15 tests failed.
FAILED: org.apache.solr.cloud.TestPullReplica.testRemoveAllWriterReplicas
Error Message:
Replica core_node4 not up to date after 10 seconds
[
https://issues.apache.org/jira/browse/LUCENE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536899#comment-16536899
]
Adrien Grand commented on LUCENE-8393:
--
Here is a patch.
> TieredMergePolicy needs to take into
[
https://issues.apache.org/jira/browse/LUCENE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8393:
-
Attachment: LUCENE-8393.patch
> TieredMergePolicy needs to take into account the maximum
I authored the recent change you're commenting on. I agree with your
points; my only defense is consistency. Several other nearby
assertions used the older try-catch based setup.
I'll fix the spot you objected to, and file a JIRA around cleaning
this up more broadly. Having this elsewhere in
[
https://issues.apache.org/jira/browse/LUCENE-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536838#comment-16536838
]
ASF subversion and git services commented on LUCENE-8390:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536837#comment-16536837
]
ASF subversion and git services commented on LUCENE-8390:
-
Commit
Can you run a mirror instance and swap traffic, performing reindexing on an
online system, and then bring it online when complete?
On Sun, Jul 8, 2018, 7:46 PM changchun huang (JIRA) wrote:
>
> [
>
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Linux/2290/
Java: 64bit/jdk-10 -XX:+UseCompressedOops -XX:+UseSerialGC
11 tests failed.
FAILED:
junit.framework.TestSuite.org.apache.solr.handler.component.InfixSuggestersTest
Error Message:
Suite timeout exceeded (>= 720 msec).
Stack
[
https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536989#comment-16536989
]
Erick Erickson commented on SOLR-12008:
---
That was bad. I got enthusiastic about changing
{{
[
https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536989#comment-16536989
]
Erick Erickson edited comment on SOLR-12008 at 7/9/18 2:43 PM:
---
That was
bq. " Having this elsewhere in the code encourages it to creep in more."
+1. While I hesitate to make lots of changes that are unnecessary, the
other side of that argument is that when we see code its easy to think
it's the norm rather than old
On Mon, Jul 9, 2018 at 4:52 AM, Jason Gerlowski
[
https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536963#comment-16536963
]
Mark Miller commented on SOLR-12297:
I don’t plan on doing any of this price mail. If it goes in, it
Greetings, Apache software enthusiasts!
(You’re getting this because you’re on one or more dev@ or users@ lists
for some Apache Software Foundation project.)
ApacheCon North America, in Montreal, is now just 80 days away, and
early bird prices end in just two weeks - on July 21. Prices will
[
https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-12008:
--
Attachment: SOLR-12008.patch
> Settle a location for the "correct" log4j2.xml file.
>
GitHub user hbasejanitor opened a pull request:
https://github.com/apache/lucene-solr/pull/415
Solr 12458
Support for ADLS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hbasejanitor/lucene-solr SOLR-12458
Alternatively you can
[
https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536963#comment-16536963
]
Mark Miller edited comment on SOLR-12297 at 7/9/18 2:19 PM:
I don’t plan on
[
https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536973#comment-16536973
]
Mark Miller commented on SOLR-12297:
Of course anyone can feel free to pull in what they want. I’m
[
https://issues.apache.org/jira/browse/LUCENE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537241#comment-16537241
]
Adrien Grand commented on LUCENE-8394:
--
Here is a patch that ensures that the allowed segment count
[
https://issues.apache.org/jira/browse/SOLR-12441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537285#comment-16537285
]
David Smiley commented on SOLR-12441:
-
Although arguably how the field should be indexed is
Build: https://builds.apache.org/job/Lucene-Solr-repro/944/
[...truncated 28 lines...]
[repro] Jenkins log URL:
https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-7.x/97/consoleText
[repro] Revision: 9cd7daf8f907d93743463eb73cb921a3125c5909
[repro] Repro line: ant test
[
https://issues.apache.org/jira/browse/LUCENE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8394:
-
Attachment: LUCENE-8394.patch
> TieredMergePolicy's handling of the case that all segments are
Adrien Grand created LUCENE-8394:
Summary: TieredMergePolicy's handling of the case that all
segments are less than the floor segment size is fragile
Key: LUCENE-8394
URL:
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r201076987
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -120,25 +122,41 @@ public void before() throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537291#comment-16537291
]
Tomás Fernández Löbbe commented on SOLR-12412:
--
Thanks for working on this [~caomanhdat]!
[
https://issues.apache.org/jira/browse/SOLR-12441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537051#comment-16537051
]
mosh commented on SOLR-12441:
-
{quote}See PathHierarchyTokenizerFactoryTest and the descendents vs ancestors
[
https://issues.apache.org/jira/browse/SOLR-12441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537051#comment-16537051
]
mosh edited comment on SOLR-12441 at 7/9/18 3:17 PM:
-
{quote}See
[
https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537117#comment-16537117
]
Adrien Grand commented on LUCENE-8383:
--
I went ahead and merged these issues so that it's easier to
[
https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537132#comment-16537132
]
Erick Erickson commented on LUCENE-8383:
Thanks!
> Fix computation of mergingBytes in
[
https://issues.apache.org/jira/browse/SOLR-12441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537081#comment-16537081
]
David Smiley commented on SOLR-12441:
-
bq. Perhaps this discussion should be moved to the
[
https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537106#comment-16537106
]
ASF subversion and git services commented on LUCENE-8383:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537104#comment-16537104
]
ASF subversion and git services commented on LUCENE-8383:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537105#comment-16537105
]
ASF subversion and git services commented on LUCENE-8385:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537103#comment-16537103
]
ASF subversion and git services commented on LUCENE-8385:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8383.
--
Resolution: Fixed
Fix Version/s: 7.5
master (8.0)
> Fix computation
[
https://issues.apache.org/jira/browse/LUCENE-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8385.
--
Resolution: Fixed
Fix Version/s: 7.5
master (8.0)
> Fix computation
[
https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537306#comment-16537306
]
Hoss Man commented on SOLR-12343:
-
Ok ... fresh eyes and i see the problem.
When {{final int overreq =
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-MacOSX/734/
Java: 64bit/jdk-9 -XX:+UseCompressedOops -XX:+UseG1GC
15 tests failed.
FAILED: org.apache.solr.cloud.TestPullReplica.testKillLeader
Error Message:
Replica core_node4 not up to date after 10 seconds expected:<1> but was:<0>
76 matches
Mail list logo
