Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/464#discussion_r230120449
--- Diff:
solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ---
@@ -656,45 +656,38 @@ public void testAliasingBoost
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/489
SOLR-12955: separate DistribUpdateProcessor to Zk and nonZk classes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barrotsteindev
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/519
I've continued hacking on this issue last night, and have been facing some
issues concerning the base class.
I agree, I'll stash the changes and try tackling this again.
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/528
SOLR-12955 2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barrotsteindev/lucene-solr SOLR-12955-2
Alternatively you can review
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/519
created a [new PR](https://github.com/apache/lucene-solr/pull/528)
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user barrotsteindev closed the pull request at:
https://github.com/apache/lucene-solr/pull/519
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/528
Tackling this again,
according to @dsmiley's input:
> I'm not sure if the "base" functionality needed to be in a new class... I
could imagine simpl
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241949194
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1417,45 +1407,7 @@ private void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241954714
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -56,8 +59,15 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241967695
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -56,8 +59,15 @@ public void
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/528
addressed comments about previous PR and re-based on latest master
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/528
Oh yes,
I still have a few Todo's I added that I'd like to tackle.
I won't have time for more today,
Hopefully I'll be able to get these done by
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/428
SOLR-12586: deprecate joda-time and use java.time instead
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barrotsteindev/lucene
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207019625
--- Diff: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ---
@@ -212,12 +213,12 @@ public SchemaCaching(SolrResourceLoader loader
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207060505
--- Diff: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ---
@@ -212,12 +213,12 @@ public SchemaCaching(SolrResourceLoader loader
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207251678
--- Diff:
solr/core/src/test-files/solr/collection1/conf/solrconfig-parsing-update-processor-chains.xml
---
@@ -29,43 +29,43
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207252080
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -144,15 +153,19 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207460442
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -144,15 +153,19 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207465468
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -115,9 +123,10 @@ protected
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/431
SOLR-12602: fix SignificantTermsStream and StreamExpressionTest
fix SignificantTermsStream so
StreamExpressionTest#testSignificantTermsStream passes
You can merge this pull request
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/431
close #431 since SOLR-12602 has been fixed by SOLR-12574
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/431
closing this PR since SOLR-12602 has already been fixed by SOLR-12574.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user barrotsteindev closed the pull request at:
https://github.com/apache/lucene-solr/pull/431
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207585634
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -115,9 +123,10 @@ protected
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207591947
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -115,9 +123,10 @@ protected
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207691834
--- Diff: solr/licenses/joda-time-NOTICE.txt ---
@@ -1,5 +0,0
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207692433
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -50,10 +55,9 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207742308
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -172,4 +181,34 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207742429
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -171,36 +162,36 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207745675
--- Diff:
solr/core/src/test-files/solr/collection1/conf/solrconfig-parsing-update-processor-chains.xml
---
@@ -29,43 +29,43
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/428
> EEE MMM dd HH:mm:ss ZZZ
This format can be simplified to EEE MMM dd HH:mm:ss z , so
I used that one inst
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/428
I have changed the docs and config files.
Fingers crossed I didn't miss any. ð
---
-
To unsubscribe, e
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/464#discussion_r227038483
--- Diff: solr/core/src/test/org/apache/solr/search/TestRealTimeGet.java ---
@@ -414,56 +391,44 @@ public void testOptimisticLocking() throws
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/464
WIP SOLR-12555: refactor tests for package org.apache.solr.search
Tests are refactored to use expectThrows instead of try/catch.
You can merge this pull request into a Git repository by
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/425
WIP SOLR-12555: refactor tests to use expectThrows
Refactor tests to use expectThrows instead of the old try catch method.
You can merge this pull request into a Git repository by
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204858410
--- Diff: solr/core/src/test/org/apache/solr/TestDistributedSearch.java ---
@@ -910,13 +910,11 @@ public void test() throws Exception
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204858823
--- Diff: solr/core/src/test/org/apache/solr/TestDistributedSearch.java ---
@@ -910,13 +910,11 @@ public void test() throws Exception
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204860462
--- Diff: solr/core/src/test/org/apache/solr/cloud/BasicZkTest.java ---
@@ -150,15 +150,13 @@ public void testBasic() throws Exception
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204862363
--- Diff: solr/core/src/test/org/apache/solr/cloud/OverseerStatusTest.java
---
@@ -58,14 +59,13 @@ public void test() throws Exception
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/425
Hopefully this is satisfactory after the last commit changes.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/489#discussion_r24521
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/CdcrUpdateProcessor.java ---
@@ -16,115 +16,12 @@
*/
package
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/489
I will rebase this PR on the latest master.
It is going to be quite hard to separate this into smaller changes, since I
tried not to change the core logic where possible, and instead
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/519
SOLR-12955: rebase and split changes to smaller commits
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barrotsteindev/lucene-solr
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/489
@dsmiley, would you want this to be separated to different commits on the
development branch, so you can view each one and review them separately, or
would you like to commit each one to
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/438
SOLR-12593: Remove date parsing functionality from extraction contrib
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r211818226
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1146,6 +1146,11 @@
-MM-dd HH:mm[:ss[.SSS]][z
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r211818326
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1146,6 +1146,11 @@
-MM-dd HH:mm[:ss[.SSS]][z
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/438
Used the patterns from parse-date-patterns-from-extract-contrib,
which seem to work just fine :).
---
-
To
Github user barrotsteindev closed the pull request at:
https://github.com/apache/lucene-solr/pull/435
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/435
Closing this PR,
as it was merged.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212033718
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1141,11 +1141,11 @@
- -MM
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/438
@dsmiley , I am having trouble figuring out which parts of the ref guide I
should edit,
could you give me a hand as I am fairly new to this? ð
Apologies, I am very new to all
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212788729
--- Diff:
solr/contrib/extraction/src/test-files/extraction/solr/collection1/conf/solrconfig.xml
---
@@ -43,6 +43,25
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/438
> Alternatively, perhaps leave that part to me. Or take a 1st cut at it and
I edit from there, which I'm likely to do any way. Either way.
I read the doc file and could
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212803184
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1141,11 +1141,13 @@
- -MM
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212803494
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1141,11 +1141,13 @@
- -MM
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/438#discussion_r212803611
--- Diff: solr/server/solr/configsets/_default/conf/solrconfig.xml ---
@@ -1141,11 +1141,13 @@
- -MM
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/438
Added test for RFC-2616 (ParsingFieldUpdateProcessorsTest#testRfc2616) :-).
---
-
To unsubscribe, e-mail: dev
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/438
Luckily for us the locale does not seem to cause a problem.
Unfortunately, the double space before single day digit test did not pass,
forcing me to change the asctime configuration
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243628041
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
---
@@ -425,4 +448,10 @@ void setupRequest
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243843852
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -42,15 +53,36 @@ public
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243844755
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
@@ -1250,23 +1250,10 @@ private UpdateCommand
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243844969
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -42,15 +53,36 @@ public
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243850226
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -0,0 +1,121
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243850805
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -0,0 +1,121
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r243995067
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -0,0 +1,121
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r244007693
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -42,15 +53,36 @@ public
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/528
> It'd be excellent if we could get some consistency of calling
setupRequest -- all processXXX methods should first call setupRequest and if
needed an overloaded variant.
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/528
> postProcessDeleteByQuery can be renamed to doDistribDeleteByQuery, and
postProcessDeleteById can be renamed doDistribDeleteById.
I pushed a commit with these requested chan
GitHub user barrotsteindev opened a pull request:
https://github.com/apache/lucene-solr/pull/435
SOLR-12591: add tests to ensure ParseDateFieldUpdateProcessor compatiâ¦
â¦blity with ExtractionDateUtil
You can merge this pull request into a Git repository by running:
$ git
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209430852
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -896,13 +899,125 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209446062
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -159,8 +170,9 @@ public void
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209462345
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -896,13 +899,125 @@ public void
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/435
Hopefully the last commit got everything sorted out. :)
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/435#discussion_r209660011
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/ParseDateFieldUpdateProcessorFactory.java
---
@@ -159,8 +170,9 @@ public void
Github user barrotsteindev commented on the issue:
https://github.com/apache/lucene-solr/pull/435
Oh nice, hopefully the tests will pass :)
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For
76 matches
Mail list logo
