Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Hi @jimczi, PR is up-to-date and ready for review. All Lucene tests are
green on my side.
As you'll see, I'd like to suggest a slightly different implementation to
keep `approximation
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232945175
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,150 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r232943788
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,18 @@ public void setScorer(Scorable scorer) throws
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r232942272
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,18 @@ public void setScorer(Scorable scorer) throws
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r233016811
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,18 @@ public void setScorer(Scorable scorer) throws
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232663501
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,97 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232663580
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,97 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232664251
--- Diff:
lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
---
@@ -160,5 +160,78 @@ public void
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232664071
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,97 @@ public CacheHelper getCoreCacheHelper
GitHub user cbismuth opened a pull request:
https://github.com/apache/lucene-solr/pull/497
LUCENE-8026: ExitableDirectoryReader does not instrument points
> This means it cannot interrupt range or geo queries.
See [LUCENE-8026](https://issues.apache.org/jira/browse/LUC
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r232666957
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,20 @@ public void setScorer(Scorable scorer) throws
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/496#discussion_r232665140
--- Diff:
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
@@ -68,6 +68,20 @@ public void setScorer(Scorable scorer) throws
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thank you @jimczi.
I've added parametrized tests with phrase and term queries to check the two
constructors of the `ConstantScoreScorer` class.
And I also came back to your
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232681035
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,97 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232681011
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,97 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232681060
--- Diff:
lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
---
@@ -160,5 +160,78 @@ public void
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232681097
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,97 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233838121
--- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
---
@@ -766,7 +766,7 @@ public ScorerSupplier scorerSupplier
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thanks @jimczi, I'll rerun all Lucene tests to ensure nothing is broken and
I'll let you know.
---
-
To unsubscribe, e
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/496
Great! Thank you @jimczi.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233838293
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java ---
@@ -1903,9 +1903,6 @@ public void testRangeOptimizesIfAllPointsMatch
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233838178
--- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
---
@@ -844,7 +844,7 @@ public BulkScorer bulkScorer(LeafReaderContext
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233838241
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConjunctionDISI.java ---
@@ -234,12 +234,12 @@ public void testConjunction() throws
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Ant `precommit` task and Lucene test are all green.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r234132506
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233397063
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233396998
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
I'll default the score mode to `ScoreMode.TOP_SCORES` in all 45 constructor
callers. And then, I'll try to change it to a more sensible value based on the
caller context
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r233374738
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -70,7 +120,7 @@ public TwoPhaseIterator twoPhaseIterator
GitHub user cbismuth opened a pull request:
https://github.com/apache/lucene-solr/pull/499
LUCENE-8552: Optimize getMergedFieldInfos for one-segment FieldInfos
> FieldInfos.getMergedFieldInfos could trivially return the FieldInfos of
the first and only LeafReader if there is o
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Lucene tests are all green on my side, I'll launch Solr ones later this day.
I'm not at ease with these two changes
[here](https://github.com/apache/lucene-solr/pull/495/files#diff
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232200711
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232196043
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Please ignore my previous comment as some tests are broken when the scorer
has an approximation (see
[here](https://github.com/apache/lucene-solr/blob/1acfca5ebcc4eb8600fe0fc0def160f610866f72
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232183517
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thanks a lot @jimczi, I've understood my mistakes :+1: PR is ready for
review.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232178369
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232176947
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232176882
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thanks a lot @jimczi for the very quick and very helpful review, I've made
changes to improve this PR
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232179449
--- Diff:
lucene/core/src/test/org/apache/lucene/search/TestConstantScoreScorer.java ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
GitHub user cbismuth opened a pull request:
https://github.com/apache/lucene-solr/pull/495
LUCENE-8464: Implement ConstantScoreScorer#setMinCompetitiveScore
> We should make it so the iterator returns NO_MORE_DOCS after
setMinCompetitiveScore is called with a value that is grea
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
@jpountz PR is ready for review, thank you.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/495#discussion_r232324465
--- Diff:
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
@@ -70,7 +98,7 @@ public TwoPhaseIterator twoPhaseIterator
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Great! Exactly what I did except declaring a static inner class, Iâll
declare it :+1: thanks!
---
-
To unsubscribe, e
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232779864
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,157 @@ public CacheHelper getCoreCacheHelper
GitHub user cbismuth opened a pull request:
https://github.com/apache/lucene-solr/pull/496
LUCENE-8463: Early-terminate queries sorted by SortField.DOC
> Currently TopFieldCollector only early-terminates when the search sort is
a prefix of the index sort, but it could also ea
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232779517
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,157 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r232780211
--- Diff:
lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
---
@@ -152,13 +150,130 @@ public void
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/497
Thanks a lot! PR is up-to-date with your comments @mikemccand and @jpountz
:+1:
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
I think I've understood my mistake and it should be fixed now.
I've added a random condition in tests to check the second
`ConstantScoreScorer` constructor. Even though tests pass, I'm
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Well you're right, without a static wrapper (see
19e156cedd343b27214538aec58f24e1d66105da) I can't assign approximation to
`DocIdSetIterator.empty()` after setting `minCompetitiveScore
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r233517397
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,156 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r233524064
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,156 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/496
Lucene tests are green and PR is up-to-date with latest `master` branch.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r233551529
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -100,13 +109,156 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/497#discussion_r233556789
--- Diff:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
@@ -117,6 +117,7 @@ public CacheHelper getCoreCacheHelper
Github user cbismuth closed the pull request at:
https://github.com/apache/lucene-solr/pull/505
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/505
Obsolete, see
[643ffc6](https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=643ffc6).
---
-
To unsubscribe, e-mail
GitHub user cbismuth opened a pull request:
https://github.com/apache/lucene-solr/pull/505
LUCENE-8548: Reevaluate scripts boundary break in Nori's tokenizer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cbismuth/lucene-solr
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/496
I'm unsure how the contribution process should end here, should I close
this PR? Thanks.
---
-
To unsubscribe, e-mail: dev
Github user cbismuth closed the pull request at:
https://github.com/apache/lucene-solr/pull/496
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/496
Great, thanks @jimczi :+1:
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail
Github user cbismuth closed the pull request at:
https://github.com/apache/lucene-solr/pull/495
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user cbismuth closed the pull request at:
https://github.com/apache/lucene-solr/pull/499
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
65 matches
Mail list logo
