[GitHub] lucene-solr pull request: SOLR-8542: Integrate Learning to Rank in...

2016-05-27 Thread diegoceccarelli
Github user diegoceccarelli closed the pull request at: https://github.com/apache/lucene-solr/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] lucene-solr pull request: SOLR-8542: Integrate Learning to Rank in...

2016-05-27 Thread diegoceccarelli
Github user diegoceccarelli commented on the pull request: https://github.com/apache/lucene-solr/pull/4#issuecomment-222163577 thanks Alessandro, we integrated part of your PR in the new patch. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] lucene-solr pull request: SOLR-8542: Integrate Learning to Rank in...

2016-01-15 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/217 SOLR-8542: Integrate Learning to Rank into Solr See https://issues.apache.org/jira/i#browse/SOLR-8542 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] lucene-solr pull request: SOLR-8542: Integrate Learning to Rank in...

2016-01-29 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/4 SOLR-8542: Integrate Learning to Rank into Solr Solr Learning to Rank (LTR) provides a way for you to extract features directly inside Solr for use in training a machine learned model

[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

2017-02-28 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/162 SOLR-8776: Support RankQuery in grouping Update SOLR-8776 to current master - Reranking and grouping work together in non-distributed setting when grouping is done by field

[GitHub] lucene-solr issue #202: SOLR-10703 Add prepare and finish in DocTrasformer

2017-06-30 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/202 @m-khl I updated the patch, highlights: 1. I removed `prepare` and relied on the old `setContext()`; 2. now a DocTransformer implements Closeable and provides the method

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-05-18 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/202 SOLR-10703 Add prepare and finish in DocTrasformer This patch adds a prepare and a finish method to the interface of DocTransformer allowing a developer to perform actions before/after

[GitHub] lucene-solr pull request #204: SOLR-10710: Fix LTR contrib failures

2017-05-19 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/204 SOLR-10710: Fix LTR contrib failures This patch fixes the tests failing in LTR. There will be more work to do on the tests because some rely on absolute scores from solr, so change

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120698740 --- Diff: solr/core/src/java/org/apache/solr/response/DocsStreamer.java --- @@ -142,6 +142,11 @@ public boolean hasNext() { return

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120697530 --- Diff: solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java --- @@ -187,8 +187,8

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120698022 --- Diff: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java --- @@ -296,13 +297,13 @@ public void process

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120699342 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java --- @@ -41,12 +41,26 @@ */ public abstract

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120699437 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java --- @@ -93,6 +107,12 @@ public void setContext

[GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...

2017-06-07 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r120700095 --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformers.java --- @@ -88,4 +89,11 @@ public boolean

[GitHub] lucene-solr pull request #204: SOLR-10710: Fix LTR contrib failures

2017-05-25 Thread diegoceccarelli
Github user diegoceccarelli closed the pull request at: https://github.com/apache/lucene-solr/pull/204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] lucene-solr pull request #202: SOLR-10703 DocTransformer implements Closeabl...

2017-09-17 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r139309859 --- Diff: solr/solrj/src/java/org/apache/solr/common/util/IOUtils.java --- @@ -31,7 +32,7 @@ public static void closeQuietly(Closeable closeable

[GitHub] lucene-solr issue #202: SOLR-10703 Add prepare and finish in DocTrasformer

2017-09-01 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/202 Thanks @dsmiley and @michaelbraun, I updated the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] lucene-solr issue #202: SOLR-10703 DocTransformer implements Closeable

2017-12-05 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/202 @tflobbe @m-khl ping :) --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e

[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

2018-05-02 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/162#discussion_r185490261 --- Diff: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java --- @@ -1414,10 +1267,17 @@ private void

[GitHub] lucene-solr pull request #296: SOLR-11804: Test RankQuery in distributed mod...

2017-12-29 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/296 SOLR-11804: Test RankQuery in distributed mode Currently `RankQuery` is not tested in distributed mode. I added a few tests in `TestDistributedSearch` to check that it works properly

[GitHub] lucene-solr pull request #320: LUCENE-8033: FieldInfos always use dense enco...

2018-02-12 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/320#discussion_r167671548 --- Diff: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java --- @@ -63,21 +62,30 @@ public FieldInfos(FieldInfo[] infos

[GitHub] lucene-solr pull request #320: LUCENE-8033: FieldInfos always use dense enco...

2018-02-11 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/320#discussion_r167441676 --- Diff: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java --- @@ -63,21 +62,30 @@ public FieldInfos(FieldInfo[] infos

[GitHub] lucene-solr pull request #292: Removed extra whitespace

2018-02-11 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/292#discussion_r167441568 --- Diff: solr/example/example-DIH/solr/solr/conf/solr-data-config.xml --- @@ -18,7 +18,7 @@ http://127.0.0.1:8983/solr

[GitHub] lucene-solr pull request #295: SOLR-11800: Improve error message when parsin...

2017-12-28 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/295 SOLR-11800: Improve error message when parsing RankQuery When a user specifies something wrong for the parameter `rq` sometimes it is hard to understand where is the problem

[GitHub] lucene-solr pull request #295: SOLR-11800: Improve error message when parsin...

2017-12-28 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/295#discussion_r158969387 --- Diff: solr/core/src/java/org/apache/solr/search/QParser.java --- @@ -360,6 +360,10 @@ public static QParser getParser(String qstr, String

[GitHub] lucene-solr pull request #293: spellcheck prefix already contains a trailing...

2018-01-01 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/293#discussion_r159154912 --- Diff: solr/core/src/java/org/apache/solr/handler/component/SpellCheckComponent.java --- @@ -339,7 +339,7 @@ private void

[GitHub] lucene-solr pull request #482: LUCENE-8539: fix some typos and improve style

2018-10-22 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/482 LUCENE-8539: fix some typos and improve style You can merge this pull request into a Git repository by running: $ git pull https://github.com/diegoceccarelli/lucene-solr LUCENE

[GitHub] lucene-solr issue #482: LUCENE-8539: fix some typos and improve style in Tes...

2018-11-23 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/482 Thanks @mikemccand, I added a new test case by splitting one that was testing two different things :) I rebased to the latest master, Is anything else I can do to get this merged

[GitHub] lucene-solr pull request #507: Update jira/gradle to the latest master

2018-11-25 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/507 Update jira/gradle to the latest master You can merge this pull request into a Git repository by running: $ git pull https://github.com/diegoceccarelli/lucene-solr jira/gradle

[GitHub] lucene-solr issue #494: ant compile error

2018-11-21 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/494 @cqvip-jq this looks like a problem on your side. Try to remove the `ivy2` cache by removing the `.ivy2/cache` folder in your home and then run `ant ivy-bootstrap` and `ant dist` from

[GitHub] lucene-solr issue #494: ant compile error

2018-11-21 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/494 `maven.restlet.org` gets redirected to `maven.restlet.com`, LGTM --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] lucene-solr issue #482: LUCENE-8539: fix some typos and improve style in Tes...

2018-11-27 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/482 Thanks @mikemccand, now precommit seems happy, I squashed and rebased to the latest master. --- - To unsubscribe

[GitHub] lucene-solr issue #494: ant compile error

2018-11-22 Thread diegoceccarelli
Github user diegoceccarelli commented on the issue: https://github.com/apache/lucene-solr/pull/494 Sorry @cqvip-jq my comment was misleading, I think you are right and your patch should be merged