Github user moshebla commented on the pull request:
https://github.com/apache/lucene-solr/commit/43d7f5d104802bc3281d5995c6c2d71bebf1f369#commitcomment-31114379
Perhaps a better name for it would be "isNestedUpdate".
This method checks whether the update chang
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/501
SOLR-5211
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-5211
Alternatively you can review and apply these
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234636103
--- Diff:
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
@@ -975,6 +976,14 @@ private void updateDocOrDocValues
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234639274
--- Diff:
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
@@ -975,6 +976,14 @@ private void updateDocOrDocValues
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234872041
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -194,20 +197,33 @@ public String getHashableId() {
return
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205960593
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205960639
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205961339
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205962085
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,227
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205965045
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r206034965
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java
---
@@ -168,35 +172,57 @@ private static
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r206184346
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r206846562
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/430
SOLR-12485: support labelled children in xml documents
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-12485
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207737277
--- Diff: solr/core/src/test/org/apache/solr/update/AddBlockUpdateTest.java
---
@@ -501,6 +501,73 @@ public void testXML() throws IOException
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207776740
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
---
@@ -404,6 +404,7 @@ public SolrInputDocument readDoc(XMLStreamReader
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/410
Closing this as it was merged.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e
Github user moshebla closed the pull request at:
https://github.com/apache/lucene-solr/pull/410
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207885809
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -118,16 +122,16 @@ public final static void writeUnescapedXML(Writer
out
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207892278
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
---
@@ -453,7 +454,12 @@ public SolrInputDocument readDoc(XMLStreamReader
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/430
Hopefully the new method names are clear enough.
I naming is not one of my strong points. :worried:
---
-
To
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207906914
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -208,7 +179,13 @@ public static void escape(String str, Writer out,
String
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/430#discussion_r207909827
--- Diff: solr/solrj/src/java/org/apache/solr/common/util/XML.java ---
@@ -101,83 +102,53 @@ public final static void writeXML(Writer out, String
tag
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223336215
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223355767
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223355907
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223359889
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r223741723
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
---
@@ -461,5 +466,33 @@ private static boolean
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r194245379
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -249,14 +251,27 @@ public void handle(Map record, String
path
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r194245516
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -668,7 +682,40 @@ private boolean isChildDoc(SolrInputDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r194245569
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -249,14 +251,27 @@ public void handle(Map record, String
path
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/395
Hopefully these new commits address the problems with the previous changes
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r194689072
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -668,7 +682,40 @@ private boolean isChildDoc(SolrInputDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r194690146
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -249,14 +251,27 @@ public void handle(Map record, String
path
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/395
Tried tackling the javadoc references, as I'm fairly new this I hope I
didn't mess it up too badly.
---
-
To u
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195093742
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -703,6 +703,10 @@ private SolrInputDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195098134
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -570,37 +573,34 @@ private SolrInputDocument parseDoc(int ev
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195118056
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -703,6 +703,10 @@ private SolrInputDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195118329
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -593,14 +602,14 @@ private void parseExtendedFieldValue(int ev
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195122269
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -703,6 +703,10 @@ private SolrInputDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195131919
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -703,6 +703,10 @@ private SolrInputDocument
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/395
Skimmed through, making some last minute changes.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234882621
--- Diff:
solr/core/src/test/org/apache/solr/search/TestPseudoReturnFields.java ---
@@ -126,7 +126,7 @@ public void testAllRealFields() throws
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234882891
--- Diff: solr/core/src/test/org/apache/solr/search/TestReload.java ---
@@ -36,13 +36,13 @@ public void testGetRealtimeReload() throws Exception
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235012194
--- Diff: solr/core/src/test/org/apache/solr/BlockUpdateTest.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235247891
--- Diff: solr/core/src/test/org/apache/solr/BlockUpdateTest.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r235613814
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TestCloudPseudoReturnFields.java ---
@@ -194,7 +194,7 @@ public void testAllRealFields() throws
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r236074413
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TestRandomFlRTGCloud.java ---
@@ -70,6 +70,9 @@
/** Always included in fl so we can
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/455
I rebased using the latest master.
I also changed the tests so _root_ is not hard-coded into childless
documents, since SOLR-5211 was committed to master and ensures this behaviour
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r237364758
--- Diff:
solr/core/src/test/org/apache/solr/cloud/AtomicUpdateBlockShardedTest.java ---
@@ -130,7 +130,7 @@ public void doNestedInplaceUpdateTest
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r226858107
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateBlockTest.java
---
@@ -59,39 +52,147 @@ public void before
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228032204
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -262,6 +263,11 @@ private void flattenAnonymous(List
unwrappedDocs
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/455#discussion_r228734114
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
---
@@ -609,9 +618,11 @@ public static SolrInputDocument
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/455
Currently the following update operations are supported for child documents:
- add
- set
- remove
---
-
To
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204227753
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformerFactory.java
---
@@ -0,0 +1,367
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204227785
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildTransformerBase.java
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204227797
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformerFactory.java
---
@@ -0,0 +1,367
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
This is only a start, I will merge this into the main
ChildDocTransformerFactory.
This new algorithm is simpler, just like you suggested, although it
contains a few minor implementation
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
In my implementation I have used a Multimap for the
pending data, so we can decide if we put the number in the array of the
parent's key. That way, There can be an option to add all paren
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I was referring to the '#2'.
Imagine a query for a social network, where all the posts comments made by
a specific user are required, including the ones he commented on, which
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I will push another commit soon.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
Sure thing it won't mix up the comments, but what if the user also requests
all the comments which in the same thread, thus being in the same array just a
path
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
OK, We'll scratch that for now, and discuss this in a separate issue.
---
-
To unsubscribe, e-mail: dev-uns
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I found this nasty bug in
[AtomicUpdateDocumentMerger#isAtomicUpdate](https://github.com/apache/lucene-solr/pull/416/commits/7cd1dbc3208746541bd80f2d2656b6464fecd23d#diff
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I added a new test
[TestDeeplyNestedChildDocTransformer#testSingularChildFilterJSON](https://github.com/apache/lucene-solr/pull/416/commits/df77f5b9cd32fdd2d607d8e705481e8f17544ae7#diff
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204774918
--- Diff: solr/core/src/test-files/solr/collection1/conf/schema15.xml ---
@@ -567,7 +567,17 @@
-
+
--- End diff
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204775739
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204776145
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -70,7 +78,8 @@ public DocTransformer create
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204777468
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -61,6 +65,10 @@
*/
public class
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204785508
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204802880
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204813287
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205062754
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205087092
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I tried optimizing the lookup and insertion of child documents.
Hopefully I'll get more time tomorrow to get the tests up to sc
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205123592
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -190,8 +179,18 @@ private String
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205124868
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -132,54 +126,49 @@ public void transform
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205125247
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -67,7 +73,9 @@
public static
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205403130
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,163
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r199773120
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/NestedUpdateProcessor.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r200115050
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/NestedUpdateProcessor.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r200233243
--- Diff: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ---
@@ -107,6 +107,8 @@
public static final String
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r200233323
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r200829771
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/NestedUpdateProcessorFactory.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r200996646
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/NestedUpdateProcessorFactory.java
---
@@ -72,8 +72,8 @@ public void processAdd
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r201059845
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/410#discussion_r201222488
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -120,25 +122,41 @@ public void before() throws Exception
GitHub user moshebla opened a pull request:
https://github.com/apache/lucene-solr/pull/416
WIP: SOLR-12519
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moshebla/lucene-solr SOLR-12519-3
Alternatively you can review and apply
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214531907
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -131,6 +131,12 @@ public void transform(SolrDocument
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
BTW, I was skimming through DocTransformer, and noticed
DocTransformer#needsSolrIndexSearcher.
Shouldn't this return true for ChildDocTransformer, since it searches the
docId provid
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214569119
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java ---
@@ -114,4 +114,27 @@ public void transform(SolrDocument doc
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214569199
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java ---
@@ -1831,7 +1831,7 @@ public void testChildDoctransformer
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214573620
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java ---
@@ -1831,7 +1831,7 @@ public void testChildDoctransformer
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214892512
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -132,6 +134,12 @@ public void transform(SolrDocument
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
Pushed a commit ensuring the context is set for child transformers only if
it was not set previously.
---
-
To unsubscribe
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/443
Closing this PR as it was committed to master in commit
e4f256be15ca44f12a4aecb32c13d1ab2617cc00
---
-
To unsubscribe, e
Github user moshebla closed the pull request at:
https://github.com/apache/lucene-solr/pull/443
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211108109
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
---
@@ -87,7 +87,12 @@ public void transform(SolrDocument
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211495503
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211505124
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -264,7 +309,7 @@ private static Object
1 - 100 of 191 matches
Mail list logo
