[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830524#comment-16830524 ] ASF subversion and git services commented on LUCENE-8738: - Commit 87c16882ae3606efd1ff88fd369ca964685d3ae9 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=87c1688 ] LUCENE-8738, LUCENE-8786: Fix ECJ linter to accept Java 11 syntax > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822704#comment-16822704 ] Uwe Schindler commented on LUCENE-8738: --- JDK issue: https://bugs.openjdk.java.net/browse/JDK-8222793 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822682#comment-16822682 ] Tomoko Uchida commented on LUCENE-8738: --- I pushed the change to master and branch_8x. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822681#comment-16822681 ] ASF subversion and git services commented on LUCENE-8738: - Commit 2e3a81a8882ca6627c91254a991703910adadf6f in lucene-solr's branch refs/heads/branch_8x from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2e3a81a ] LUCENE-8738: Force locale to be 'en_US' in javadocs task. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822680#comment-16822680 ] ASF subversion and git services commented on LUCENE-8738: - Commit 1204327b56b114d980ad2ca4706c43e01faff6d9 in lucene-solr's branch refs/heads/master from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1204327 ] LUCENE-8738: Force locale to be 'en_US' in javadocs task. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822664#comment-16822664 ] Uwe Schindler commented on LUCENE-8738: --- bq. Can I commit it to the master branch? Go ahead! > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822661#comment-16822661 ] Uwe Schindler commented on LUCENE-8738: --- I opened https://bugs.openjdk.java.net/browse/JDK-8222791 about the split packages problem. [~Tomoko Uchida]: Can you give a detailed description how the Javadocs are broken with Japanese Locale? I'll open a bug report in JDK. Just send me an email with the text and reproduce line (ideally without lucene) and whats exactly wrong in the mail. I'll copypaste into the issue. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822659#comment-16822659 ] Tomoko Uchida commented on LUCENE-8738: --- I attached a patch: [^LUCENE-8738-javadoc-locale-en-US.patch] , this adds "" to the javadocs macro. Can I commit it to the master branch? > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-javadoc-locale-en-US.patch, > LUCENE-8738-solr-CoreCloseListener.patch, LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822653#comment-16822653 ] Uwe Schindler commented on LUCENE-8738: --- The hack Paramus are fine, but don't put them into doclint params, as those are different for Solr. The correct place is to put it into the "arg line" in the javadocs macro. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822646#comment-16822646
]
Tomoko Uchida commented on LUCENE-8738:
---
Locale-spacific failure report:
After checking out master branch, {{ant precommit}} fails on my PC (fedora
linux) with this error.
{code:java}
-documentation-lint:
[echo] checking for broken html...
[jtidy] FIXME: Broken HTML checks were disabled, as jtidy can't handle
HTML5.
[echo] Checking for broken links...
[exec]
[exec] Crawl/parse...
[exec]
[exec] Verify...
[echo] Checking for missing docs...
[exec] Traceback (most recent call last):
[exec] File
"/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 387, in
[exec] if checkPackageSummaries(sys.argv[1], level):
[exec] File
"/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 361, in
checkPackageSummaries
[exec] if (level == 'class' or level == 'method') and
checkSummary('%s/package-summary.html' % dirPath):
[exec] File
"/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 311, in
checkSummary
[exec] raise RuntimeError('BUG: failed to locate description in %s' %
fullPath)
[exec] RuntimeError: BUG: failed to locate description in
build/docs/analyzers-kuromoji/org/apache/lucene/analysis/ja/package-summary.html
BUILD FAILED
{code}
As far as I found, seems JDK11's {{javadoc}} tool ignores the "-locale en_US"
parameter (on both of fedora linux and windows) and Javadocs is generated with
default locale (in my case, "ja_JP") by ant {{documentation}} target, so the
python linter failed.
I use JDK 11.0.2.
{code}
java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.2+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.2+9, mixed mode)
{code}
And this (dirty) patch works for me anyway...
{code:xml}
--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
@@ -184,7 +184,7 @@
-
+
{code}
> Bump minimum Java version requirement to 11
> ---
>
> Key: LUCENE-8738
> URL: https://issues.apache.org/jira/browse/LUCENE-8738
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Minor
> Labels: Java11
> Fix For: master (9.0)
>
> Attachments: LUCENE-8738-solr-CoreCloseListener.patch,
> LUCENE-8738.patch
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822286#comment-16822286 ] ASF subversion and git services commented on LUCENE-8738: - Commit 5aaa923e360bc5c670230445bb710d07ba4a4655 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5aaa923 ] LUCENE-8738, SOLR-13400: Remove obsolete changes entry (replaced by SOLR-13400) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822244#comment-16822244 ] ASF subversion and git services commented on LUCENE-8738: - Commit 3881b6df623bdce551d5c8befd366982c855c964 in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3881b6d ] Backport of Java 11 change (LUCENE-8738): Add missing dependency for Maven build > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822243#comment-16822243 ] ASF subversion and git services commented on LUCENE-8738: - Commit 77e1bec7dcc4641457dc161ddf5c55d73c85fb78 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=77e1bec ] LUCENE-8738: Add missing dependency for Maven build > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1683#comment-1683 ] ASF subversion and git services commented on LUCENE-8738: - Commit f491369b4b27af7688c506ada4e7330a0c918a5a in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f491369 ] Backport of Java 11 change (LUCENE-8738): Update Groovy to make the warnings with Java 11 a bit more silent (only one warning on first Groovy invocation) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822217#comment-16822217 ] ASF subversion and git services commented on LUCENE-8738: - Commit b8494c8702c84c0085f1382d7fa25c1848daf115 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b8494c8 ] LUCENE-8738: Update Groovy to make the warnings with Java 11 a bit more silent (only one warning on first Groovy invocation) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819884#comment-16819884 ] ASF subversion and git services commented on LUCENE-8738: - Commit fb28958bc8cdec0ac20968222b03de7aed384032 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=fb28958 ] LUCENE-8738: Add Java 11 under "Getting Started" in CHANGES.txt > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818930#comment-16818930 ] ASF subversion and git services commented on LUCENE-8738: - Commit faaee86efb01fa6e431fcb129cfb956c7d62d514 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=faaee86 ] LUCENE-8738: Move to Java 11 as minimum Java version (merged branch: jira/LUCENE-8738) Co-authored-by: Adrien Grand > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818929#comment-16818929 ] ASF subversion and git services commented on LUCENE-8738: - Commit faaee86efb01fa6e431fcb129cfb956c7d62d514 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=faaee86 ] LUCENE-8738: Move to Java 11 as minimum Java version (merged branch: jira/LUCENE-8738) Co-authored-by: Adrien Grand > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818450#comment-16818450 ] ASF subversion and git services commented on LUCENE-8738: - Commit ddd0bdcd876495ab2c3cc9bbf7b6648728af5be1 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ddd0bdc ] LUCENE-8738: Some missing documentation updates > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Assignee: Uwe Schindler >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818435#comment-16818435 ] Uwe Schindler commented on LUCENE-8738: --- As noted on mailinglist, I will squash-merge this branch to master tomorrow, 2019-04-16 at 12:00 UTC. I will not delete this branch and keep it for reference (so commits can be reviewed). > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818434#comment-16818434 ] Uwe Schindler commented on LUCENE-8738: --- Here is the final patch for the Java 11 change: [^LUCENE-8738.patch] > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch, > LUCENE-8738.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818330#comment-16818330 ] Uwe Schindler commented on LUCENE-8738: --- Solr is not affected. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818329#comment-16818329 ] ASF subversion and git services commented on LUCENE-8738: - Commit d22a67fee534f109418df45e5a167b39ecf8e752 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d22a67f ] LUCENE-8738: Fix Javadoc 11.0.2+ bug with split packages by filtering them in module's "element-list" files > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818328#comment-16818328
]
Uwe Schindler commented on LUCENE-8738:
---
OK, Solr is not affected, so I will commit my hotfix for Lucene's
module-build.xml only:
{code:xml}
diff --git a/lucene/module-build.xml b/lucene/module-build.xml
index 2853efb..e73f0fc 100644
--- a/lucene/module-build.xml
+++ b/lucene/module-build.xml
@@ -83,6 +83,20 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
{code}
> Bump minimum Java version requirement to 11
> ---
>
> Key: LUCENE-8738
> URL: https://issues.apache.org/jira/browse/LUCENE-8738
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
>Reporter: Adrien Grand
>Priority: Minor
> Labels: Java11
> Fix For: master (9.0)
>
> Attachments: LUCENE-8738-solr-CoreCloseListener.patch
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818250#comment-16818250
]
Uwe Schindler commented on LUCENE-8738:
---
My quick test fixed the issue (for Lucene):
{code:xml}
diff --git a/lucene/module-build.xml b/lucene/module-build.xml
index 2853efb..29c639c 100644
--- a/lucene/module-build.xml
+++ b/lucene/module-build.xml
@@ -83,6 +83,10 @@
+
+
+
+
{code}
I just need to make the regex more dynamic
> Bump minimum Java version requirement to 11
> ---
>
> Key: LUCENE-8738
> URL: https://issues.apache.org/jira/browse/LUCENE-8738
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
>Reporter: Adrien Grand
>Priority: Minor
> Labels: Java11
> Fix For: master (9.0)
>
> Attachments: LUCENE-8738-solr-CoreCloseListener.patch
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818207#comment-16818207 ] Adrien Grand commented on LUCENE-8738: -- +1 on the suggested short-term workaround > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818198#comment-16818198 ] Uwe Schindler commented on LUCENE-8738: --- bq. I am now running Jenkins with 11 GA to verify my observation. Confirmed. So the bug is as described. Depending on Java 11 bugfix version the Javadcos are broken (Java 11.0.2 or later) or not (Java 11 or 11.0.1). Dumb. So I am working on the workaround and testing locally with 2 different JDKs. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818181#comment-16818181 ] Uwe Schindler commented on LUCENE-8738: --- While cycling home and thinking about the problem, I have an idea how to fix it: The problem mostly occurs when stuff wants to refer from a module to lucene-core (at in the errors above). As duplicate packages are a bad thing and also in previous versions it was not fully working correctly (e.g., referals to other modules were not working we avoided those), I'd suggest to patch all module "package-list / element-list" files and just remove the common packages from them. I'd just add a "grep" ant task after buildinmg javadocs, that removes all the common ones like "org.apache.lucene.search" packages from all module list files (just emulating what previous Javadocs did). This should fix the issue. But we should rellay work on modularizing lucene, so we have to remove duplicate/split packages anyways. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818173#comment-16818173 ] Uwe Schindler commented on LUCENE-8738: --- At least smoke tester on ASF Jenkins with Java 11.0.1 does not fail: https://builds.apache.org/view/L/view/Lucene/job/Lucene-Solr-SmokeRelease-master11/3/consoleText > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818107#comment-16818107 ] Uwe Schindler commented on LUCENE-8738: --- I am now running Jenkins with 11 GA to verify my observation. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818106#comment-16818106
]
Uwe Schindler commented on LUCENE-8738:
---
Actually this is a bug in Java 11.0.2, introduced in the 2nd minor bugfix and
affects all versions after.
This is the reason why Smoketester on ASF Jenkins works (it uses Java 11.0.1)
and why the Javadocs are produced correctly on my local machine (original Java
11 GA). In Java 11.0.2 they refactored some code in order to get cross-module
links work correct. See https://bugs.openjdk.java.net/browse/JDK-8205593
(backported to 11.0.2).
The bug is the following: Lucene has duplicate package names (e.g., the
analysis module has standardanalyzer, but also the core module). Here the order
of "link" elements when calling Javadocs matters, because the package names are
searched in that order (so earlier package name wins). Before the Javadocs
bugfix in Java 11.0.2 it built an internal map with package name -> directory
(based on the package-names files). Before they ported it to modules they built
the map by reading all the packages-files, checking if package is already in
map and add it then. By that "first-wins" (it's only inserted when seen for
first time). After the Javadocs patch, they containKey() was removed and all
packages are added to map, so "last-wins". Because of that when building Lucene
Javadocs, the last entry in the {{}} ANT element wins.
Before: http://hg.openjdk.java.net/jdk/jdk/rev/f7d40158eb2f#l7.60 (see
!containsKey)
After: http://hg.openjdk.java.net/jdk/jdk/rev/f7d40158eb2f#l7.196 (see the put
at end, so if same package in same Jigsaw module "unnamed", its overwritten and
so latest item wins)
So that means all of Lucene's Javadocs are broken after Java 11.0.2
[~jpountz]: How should we proceed? I dont want to stop the merge now, maybe
just dsiable the link checking for now?
> Bump minimum Java version requirement to 11
> ---
>
> Key: LUCENE-8738
> URL: https://issues.apache.org/jira/browse/LUCENE-8738
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
>Reporter: Adrien Grand
>Priority: Minor
> Labels: Java11
> Fix For: master (9.0)
>
> Attachments: LUCENE-8738-solr-CoreCloseListener.patch
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818030#comment-16818030 ] Uwe Schindler commented on LUCENE-8738: --- I figured out: The complaints are real, the links are indeed dead. It looks like this comes from the fact that Java 11 javadoc somehow uses the package name to look for the correct external link and this breaks for common packages like oal.analysis.standard, which appears in multiple JAR files. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818017#comment-16818017 ] Uwe Schindler commented on LUCENE-8738: --- [~jpountz]: Were you able to run "ant documentat-lint"? This fails for some reason on Jenkins: https://jenkins.thetaphi.de/job/Lucene-Solr-master11-Linux/8/console It complains about broken links. Interestingly it succeeds on Smoke tester! > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817937#comment-16817937 ] ASF subversion and git services commented on LUCENE-8738: - Commit b2899e45a9ef3ec84c3e717c8d169fe86a7d43e5 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b2899e4 ] LUCENE-8738: Fix exception handling as Class#newInstance has thrown different Exception > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817897#comment-16817897 ] ASF subversion and git services commented on LUCENE-8738: - Commit 02a255ff68b51b8213cac4622b7ed863037492e2 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=02a255f ] LUCENE-8738: Update Jacoco for Java 11 support (does not yet work due to SecurityManager) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817898#comment-16817898 ] ASF subversion and git services commented on LUCENE-8738: - Commit 2ae7c8d2b8f874abb0b54be611d2be1f5c06ef5a in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2ae7c8d ] LUCENE-8738: Fix smoketester target to support Java 12 (ant target dependency was missing) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817850#comment-16817850 ] ASF subversion and git services commented on LUCENE-8738: - Commit eece619111f8334248346513fb1b7766f21fef74 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=eece619 ] LUCENE-8738: Downgrade Maven Surefire back to 2.17 (see LUCENE-8146), still works with Java 11 and Maven 3.5+ > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817837#comment-16817837 ] ASF subversion and git services commented on LUCENE-8738: - Commit 8af266227de26cb9de98bf5f1eea42efb7d04471 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8af2662 ] LUCENE-8738: Fix Luke deprecations > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817834#comment-16817834 ] ASF subversion and git services commented on LUCENE-8738: - Commit abb2d02f1cd9482d0644ab8bc61fb2f6549e1997 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=abb2d02 ] Merge branch 'master' of https://gitbox.apache.org/repos/asf/lucene-solr into jira/LUCENE-8738 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817665#comment-16817665 ] Adrien Grand commented on LUCENE-8738: -- Feel free to send it, +1 for tomorrow CEST. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817629#comment-16817629 ] Uwe Schindler commented on LUCENE-8738: --- Will you send the email or should I do it? I will propose to switch tomorrow afternoon CEST. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817616#comment-16817616 ] Adrien Grand commented on LUCENE-8738: -- Thanks Uwe. Sorry for the late reply, +1 to send an email to dev@ to warn about this upcoming change. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817132#comment-16817132 ] Uwe Schindler commented on LUCENE-8738: --- I fixed the Maven build, seems to works now (excluding tests, dont work yet - but that's the same on master). > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817124#comment-16817124 ] ASF subversion and git services commented on LUCENE-8738: - Commit e5f733d74bdac4d15f2e989fab0fbbf5ba0da0d8 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e5f733d ] Merge branch 'master' of https://gitbox.apache.org/repos/asf/lucene-solr into jira/LUCENE-8738 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817113#comment-16817113 ] ASF subversion and git services commented on LUCENE-8738: - Commit e23fd230a0dedf80ea94b9e2f32f1b9b3c122122 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e23fd23 ] LUCENE-8738: Update Maven build > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817079#comment-16817079 ] Uwe Schindler commented on LUCENE-8738: --- In the meantime I updated all Jenkins jobs on Policeman Jenkins and ASF Jenkins to user Java 11+ on master. I disabled all jobs, which wont work yet (Clover and Maven). So we can merge the branch without breaking Jenkins. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817078#comment-16817078 ] Uwe Schindler commented on LUCENE-8738: --- The Maven builds are not yet working, as we have to raise minimum Maven version and also update some (many) plugins. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817060#comment-16817060 ] ASF subversion and git services commented on LUCENE-8738: - Commit 831e940e02305eef6d99799bc1ba52e62d7190f5 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=831e940 ] LUCENE-8738, LUCENE-8763: Disable OpenClover until a release with Java 11 support is available > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817058#comment-16817058 ] Uwe Schindler commented on LUCENE-8738: --- I just figured out: OpenClover has no release yet with Java 11. I opened a new issue: LUCENE-8763 For now I will disable the task an Jenkins jobs using Clover. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816914#comment-16816914 ] Uwe Schindler commented on LUCENE-8738: --- I'd suggest to somehow coordinate that change, because we have to update Jenkins jobs. I already created the scripts on Policeman Jenkins that uses Java 11 or later only during randomization. I just have to update the jobs. How about sending a warning message to all commiters and give some date/time for the change? E.g., Monday afternoon 15:00 CEST? > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816877#comment-16816877 ] Uwe Schindler commented on LUCENE-8738: --- I think we can merge this branch. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816875#comment-16816875 ] Uwe Schindler commented on LUCENE-8738: --- I opened SOLR-13400. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816870#comment-16816870 ] ASF subversion and git services commented on LUCENE-8738: - Commit 13f8d1ead9fbc6ecb2206813284b8c08d1f37995 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=13f8d1e ] LUCENE-8738: Port TransientSolrCoreCache observer pattern to Java 11 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816867#comment-16816867 ] Uwe Schindler commented on LUCENE-8738: --- OK, so I will commit this to the Java 11 branch, so we are in-line with Java 8. Everything else should be done in a separate JIRA issue. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816623#comment-16816623 ] Erick Erickson commented on LUCENE-8738: Been a busy couple of days, sorry I didn't get back to this sooner. This change looks good. As far as simplifying... well, I have to hop in the "way back" machine so it's fuzzy. I'll try to loop in someone who worked on a custom impl. The critical bit is that over in SolrCores, there has to be synchronization around updating "pendingCloses", and those sync methods shouldn't be exposed to the impl. I don't think there's any good way for the transient impl to _get_ the solrCores object from CoreContainer (which it does have), and I don't think exposing solrCores for just this is a good idea. So I hit on the Observer pattern as an "end around" that problem and once it worked never went back and thought about it again. Looking at it with fresh eyes, though, it seems like adding the queueCoreClose to coreContainer which _does_ have access to the solrCores object and can do anything it wants with it in a controlled manner would solve that problem much more simply. And the transient impl has access to coreContainer so. So AFAIC, let's rip the complexity out and replace it with a call. I agree that doing that in a separate Jira is a good thing. But let's wait a bit to see if I can loop in people who are living with the current setup. Thanks for your work here! Erick > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816220#comment-16816220 ] Uwe Schindler commented on LUCENE-8738: --- Cleaning up can be done later, the current patch just restores the Lucene 8 behaviour. If we change it and remove the observer pattern, it should be done also in 8.1 or 8.2. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816215#comment-16816215 ] Uwe Schindler commented on LUCENE-8738: --- But as a first step the patch seem fine, as it does exactly the same as before (from its logic) - just typesafe? > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816072#comment-16816072 ] Adrien Grand commented on LUCENE-8738: -- Agreed it would be simpler to just call queueCoreClose() from the impl, though I might be missing some reasons why it's designed this way today. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816009#comment-16816009 ] Uwe Schindler commented on LUCENE-8738: --- any comments? > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815128#comment-16815128 ] Uwe Schindler commented on LUCENE-8738: --- Hi [~erickerickson], [~ysee...@gmail.com]: I changed the stuff using the listeners with obersver pattern to be more useable. Here is the patch (to current branch code): [^LUCENE-8738-solr-CoreCloseListener.patch] Basically this somehow restores the same pattern like before, but type safe. The problem with Adriens approach was, that any subclass of the default implementation was not able to interact with the container. The reason was the private "pcs" field. Also it was "knowledge" needed how to execatly send the notifications. This patch adds in the abstract base class the notification algorithm. Instead of TransientSolrCoreCache extending Observable, this adds the important methods as protected final methods (so it basically behaves like the one before, just method names are different). This has its internal PropertyChangeSupport as an implementation detail. Using the three methods you can register a CoreCloseListener (a new interface extening PropertyChangeListener, but type-safe), notify the listeners and finally remove the listener. SolrCores implements the new interface. It should be super-easy to rewrite old code: just replace the method name, as shown in the javadocs. If you agree that this is better, I will commit it to the branch and add Javadocs at "breaking changes". Nevertheless, I still thing the whole Obersver/Observable pattern is "overengineered": With the current default implementation there is only ever ONE listener added (SolrCores) and when notifying it, it just calls its method. So maybe the whole thing can be done much easier by just calling "SolrCores.queueCoreClose()" from the implementation directly... Uwe > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > Attachments: LUCENE-8738-solr-CoreCloseListener.patch > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814907#comment-16814907 ] Uwe Schindler commented on LUCENE-8738: --- It only looks like I can't run tests in Eclipse. It says that no test cases were found. I will dig into this. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814869#comment-16814869 ] Uwe Schindler commented on LUCENE-8738: --- bq. Uwe Schindler I tested Eclipse indeed. I only had issue with MockInitialContextFactory, Eclipse complains that it tries to access classes from a module it doesn't have access to. Tested Eclipse 2019-03: Works fine. Just configure your Java 11 OpenJDK location and all works automatically. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814857#comment-16814857 ] Uwe Schindler commented on LUCENE-8738: --- Hi, I looked a bit more on the Observer code. I think we should add type safe method to the abstract superclass and change the java documentation. Because currently without knowing what SolrCores internaly does, its impossible to do it right. I think I will add a method to register, deregister and to notify to the abstract TransientCoreCache impl. This is in line with the current Observerable superclass. Alternatively we need to change the Javadocs of TransientSolrCoreCache (we need to adapt anyways). I am looking for a more "type safe" way to do this. [~erickerickson]: what do you think? > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814823#comment-16814823 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] I tested Eclipse indeed. I only had issue with MockInitialContextFactory, Eclipse complains that it tries to access classes from a module it doesn't have access to. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814781#comment-16814781 ] Erick Erickson commented on LUCENE-8738: LGTM. The point of that code was to allow any custom transient cache implementation to "reach back" into CoreContainer to notify when a core should be closed. There's a bunch of synchronization that needs to be done for that process and it looks like when people go to 9.0 they'll have to model on these changes, which should be straightforward. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814754#comment-16814754 ] Uwe Schindler commented on LUCENE-8738: --- The code seems to be updated like described here: https://www.baeldung.com/java-observer-pattern > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814705#comment-16814705 ] Yonik Seeley commented on LUCENE-8738: -- bq. I think the Observable/Observer is uncritical. I agree. Pluggable transient core cache is super-expert level (almost more like internals) and if anyone actually uses it they can adapt when upgrading. I did a quick scan of the related changes and they look fine. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814684#comment-16814684 ] Uwe Schindler commented on LUCENE-8738: --- I checked the Observer/Observable stuff, it's related to SOLR-8906. I will put [~erickerickson] into the loop, he may know more. It was not Yonik. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814664#comment-16814664 ] Uwe Schindler commented on LUCENE-8738: --- I think the Observable/Observer is uncritical. It exists in Solr since early beginning, but for no reason. But I'd also ask the specialists, especially [~yo...@apache.org]. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814653#comment-16814653 ] Uwe Schindler commented on LUCENE-8738: --- OK, fixed SOLR-13388 in master/8.x > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814651#comment-16814651 ] ASF subversion and git services commented on LUCENE-8738: - Commit 5d778dee4131bd55a483eaeb9e040d771a54020d in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5d778de ] Merge branch 'master' of https://gitbox.apache.org/repos/asf/lucene-solr into jira/LUCENE-8738 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814607#comment-16814607 ] Uwe Schindler commented on LUCENE-8738: --- See SOLR-13388 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814597#comment-16814597 ] Uwe Schindler commented on LUCENE-8738: --- I checked the code: FileExchangeRateProvider should really be public! I'll open an issue for 8.x > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814591#comment-16814591 ] Uwe Schindler commented on LUCENE-8738: --- I don't see anything that needs to be done before. I had not yet tested Eclipse config, did you do this? For Java 11 work I have to first update my main Eclipse installation (ARGH). You did not write "untested" so I think you did it. When we merge to master, we should do this in some coordinated way, as Apache Jenkins and Policeman Jenkins need update of configs. Not sure about other Jenkins servers around. The FileExchangeRateProvider thing is strange, it worked before as the package names were somehow correct, but that's a bug anyways if it appears in some solr config but it's not a public class! So that's a nice find, we should at least backport the "public" part to 8.x - as it's a bug! > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814577#comment-16814577 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] Do you know what still needs to be done before merging back to master? When we are done, ore close to being done, I plan to send an email to the list to ask for some more eyes on changes that I did before merging, especially the Observable/Observer removal. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814554#comment-16814554 ] ASF subversion and git services commented on LUCENE-8738: - Commit cfe959b81458bac06f1ad5d8161e59adb85b87b2 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cfe959b ] LUCENE-8738: Update Eclipse config. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814555#comment-16814555 ] ASF subversion and git services commented on LUCENE-8738: - Commit a11c3974b9e6b80b7b566bc1cd8b08c5d1db8a6b in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a11c397 ] LUCENE-8738: Update Idea configuration (untested). > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814556#comment-16814556 ] ASF subversion and git services commented on LUCENE-8738: - Commit 65ddd311288411e9dd56fd05e69a1a68c64a84ea in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=65ddd31 ] LUCENE-8738: Use getConstructor instead of getDeclaredConstructor. I had to make FileExchangeRateProvider public. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814486#comment-16814486 ] ASF subversion and git services commented on LUCENE-8738: - Commit d13874a0da37732c90cb764b8f9165bfeb8713da in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d13874a ] Merge branch 'master' of https://gitbox.apache.org/repos/asf/lucene-solr into jira/LUCENE-8738 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814343#comment-16814343 ] Uwe Schindler commented on LUCENE-8738: --- After Luke was included into Lucene I just pushed some Java 11 specific cleanup that I had on my todo list already while reviewing and improving [~Tomoko Uchida]'s code. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814339#comment-16814339 ] ASF subversion and git services commented on LUCENE-8738: - Commit 62294cfd7130c14d0abb641059e92eedf17876ea in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=62294cf ] Merge branch 'master' of https://gitbox.apache.org/repos/asf/lucene-solr into jira/LUCENE-8738 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814340#comment-16814340 ] ASF subversion and git services commented on LUCENE-8738: - Commit ebd235c765aa70d2a7ef5b380f7a8fc35d9803a8 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ebd235c ] LUCENE-8738: Remove TODOs about Java 11 (charsets in Luke) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813590#comment-16813590 ] Uwe Schindler commented on LUCENE-8738: --- Sorry, forget about it. I will try to fix it in 8.x branch in a separate issue. The problem is: - If you have branch 8.x checked out (or the current master still on java 8) and you build the javadocs with Java 8, all works fine. - If you then switch without "ant clean" to Java 11 and rebuild code/javadocs, it fails, as the Java 11 javadocs tool looks for the new package-list name when referring to other Lucene modules. So my wish would be to make javadoc tool in Lucene 8.x produce the same package-list files on all JVMs. If you compile and build javadocs on Lucene 8.x with Java 11 it produces element-list and fails. But that's more an issue of 8.x only. This issue was getting on my nerves yesterday. But sorry for the hassle here, it just looked like the same problem... > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813565#comment-16813565 ] Adrien Grand commented on LUCENE-8738: -- Sorry Uwe, I don't understand what you are suggesting. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813553#comment-16813553 ] ASF subversion and git services commented on LUCENE-8738: - Commit 744b375f2739112ca8326e036839f0b283065aba in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=744b375 ] LUCENE-8738: Make documentation-lint pass. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813517#comment-16813517 ] Uwe Schindler commented on LUCENE-8738: --- bq. Ok, maybe we should do the same on 8.x, so switching branches and jvms don't bring you trouble all the time. Sorry this does not affcet 8.x as it's about the downloaded files from the Oracle web page. The issue I am talking about is the same for cross module references inside Lucene. If you compile in Lucene 8.x it produces files with a different name in Java 8 or Java 11. So if you switch JDKs while working, you get errors. Maybe we can also tell javac to produce the output files with a consistent name. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813461#comment-16813461 ] Uwe Schindler commented on LUCENE-8738: --- Ok, maybe we should do the same on 8.x, so switching branches and jvms don't bring you trouble all the time. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813448#comment-16813448 ] ASF subversion and git services commented on LUCENE-8738: - Commit 541b77afe78b08190fbb8bfa2e091862d9ff08c8 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=541b77a ] LUCENE-8738: Keep the file called package-list locally to make links work. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813445#comment-16813445 ] Adrien Grand commented on LUCENE-8738: -- Apparently the issue can be worked around by calling the file package-list locally, even though it is supposed to be called element-list with the move to modules. I'll push a fix shortly. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813426#comment-16813426 ] Uwe Schindler commented on LUCENE-8738: --- bq. There seems to be issues with links to the standard API. I wonder that it might be related to the move from package-list to element-list. I have seen this, too, javadocs builds break with a warning message and then it fails build. Is this what you are seeing? The problem only occurs if you have mixed javadoc builds. It helps to "ant clean" from root folder and start from scratch. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813428#comment-16813428 ] Uwe Schindler commented on LUCENE-8738: --- (this issue always existed also in Java 8 vs. Java 11 on current master branch) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813352#comment-16813352 ] ASF subversion and git services commented on LUCENE-8738: - Commit e410a35e8cd49415ee4460266afa3d1eba65371e in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e410a35 ] Merge branch 'master' into jira/LUCENE-8738 > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813346#comment-16813346 ] Adrien Grand commented on LUCENE-8738: -- There seems to be issues with links to the standard API. I wonder that it might be related to the move from package-list to element-list. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809596#comment-16809596 ] ASF subversion and git services commented on LUCENE-8738: - Commit 9d8d69c1fd6725747379214abfd6e4554a49ec28 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9d8d69c ] LUCENE-8738: Remove Java 8 unmapping. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808610#comment-16808610 ] Adrien Grand commented on LUCENE-8738: -- +1 The other part that needs reviews is the replacement of Observable/Observer with utility classes from java.beans. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[
https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808555#comment-16808555
]
Uwe Schindler commented on LUCENE-8738:
---
I have some comment about the deprecation removal:
The {{Class#newInstance()}} stuff was replaced by
{{clazz.getDeclaredConstructor().newInstance()}}. This is perfectly fine and
also suggested in the deprecation notice. But I'd like to use
{{getConstructor()}} instead, as we are only interested in "public"
constructors.
We should also think about the fact that the code may now throw different
exceptions. About the changes [~jpountz] did: Most code ways already wrapped
with a general catch-all code, but maybe we can improve and unwrap runtime
excetions from the InvocationTargetException. I will have a closer look again.
> Bump minimum Java version requirement to 11
> ---
>
> Key: LUCENE-8738
> URL: https://issues.apache.org/jira/browse/LUCENE-8738
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
>Reporter: Adrien Grand
>Priority: Minor
> Labels: Java11
> Fix For: master (9.0)
>
>
> See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808542#comment-16808542 ] Uwe Schindler commented on LUCENE-8738: --- I removed the MR-JAR parts. To easily restore it in case we would like to use it for Java 12+, this commit should survive in GIT, so we should not squash the branch of this issue. I kept the documentation unmodified in the README.maven file, as the artifacts built by Maven should never be used in production, which is unrelated to MR-JAR. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808537#comment-16808537 ] ASF subversion and git services commented on LUCENE-8738: - Commit ba01df2c22840b699a758df930e0212e1682457b in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ba01df2 ] LUCENE-8738, LUCENE-7966: Remove MR-JAR classfile patching from Lucene 9 completely (minimum Java 11) > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808517#comment-16808517 ] Uwe Schindler commented on LUCENE-8738: --- I kept the jtidy-macro, so I did not have to edit the Lucene/Source main build files where the macro was called. If we decide to abandon the check, we can remove that completly (just grep for "jtidy"). > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808515#comment-16808515 ] Uwe Schindler commented on LUCENE-8738: --- OK, done. We may have to think about, if we now want to enable Javadocs liting for all types of JDKs. Currently the "documentation-lint.supported" code looks crazy: It checks for exact "Java 11" (the reason for this is that on later versions they often change HTNML format and the the python linter breaks) and also for "hotspot". Maybe we can clean that up. I will now also remove the commented out MR-JAR stuff and the groovy patcher files. Those can easily be restored using GIT, so why keep it in source tree. > Bump minimum Java version requirement to 11 > --- > > Key: LUCENE-8738 > URL: https://issues.apache.org/jira/browse/LUCENE-8738 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build >Reporter: Adrien Grand >Priority: Minor > Labels: Java11 > Fix For: master (9.0) > > > See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
