GitHub user iyerr3 opened a pull request:
https://github.com/apache/incubator-madlib/pull/70
Build: Fix version parsing in madpack
Primary change is line 359. Other changes are whitespace fixes.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user iyerr3 commented on the issue:
https://github.com/apache/incubator-madlib/pull/70
@fmcquillan99 This fix is necessary to correctly install on any platform
that reports a sub-version number `10` or higher.
---
If your project is set up for it, you can reply to this email
Github user fmcquillan99 commented on the issue:
https://github.com/apache/incubator-madlib/pull/70
@iyerr3 Thanks for catching this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user mktal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/70#discussion_r83715452
--- Diff: src/madpack/madpack.py ---
@@ -357,7 +356,7 @@ def _get_rev_num(rev):
@param rev version text
"""
try:
-
Github user mktal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/70#discussion_r83715757
--- Diff: src/madpack/madpack.py ---
@@ -357,7 +356,7 @@ def _get_rev_num(rev):
@param rev version text
"""
try:
-
Github user mktal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/70#discussion_r83716436
--- Diff: src/madpack/madpack.py ---
@@ -357,7 +356,7 @@ def _get_rev_num(rev):
@param rev version text
"""
try:
-
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/70#discussion_r83716471
--- Diff: src/madpack/madpack.py ---
@@ -357,7 +356,7 @@ def _get_rev_num(rev):
@param rev version text
"""
try:
-
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/70#discussion_r83716925
--- Diff: src/madpack/madpack.py ---
@@ -357,7 +356,7 @@ def _get_rev_num(rev):
@param rev version text
"""
try:
-
