Re: [VOTE] Release Apache Maven 3.0-alpha-5
On Thu, Dec 3, 2009 at 7:44 PM, Brian Fox bri...@infinity.nu wrote: Something like duplicate dependencies likely means you have a real problem you didn't know about in your poms. I think failing is appropriate in this case. I fail to grok what you just said there. So if i have in my pom dependency groupIdjavax.persistence/groupId artifactIdpersistence-api/artifactId version1.0/version /dependency and then 25 other dependencies and then again the one above (due to a copy-paste oversight let's say) then I have a real problem in my build you say. How is it different from unused and declared dependencies, or used and undeclared ? For me these all fit in the same boat ie 'potential build optimizations' Jorg PS how about a dependency:scan-duplicates then ? - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
On Fri, Dec 4, 2009 at 2:16 AM, Jorg Heymans jorg.heym...@gmail.com wrote: On Thu, Dec 3, 2009 at 7:44 PM, Brian Fox bri...@infinity.nu wrote: Something like duplicate dependencies likely means you have a real problem you didn't know about in your poms. I think failing is appropriate in this case. I fail to grok what you just said there. So if i have in my pom dependency groupIdjavax.persistence/groupId artifactIdpersistence-api/artifactId version1.0/version /dependency and then 25 other dependencies and then again the one above (due to a copy-paste oversight let's say) then I have a real problem in my build you say. How is it different from unused and declared dependencies, or used and undeclared ? Yes that is a problem because if you later go to upgrade to 1.2, you're most likely going to find the first instance and change it, but you're still going to get 1.0 because last time I checked, it was last wins. This is a hidden cancer in your pom that will bite you later. How is it different than undeclared dependencies? It's slightly worse because you have a false sense of security by having it specified. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
On Tue, Nov 24, 2009 at 12:18 PM, Benjamin Bentmann benjamin.bentm...@udo.edu wrote: Jorg Heymans wrote: [ERROR] The project build-tools:1-SNAPSHOT (D:\src\myproject\pom.xml) has 1 error [ERROR] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar - duplicate declaration of version 3.8.2 Shall i log an issue for this or is this a known feature ? The error itself is by design and is part of overall stricter POM validation. If the cause isn't present in the current POM, it must be present in one of its parents. mvn ... -e should tell more but I will look into improving the message for the next release. I can understand the need for stricter pom validation, but is it really necessary to fail a build completely just because a dependency is declared twice ? It seems a bit harsh. A big [WARNING] seems more appropriate. Will m3 also fail builds for this one then: [WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent! IMO most knowledgeable people react on warnings more positive, so more like ah cool m3 spotted a potential hazard so lets go and fix this instead of why the heck is m3 not able to build my project, lets revert to m2. Debatable, but that's how i see it. Cheers, Jorg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
2009/12/3 Jorg Heymans jorg.heym...@gmail.com On Tue, Nov 24, 2009 at 12:18 PM, Benjamin Bentmann benjamin.bentm...@udo.edu wrote: Jorg Heymans wrote: [ERROR] The project build-tools:1-SNAPSHOT (D:\src\myproject\pom.xml) has 1 error [ERROR] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar - duplicate declaration of version 3.8.2 Shall i log an issue for this or is this a known feature ? The error itself is by design and is part of overall stricter POM validation. If the cause isn't present in the current POM, it must be present in one of its parents. mvn ... -e should tell more but I will look into improving the message for the next release. I can understand the need for stricter pom validation, but is it really necessary to fail a build completely just because a dependency is declared twice ? It seems a bit harsh. Actually, I'm liking this build failing on double dependencies. A big [WARNING] seems more appropriate. Will m3 also fail builds for this one then: [WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent! IMO most knowledgeable people react on warnings more positive, so more like ah cool m3 spotted a potential hazard so lets go and fix this instead of why the heck is m3 not able to build my project, lets revert to m2. Debatable, but that's how i see it. Cheers, Jorg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
On Thu, Dec 3, 2009 at 11:10 AM, Stephen Connolly stephen.alan.conno...@gmail.com wrote: 2009/12/3 Jorg Heymans jorg.heym...@gmail.com On Tue, Nov 24, 2009 at 12:18 PM, Benjamin Bentmann benjamin.bentm...@udo.edu wrote: Jorg Heymans wrote: [ERROR] The project build-tools:1-SNAPSHOT (D:\src\myproject\pom.xml) has 1 error [ERROR] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar - duplicate declaration of version 3.8.2 Shall i log an issue for this or is this a known feature ? The error itself is by design and is part of overall stricter POM validation. If the cause isn't present in the current POM, it must be present in one of its parents. mvn ... -e should tell more but I will look into improving the message for the next release. I can understand the need for stricter pom validation, but is it really necessary to fail a build completely just because a dependency is declared twice ? It seems a bit harsh. Actually, I'm liking this build failing on double dependencies. Any particular reason or do you get a kick out of scanning 60+ module reactor builds for duplicates ? :-P Jorg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
2009/12/3 Jorg Heymans jorg.heym...@gmail.com On Thu, Dec 3, 2009 at 11:10 AM, Stephen Connolly stephen.alan.conno...@gmail.com wrote: 2009/12/3 Jorg Heymans jorg.heym...@gmail.com On Tue, Nov 24, 2009 at 12:18 PM, Benjamin Bentmann benjamin.bentm...@udo.edu wrote: Jorg Heymans wrote: [ERROR] The project build-tools:1-SNAPSHOT (D:\src\myproject\pom.xml) has 1 error [ERROR] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar - duplicate declaration of version 3.8.2 Shall i log an issue for this or is this a known feature ? The error itself is by design and is part of overall stricter POM validation. If the cause isn't present in the current POM, it must be present in one of its parents. mvn ... -e should tell more but I will look into improving the message for the next release. I can understand the need for stricter pom validation, but is it really necessary to fail a build completely just because a dependency is declared twice ? It seems a bit harsh. Actually, I'm liking this build failing on double dependencies. Any particular reason or do you get a kick out of scanning 60+ module reactor builds for duplicates ? :-P I've got most of my projects down to no duplicates... the error stops it happening again! Perhaps we should have 2.2.2 start issuing the warning though! Or maybe a CLI option for 3.0 such as --no-strict-pom-validation Jorg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
2009/12/3 Stephen Connolly stephen.alan.conno...@gmail.com 2009/12/3 Jorg Heymans jorg.heym...@gmail.com On Thu, Dec 3, 2009 at 11:10 AM, Stephen Connolly stephen.alan.conno...@gmail.com wrote: 2009/12/3 Jorg Heymans jorg.heym...@gmail.com On Tue, Nov 24, 2009 at 12:18 PM, Benjamin Bentmann benjamin.bentm...@udo.edu wrote: Jorg Heymans wrote: [ERROR] The project build-tools:1-SNAPSHOT (D:\src\myproject\pom.xml) has 1 error [ERROR] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar - duplicate declaration of version 3.8.2 Shall i log an issue for this or is this a known feature ? The error itself is by design and is part of overall stricter POM validation. If the cause isn't present in the current POM, it must be present in one of its parents. mvn ... -e should tell more but I will look into improving the message for the next release. I can understand the need for stricter pom validation, but is it really necessary to fail a build completely just because a dependency is declared twice ? It seems a bit harsh. Actually, I'm liking this build failing on double dependencies. Any particular reason or do you get a kick out of scanning 60+ module reactor builds for duplicates ? :-P I've got most of my projects down to no duplicates... the error stops it happening again! Perhaps we should have 2.2.2 start issuing the warning though! Or maybe a CLI option for 3.0 such as --no-strict-pom-validation actually much better is something like --yes-i-am-a-bold-developer-and-i-know-i-should-remove-duplicate-dependencies-but-give-me-a-break that way you're _encouraged_ to fix it fast ;-) Jorg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
On Mon, Nov 23, 2009 at 7:59 PM, Paul Gier pg...@redhat.com wrote: I wonder if we really need a full vote for every alpha. Especially if this is going to happen every two weeks. Why not just vote for a 2 week alpha release schedule and then don't do another vote until it's time for beta 1? The ASF requires a vote on the artifacts being released. You can't just sign a blank cheque for any future release. On that basis someone could put something that isn't allowed (e.g. a copy of some GPL code) into maven and then just cut an alpha release. I tried to find something in the ASF docs, but the release FAQ only says Each PMC must obey the ASF requirements on approving any release - but I can't find something that specifically says what the requirements on approving any release are. http://www.apache.org/dev/release.html Niall Benjamin Bentmann wrote: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
Tried it out on our project, and i'm getting this:
[ERROR] The project build-tools:1-SNAPSHOT
(D:\src\myproject\pom.xml) has 1 error
[ERROR]
'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: junit:junit:jar - duplicate declaration of version
3.8.2
I can understand what this is trying to say, but the pom in question
is only a module pom that has no dependencies declared:
parent
groupIdmy.group/groupId
artifactIdparent/artifactId
version19-SNAPSHOT/version
/parent
modelVersion4.0.0/modelVersion
artifactIdbuild-tools/artifactId
packagingpom/packaging
version1-SNAPSHOT/version
modules
moduleant/module
modulemaven/module
/modules
Shall i log an issue for this or is this a known feature ? The output
of -e does not reveal anything useful besides lots of expression
${pom.version} is deprecated. Please use ${project.version} instead,
wierd thing is i'm never actually using expressions in my project.
Jorg
On Mon, Nov 23, 2009 at 11:04 PM, Igor Fedorenko i...@ifedorenko.com wrote:
+1
--
Regards,
Igor
Benjamin Bentmann wrote:
Hi,
We solved some more issues:
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952
There are still a couple of issues left in JIRA:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1
Staging repo:
https://repository.apache.org/content/repositories/maven-018/
Staged source and binary distros:
https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/
Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
+1 from me
Benjamim
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
Jorg Heymans wrote:
[ERROR] The project build-tools:1-SNAPSHOT
(D:\src\myproject\pom.xml) has 1 error
[ERROR]
'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: junit:junit:jar - duplicate declaration of version
3.8.2
Shall i log an issue for this or is this a known feature ?
The error itself is by design and is part of overall stricter POM
validation. If the cause isn't present in the current POM, it must be
present in one of its parents. mvn ... -e should tell more but I will
look into improving the message for the next release.
[...] lots of expression
${pom.version} is deprecated. Please use ${project.version} instead,
wierd thing is i'm never actually using expressions in my project.
As said, likely due to one of the parents from which you inherit.
Benjamin
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
+1 2009/11/23 Benjamin Bentmann benjamin.bentm...@udo.edu: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Olivier - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
+1 On 2009-11-23, at 11:33 AM, Benjamin Bentmann wrote: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl -- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
+1 Arnaud Héritier Software Factory Manager eXo platform - http://www.exoplatform.com --- http://www.aheritier.net On Mon, Nov 23, 2009 at 5:38 PM, Jason van Zyl ja...@maven.org wrote: +1 On 2009-11-23, at 11:33 AM, Benjamin Bentmann wrote: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl -- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
+1 2009/11/23 Arnaud HERITIER aherit...@gmail.com +1 Arnaud Héritier Software Factory Manager eXo platform - http://www.exoplatform.com --- http://www.aheritier.net On Mon, Nov 23, 2009 at 5:38 PM, Jason van Zyl ja...@maven.org wrote: +1 On 2009-11-23, at 11:33 AM, Benjamin Bentmann wrote: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl -- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
+1 2009/11/23 nicolas de loof nicolas.del...@gmail.com: +1 2009/11/23 Arnaud HERITIER aherit...@gmail.com +1 Arnaud Héritier Software Factory Manager eXo platform - http://www.exoplatform.com --- http://www.aheritier.net On Mon, Nov 23, 2009 at 5:38 PM, Jason van Zyl ja...@maven.org wrote: +1 On 2009-11-23, at 11:33 AM, Benjamin Bentmann wrote: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl -- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
I wonder if we really need a full vote for every alpha. Especially if this is going to happen every two weeks. Why not just vote for a 2 week alpha release schedule and then don't do another vote until it's time for beta 1? Benjamin Bentmann wrote: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0-alpha-5
+1 -- Regards, Igor Benjamin Bentmann wrote: Hi, We solved some more issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=14952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-018/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-018/org/apache/maven/apache-maven/3.0-alpha-5/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamim - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
