Re: Maven Core / MNG-6362 README.md / CONTRIBUTION.md

Hi to all, I want to know if we have more enhancements etc. I would like to merge this as soon as possible to master... On 19/02/18 19:59, Karl Heinz Marbaise wrote: Hi, I would like to integrate the issue MNG-6362 which contains only enhancements for the README.md, CONTRIBUTION.md and a

Re: Maven Core / MNG-6362 README.md / CONTRIBUTION.md

IMHO every guideline should have a small explanation (and maybe less aggressive) A suggestion: No tabs! Please use spaces for indentation. The Maven Codestyle uses spaces instead of spaces. This way column numbers don't depend on the IDE settings and will be the same for everyone.

Re: Maven Core / MNG-6362 README.md / CONTRIBUTION.md

Hi Plamen, On 20/02/18 19:17, Plamen Totev wrote: That is great idea. On Tue, Feb 20, 2018 at 9:16 AM, Hervé BOUTEMY wrote: 2. how can we test .github/pull_request_template? The idea seems interesting I don't know if you can. But the way it works is pretty simple.

Re: Maven Core / MNG-6362 README.md / CONTRIBUTION.md

Hi Hervé, On 20/02/18 08:16, Hervé BOUTEMY wrote: I like it! a few questions: 1. why a full "Contributing" section in README.md and a separate CONTRIBUTING.md? would a link from the first to the second suffice? (to avoid maintenance) Good hint...Thanks..Of course...(improved hope so ;-))..

Re: Maven Core / MNG-6362 README.md / CONTRIBUTION.md

That is great idea. On Tue, Feb 20, 2018 at 9:16 AM, Hervé BOUTEMY wrote: > 2. how can we test .github/pull_request_template? The idea seems interesting I don't know if you can. But the way it works is pretty simple. When you create a pull request the text box will be

Re: Maven Core / MNG-6362 README.md / CONTRIBUTION.md

I like it! a few questions: 1. why a full "Contributing" section in README.md and a separate CONTRIBUTING.md? would a link from the first to the second suffice? (to avoid maintenance) 2. how can we test .github/pull_request_template? The idea seems interesting Then puting this enhancement in