Re: Building on OS X 10.12

2016-12-12 Thread Neil Conway
I think we should look into adopting "-fvisibility=hidden" and explicitly annotating the symbols that we want to export: https://issues.apache.org/jira/browse/MESOS-6734 Although I agree this isn't a trivial change and it would be good to have some tool support here, but there are lots of

Re: Building on OS X 10.12

2016-12-12 Thread Joris Van Remoortere
There are a significant number of developer and runtime performance benefits from turning this flag on. In my opinion it is also a dangerous flag to turn on by default without a strict set of rules for our codebase to ensure that we don't accidentally: - have multiple instances of static

Re: Building on OS X 10.12

2016-12-05 Thread James Peach
> On Dec 2, 2016, at 10:54 PM, Jie Yu wrote: > > Another tip. If you are on macOS sierra, you might notice the linking is > extremely slow using the default clang. > > Using CXXFLAGS `-fvisibility-inlines-hidden` will greatly speedup the > linking. Is there a reason we

Re: Building on OS X 10.12

2016-12-03 Thread tommy xiao
Cool 2016-12-03 14:54 GMT+08:00 Jie Yu : > Another tip. If you are on macOS sierra, you might notice the linking is > extremely slow using the default clang. > > Using CXXFLAGS `-fvisibility-inlines-hidden` will greatly speedup the > linking. > > - Jie > > On Thu, Dec 1,

Re: Building on OS X 10.12

2016-12-02 Thread Jie Yu
Another tip. If you are on macOS sierra, you might notice the linking is extremely slow using the default clang. Using CXXFLAGS `-fvisibility-inlines-hidden` will greatly speedup the linking. - Jie On Thu, Dec 1, 2016 at 5:05 PM, Michael Park wrote: > Thanks for writing this

Re: Building on OS X 10.12

2016-12-01 Thread Michael Park
Thanks for writing this up! The remote login thing is funky! The `-Wno-deprecated-declarations` is currently very unfortunate, and hopefully we can fix this in our build automatically soon. I personally have been doing: `CC="ccache clang-3.7 -Wno-deprecated-declarations" CXX="ccache clang++-3.7

Re: Building on OS X 10.12

2016-12-01 Thread Benjamin Mahler
Here is the update: https://reviews.apache.org/r/54262/ On Thu, Dec 1, 2016 at 12:36 PM, Vinod Kone wrote: > Thanks! > > On Thu, Dec 1, 2016 at 12:34 PM, Benjamin Mahler > wrote: > > > I ran into some compilation issues after upgrading to OS X

Re: Building on OS X 10.12

2016-12-01 Thread Vinod Kone
Thanks! On Thu, Dec 1, 2016 at 12:34 PM, Benjamin Mahler wrote: > I ran into some compilation issues after upgrading to OS X 10.12.1, and was > able to build successfully with Jie's help. > > The first thing was that I encountered a lot of these deprecation warnings: > >

Building on OS X 10.12

2016-12-01 Thread Benjamin Mahler
I ran into some compilation issues after upgrading to OS X 10.12.1, and was able to build successfully with Jie's help. The first thing was that I encountered a lot of these deprecation warnings: ../../../3rdparty/libprocess/../stout/include/stout/os/posix/su.hpp:241:9: warning: 'syscall' is