[GitHub] metamodel pull request #156: Checkstyle integration

2017-08-08 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/156#discussion_r131862601 --- Diff: core/src/main/java/org/apache/metamodel/UpdateSummaryBuilder.java --- @@ -1,4 +1,5 @@ /** + * Licensed to the Apache

[GitHub] metamodel pull request #156: Checkstyle integration

2017-08-08 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/156#discussion_r131862185 --- Diff: pom.xml --- @@ -330,6 +330,27 @@ under the License. +

[GitHub] metamodel issue #155: METAMODEL-1151 data context factories

2017-08-08 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/155 Update: Also added factories for HBase, JSON and XML --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metamodel-membrane pull request #3: METAMODEL-1149: File based registry

2017-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel-membrane/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] metamodel pull request #156: Checkstyle integration

2017-08-08 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/156#discussion_r132087025 --- Diff: style/checkstyle.xml --- @@ -18,29 +18,47 @@ specific language governing permissions and limitations under the License. -->

[GitHub] metamodel pull request #156: Checkstyle integration

2017-08-08 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/156#discussion_r131896640 --- Diff: .travis.yml --- @@ -10,12 +10,15 @@ before_install: - sed -i.bak

[GitHub] metamodel pull request #156: Checkstyle integration

2017-08-08 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/156#discussion_r131897104 --- Diff: style/checkstyle.xml --- @@ -18,29 +18,47 @@ specific language governing permissions and limitations under the License. -->

[GitHub] metamodel issue #156: Checkstyle integration

2017-08-08 Thread tomatophantastico
Github user tomatophantastico commented on the issue: https://github.com/apache/metamodel/pull/156 minimum set is a good idea. I used intellij idea and i am not to terribly familiar with it yet, so this contributed to not so clean commits. Can we collect some issues regarding

[GitHub] metamodel pull request #156: Checkstyle integration

2017-08-08 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/156#discussion_r131868557 --- Diff: pom.xml --- @@ -330,6 +330,27 @@ under the License. +