[GitHub] metron issue #669: METRON-1064: Make init script OS-agnostic

2017-07-28 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/669 I was able to get this to work in an Ubuntu cluster. I had to adjust the metron-rest init script to get JAVA_HOME from Ambari. This is ready for review. --- If your project is set up for it,

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-28 Thread iraghumitra
Github user iraghumitra commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r130079229 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/alerts-list.e2e-spec.ts --- @@ -0,0 +1,119 @@ +/// --- End diff --

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r130129238 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,315 @@ +# Ambari Management Pack Development +Typically, Ambari Management

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-28 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r130129788 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,315 @@ +# Ambari Management Pack Development +Typically, Ambari Management

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Facing error whith mvn clean install

2017-07-28 Thread Laurens Vets
I highly suspect the fact that you're trying to compile Metron on Windows is the problem :) The only supported OS at the moment is CentOS 6 I believe. On 2017-07-27 19:07, bharath phatak wrote: Hi Michael, I was able pass on with the above issue.Its resolved. I am facing issue with

[GitHub] metron pull request #674: METRON-681 CSVConverter should trim key and values

2017-07-28 Thread basvdl
GitHub user basvdl opened a pull request: https://github.com/apache/metron/pull/674 METRON-681 CSVConverter should trim key and values ## Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing

[GitHub] metron issue #665: METRON-1060: Add performance timing logging to enrichment...

2017-07-28 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/665 @ottobackwards Just submitted. I've updated the testing notes above as well. Note the added documentation in the metron-common README. --- If your project is set up for it, you can reply to this

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-28 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129992712 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/util/FileUtils.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-28 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129968508 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/util/VFSClassloaderUtil.java --- @@ -0,0 +1,178 @@ +/** + * Licensed to the

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-28 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards , I agree it isn't critical to update now, and would slow down this PR even more. Do you mind opening a tracking jira to consider an update in the future? (assuming they

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-28 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r130153573 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,315 @@ +# Ambari Management Pack Development +Typically, Ambari Management

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-28 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 and thanks for the file map of the test area. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-28 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r130151964 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,315 @@ +# Ambari Management Pack Development +Typically, Ambari Management

Re: Facing error whith mvn clean install

2017-07-28 Thread Michael Miklavcic
You might consider trying Cygwin, but I have not done this with Metron. Back when I worked on a Windows machine, I used to use it. I would love to know if it works in this case! M On Fri, Jul 28, 2017 at 12:02 PM, Matt Foley wrote: > Well, Linux in general at least.

[GitHub] metron issue #665: METRON-1060: Add performance timing logging to enrichment...

2017-07-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/665 Nice, tag me when it is in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [DISCUSS] Easing the ramp-up into contributing

2017-07-28 Thread Artem Ervits
Being new to this community and attempting to contribute METRON-1058, METRON-1059 and METRON-1063, my experience is that requirement to run the full tests and integration tests in order to contribute even a simple patch is overkill. I understand that community wants high quality contributions but

Re: Facing error whith mvn clean install

2017-07-28 Thread Matt Foley
Well, Linux in general at least. CentOS 7 is known to work fine. Ubuntu has worked most of the time; Ryan’s PR#669 today was to stabilize another bit of it. On 7/28/17, 9:13 AM, "Laurens Vets" wrote: I highly suspect the fact that you're trying to compile Metron on

Re: [DISCUSS] Easing the ramp-up into contributing

2017-07-28 Thread Justin Leet
I created METRON-1071 to track the CONTRIBUTING.md. I also called out personal Travis setup instructions, because that's pretty closely tied our dev experience and seems like a good place to let it live. On Fri, Jul 28, 2017 at 1:43 PM, Michael

Re: [DISCUSS] Easing the ramp-up into contributing

2017-07-28 Thread Michael Miklavcic
Hi Artem, You could probably get away with not running them locally since we use Travis, which functions similarly to Jenkins from a testing perspective. Additionally, you can hook up Travis to run on your own github account as many Metron committers have already done. The upshot is that if your

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-28 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r130149172 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,315 @@ +# Ambari Management Pack Development +Typically, Ambari Management

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-28 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r130151618 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,315 @@ +# Ambari Management Pack Development +Typically, Ambari Management

[GitHub] metron issue #665: METRON-1060: Add performance timing logging to enrichment...

2017-07-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/665 +1 -> Love this. Really great work. Makes me think that we want to have some kind of topical area of the site-book or developers documentation ( like this would go with testing ) but that is

[GitHub] metron issue #669: METRON-1064: Make init script OS-agnostic

2017-07-28 Thread james-sirota
Github user james-sirota commented on the issue: https://github.com/apache/metron/pull/669 +1 by inspection. thanks, ryan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron pull request #673: METRON-1069: Ambari MPack documentation around dev...

2017-07-28 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/673#discussion_r130128846 --- Diff: metron-deployment/packaging/ambari/README.md --- @@ -0,0 +1,315 @@ +# Ambari Management Pack Development +Typically, Ambari Management

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-28 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r130213711 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/util/VFSClassloaderUtil.java --- @@ -0,0 +1,178 @@ +/** + * Licensed to the