[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149701086 --- Diff: metron-stellar/stellar-common/README.md --- @@ -257,7 +258,7 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149706457 --- Diff: metron-stellar/stellar-common/README.md --- @@ -748,7 +728,7 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 I checkout your PR and then attempt to do an install and the build fails. ``` $ mvn clean install [INFO] Scanning for projects... Downloading:

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 I'm sorry nick, the instruction for 'how to build metron' from the top level readme didn't get pulled over when I did the reconstruction. The plugin is not in any repo for maven to

[GitHub] metron pull request #833: METRON-1275: Fix Metron Documentation

2017-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/833 ---

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/836 DO NOT MERGE METRON-1308: Fix Metron Documentation ## Contributor Comments More documentation fixes - work in progress but looking to get a review of some findings (see comments)

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149703967 --- Diff: metron-stellar/stellar-common/README.md --- @@ -257,7 +258,7 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron issue #824: METRON-1289: Alert fields are lost when a MetaAlert is cr...

2017-11-08 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/824 Do we know why the partial update doesn't work? I'm not necessarily opposed to doing this as a short term fix, but I'd like to know root cause. It seems like overkill to submit a full

Re: Committing to the metron-bro-plugin-kafka repo

2017-11-08 Thread zeo...@gmail.com
So, here's my argument against the sub-module approach: - If we add a sub-module into apache/metron then the way you clone from github changes (--recursive). This could break any instructions to spin up Metron full-dev, when they're using the bro plugin (forums, blog posts, metron READMEs, etc.).

[GitHub] metron-bro-plugin-kafka issue #1: METRON-1303: Reorganize the metron-bro-plu...

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/1 Holding off on committing this until I hear back on my [suggested roadmap

[GitHub] metron issue #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/836 So, answering your questions en-masse we use the following similar to how they exist in regex: * `*` - `0` or `n` instances * `?` - `0` or `1` instance * `+` - `1` or `n` instances

[GitHub] metron issue #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/836 I think I'm more of a fan of being explicit than providing a key, given this only happens a few times through the whole doc. Also, like I mentioned, the \*s are being suppressed, so they're not

Re: Committing to the metron-bro-plugin-kafka repo

2017-11-08 Thread Nick Allen
​I would suggest that we shift our existing deployment routines to use the new code repository, prior to making changes to "packag-ify" it. That way we know that our code reorganization is definitely working and has been successful. Prior to step 2, we would... * Add a sub-module pointing to

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149701209 --- Diff: metron-stellar/stellar-common/README.md --- @@ -849,7 +829,7 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149701164 --- Diff: metron-stellar/stellar-common/README.md --- @@ -748,7 +728,7 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149701260 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1034,15 +1035,15 @@ In the core language functions, we support basic functional programming

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149701286 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1034,15 +1035,15 @@ In the core language functions, we support basic functional programming

[GitHub] metron pull request #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/836#discussion_r149704557 --- Diff: metron-stellar/stellar-common/README.md --- @@ -748,7 +728,7 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r149759730 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1346,6 +1346,46 @@ Please note that functions are loading lazily in the background and will be

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r149686111 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1346,6 +1346,46 @@ Please note that functions are loading lazily in the background and will be

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r149686086 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1346,6 +1346,46 @@ Please note that functions are loading lazily in the background and will be

[GitHub] metron issue #836: DO NOT MERGE METRON-1308: Fix Metron Documentation

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/836 I just took a stab at an update, @cestella can you take a look when you get a second ---

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-11-08 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r149766318 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1346,6 +1346,46 @@ Please note that functions are loading lazily in the background and will

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-11-08 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r149767436 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1346,6 +1346,46 @@ Please note that functions are loading lazily in the background and will be

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-11-08 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r149768741 --- Diff: metron-stellar/stellar-common/README.md --- @@ -1346,6 +1346,46 @@ Please note that functions are loading lazily in the background and will

Re: Committing to the metron-bro-plugin-kafka repo

2017-11-08 Thread zeo...@gmail.com
I'm not strongly against it, but my biggest interest was not wasting time doing something that will get ripped out fairly quickly. That said, discussing this is taking more time than doing the work, and I should have a PR out soon that does what you requested as soon as my full-dev tests

[GitHub] metron pull request #837: METRON-1309: Change metron-deployment to pull the ...

2017-11-08 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/837 METRON-1309: Change metron-deployment to pull the plugin from apache/metron-bro-plugin-kafka ## Contributor Comments Based on the conversation on the [mailing

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-08 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r149783542 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven