[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-03-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/943 I spun this up in full dev and everything worked as expected. The organization looks good to me and I can't find anything wrong with it. +1 ---

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-03-06 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/943 @ottobackwards I believe the repercussions are the same as they are for the existing MPack since the services are distinct from the MPack itself. We should probably consider a separate test for

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-03-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/943 What about upgrading.md? ---

[GitHub] metron pull request #940: METRON-1460: Create a complementary non-split-join...

2018-03-06 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/940#discussion_r172595029 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/ParallelEnricher.java --- @@ -0,0 +1,281 @@ +/**

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-03-06 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/943 Also, I will look at moving the Kibana templates to Metron as this is something that will need to be done for Solr as well. ---

[GitHub] metron pull request #950: METRON-1470: Update jquery to version 3+

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/950 ---

[GitHub] metron pull request #940: METRON-1460: Create a complementary non-split-join...

2018-03-06 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/940#discussion_r172711543 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/ParallelEnricher.java --- @@ -0,0 +1,281 @@ +/** +

[GitHub] metron pull request #940: METRON-1460: Create a complementary non-split-join...

2018-03-06 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/940#discussion_r172656809 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/ParallelEnricher.java --- @@ -0,0 +1,281 @@ +/** +

[GitHub] metron issue #950: METRON-1470: Update jquery to version 3+

2018-03-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/950 I ran this up in full dev and tested several different features. I could not find any regressions. Thanks @xyztdanid4! +1 ---

[GitHub] metron pull request #940: METRON-1460: Create a complementary non-split-join...

2018-03-06 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/940#discussion_r172694248 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/ParallelEnricher.java --- @@ -0,0 +1,281 @@ +/**

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/940 +1 The unified topology works great. ---

[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/948 +1 ---

[GitHub] metron pull request #950: METRON-1470: Update jquery to version 3+

2018-03-06 Thread xyztdanid4
GitHub user xyztdanid4 opened a pull request: https://github.com/apache/metron/pull/950 METRON-1470: Update jquery to version 3+ I updated jquerry dependency of the project due to security reason. - [X] Is there a JIRA ticket associated with this PR? If not one needs to be

[GitHub] metron issue #936: METRON-1450:Add rest endpoint documentation for splitting...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/936 Thanks @MohanDV . Will merge this now. ---

[GitHub] metron pull request #936: METRON-1450:Add rest endpoint documentation for sp...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/936 ---

[GitHub] metron-bro-plugin-kafka issue #6: Configurable JSON timestamps and default a...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/6 @dcode 1. The JIRA created for this is https://issues.apache.org/jira/browse/METRON-1469. 1. Please change the PR title to "METRON-1469: Kafka Plugin for Bro -

[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/948 Other than that little nit, it works great though. Thanks @JonZeolla ---

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/853 ---

[GitHub] metron-bro-plugin-kafka issue #7: METRON-1324: Increment metron-bro-plugin-k...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/7 +1 Thanks, @JonZeolla ! ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/942 @nickwallen I dint consider implementation where STATS object can be passed in list of mixed object . That requires to change the STATS object to be 'Comparable' type . Do you think it should be

[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/948 When I got to the point of selecting the repo, I was unsure of what to type for the Bro Plugin repo. ``` $ ./metron-pr948/dev-utilities/committer-utils/prepare-commit ...using

[GitHub] metron issue #941: METRON-1355: Convert metron-elasticsearch to new infrastr...

2018-03-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/941 Sorry I should have documented this better in the PR description. The docker-machine ip address needs to be substituted in ElasticsearchTestUtils temporarily if you want to run this on your local

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/942 @MohanDV - It looks like some care was taken previously so that getting the max of a list of mixed elements will just work. For example `MAX([1, 2d, 3f]) == 3f`. Did you consider an

[GitHub] metron pull request #946: METRON-1465:Support for Elasticsearch X-pack

2018-03-06 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/946#discussion_r172544606 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/metron_service.py --- @@ -70,6

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-03-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/940 Ok, README is updated with the new topology diagram. Let me know if there's anything else. ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/942 The first point here is around semantics. I am assuming the semantics of this would be a "max of maxes". So if I have a list of stats objects, I compare the max of each one. Whichever max is

[GitHub] metron issue #948: METRON-1468: Add support for apache/metron-bro-plugin-kaf...

2018-03-06 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/948 I agree, updated the script and readme. ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/942 I would like to address the issue somehow or at least garner more community feedback on this change. As it stands, usage of the function is not very consistent. For example, I can pass

[GitHub] metron pull request #949: METRON-1471: Migrate shuffle connections to local ...

2018-03-06 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/949 METRON-1471: Migrate shuffle connections to local or shuffle ## Contributor Comments Currently, we use shuffle groupings when we do not want to group by field. We should, instead, use local

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/942 Maybe making this function so generic is going to necessitate it being so complicated that it is harder to maintain etc. ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/942 I would say performance trumps complexity of functionality here. ---

[GitHub] metron issue #936: METRON-1450:Add rest endpoint documentation for splitting...

2018-03-06 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 @nickwallen / @JonZeolla can you please merge this request. ---

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-03-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/940 That's great @cestella . Many thanks. I will run it up in the lab. No problem. ---

[GitHub] metron pull request #933: METRON-1452 Rebase Dev Environment on Latest CentO...

2018-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/933 ---