Thanks Otto. Moving this discussion to a DISCUSS thread and closing out the
PR now.
On Thu, Dec 20, 2018 at 11:00 AM Otto Fowler
wrote:
> https://github.com/oasp/asciidoc-link-checker
>
>
> On December 20, 2018 at 12:59:39, Otto Fowler (ottobackwa...@gmail.com)
> wrote:
>
> +1 for merging a
We recently had our site-book doc generation break due to our not including
it in the Travis build. The fix for a broken build seems simple enough -
add it to our build process and assuming it doesn't cause build timeout
issues, we should be good to go.
Beyond that, there are additional issues
Thanks for the feedback Otto. I'm not too familiar with our infrastructure
afa impact of switching to ascii doc, but I think it's worth considering if
it allows us to have a consistent rendering markdown that's easy to use.
Automated link testing is a good idea. I wonder if Cypress could do that
+1 for merging a fix.
On December 20, 2018 at 12:43:57, Michael Miklavcic (
michael.miklav...@gmail.com) wrote:
Thanks for the feedback Otto. I'm not too familiar with our infrastructure
afa impact of switching to ascii doc, but I think it's worth considering if
it allows us to have a
https://github.com/oasp/asciidoc-link-checker
On December 20, 2018 at 12:59:39, Otto Fowler (ottobackwa...@gmail.com)
wrote:
+1 for merging a fix.
On December 20, 2018 at 12:43:57, Michael Miklavcic (
michael.miklav...@gmail.com) wrote:
Thanks for the feedback Otto. I'm not too familiar
I definitely agree with option 3; that's a no-brainer IMO. I thought for
sure this was already happening, honestly.
As for 2, we could even script the broken link check by:
- Serving up the site locally via python with `python -m http.server`
from the site-book output directory
-
You will want to add a -Dlocalhost to the wget to ensure you're not
checking domains linked from our docs and turn travis into google. ;)
On Thu, Dec 20, 2018 at 3:19 PM Michael Miklavcic <
michael.miklav...@gmail.com> wrote:
> Well golly, I love this. I'll give that a whirl!
>
> On Thu, Dec
Well golly, I love this. I'll give that a whirl!
On Thu, Dec 20, 2018 at 1:08 PM Casey Stella wrote:
> I definitely agree with option 3; that's a no-brainer IMO. I thought for
> sure this was already happening, honestly.
>
> As for 2, we could even script the broken link check by:
>
>-
