Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
All integration tests are passing. I was able to start up the application
against quick dev and all the endpoints look like they are working.
---
If your project is set up for it, you
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/316
For convenience, I staged the commit in a remote branch:
https://github.com/cestella/incubator-metron/tree/METRON-503_sandbox . I'd ask
that @merrimanr take it for a test drive.
---
If
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr @jjmeyer0 I think we should make sure JJ gets credit for his
contribution on this. We should squash the commits into the minimal possible
each named "METRON-503: Metron REST
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Ok, this is a big one and has been around for a long time now in
Metron-years. Before we go ahead and pull the trigger on commit, I want to
make sure there are no outstanding
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
First off, I'd like to apologize for it taking me a little longer to retest
this.
I went through and tested the issues I saw again. Everything seems to be
working. I think this
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr Good catch on this. I'll take a look again, but I think it's
looking good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Finally figured this one out. I wasn't able to reproduce the issue because
my maven version was a couple minor releases behind (on 3.3.9 now for what it's
worth). Once I got past that
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr I had a chance to try this again. If I build from
`incubator-metron` it doesn't work. If I build from `metron-interface`
everything seems to be working just fine.
---
If your
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Hmm I just tried deploying on quick-dev the same way and was able to hit
the stellar endpoints without issue. I will continue testing to see if I can
get it to break tomorrow.
---
If
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr I'm using quick-dev to do my tests. I built everything from
metron root with `mvn clean install -DskipTests`. Then I setup `quick-dev`.
Extracted the tar and ran the following:
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Just merged in the latest from master including the maxmind fix that was
breaking the build.
I am not able to recreate the NoSuchError exception. Here is what I'm
doing to
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr For some reason I am still getting the following error on the
endpoints. Also, the no such method error turned into this as well. How are you
running it? I'm running it using
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Just pushed out commits to address these bugs. In regards to this:
"Another thing that may be nice is to describe what is all needed for the
REST API to run. For example, I
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
The latest commit includes removing MySQL as the security credential store
and replacing with H2. I also updated the documentation with instructions on
configuring a production database
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr sorry for not commenting earlier. I think this is in a pretty
good state. I do want to review this again from beginning to end after you
finish the MySQL stuff. After that I'll
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr the builds failing due to the `Cli to CLI` change. I've hit this
before. I think it's because mac is case insensitive and gets confused. To fix
it, I've had to manually change
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr you are right about guava. I'll remove my uses of it. Plus, Java
has a lot of those functions built in now. No reason I shouldn't use those
instead.
I agree that the
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
It just occurred to me that we don't have an HdfsController. Do we even
need an HdfsService or could we just use WebHDFS (or Knox) instead?
---
If your project is set up for it, you
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@jjmeyer0, merged your PR in with the new tests. Everything looked good,
thanks for helping with that.
I just submitted another commit with tests for the remaining services
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr as we discussed, I created a PR against yours with some unit
tests for the services. Let me know if you have any questions.
---
If your project is set up for it, you can reply
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Conflict is resolved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Those 2 are done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr this is looking good. I like how you broke out some of the
services and started a constants class. There were two very minor things that I
noticed.
1. `@Override`
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@jjmeyer0, just pushed out the commit to separate Services into interfaces
and implementations. As I created the interfaces there were a few spots that
needed some changes.
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Just pushed out a commit to address all the issues noted above with the
exception of separating the service classes into interfaces and
implementations.
For that, @jjmeyer0 is
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@jjmeyer0 #2 make sense. That would be great if you can open another Jira
to discuss.
Can you clarify what you mean on number 1? Are you talking about
separating the services
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
I've tested a few controllers (global config, grok controller, and kafka
controller). Everything seems to be working pretty well. I will continue to
test more, but since this is a large
Ryan,
I owe you an apology, that discussion is more towards the web app pr and
not the rest api which would still be consumed by an ambari view or a
custom app.
I confused the threads.
On January 19, 2017 at 09:29:29, merrimanr (g...@git.apache.org) wrote:
Github user merrimanr commented on
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
The primary driver as I see it for a REST API is to facilitate building
user interfaces for various interactions with Metron. At some point (I would
argue now) we will want/need to
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
I would very much prefer to not wait. There are other endpoints outside of
configuration management that we need, a REST API isn't limited to just that.
If we feel we should remove the
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@ottobackwards that's a good point. To me it still may makes sense to have
this API (which the Ambari view would use). I think it would be useful for
clusters not using Ambari. But I
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Also, the point that this may be better managed from within ambari as a
view may need consideration.
On January 19, 2017 at 08:58:51, JJ Meyer
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr @cestella does it make sense to hold off on this for a little
while? It looks like all configuration may be managed by Ambari going forward.
I am getting this from the dev
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
That use case makes sense. I will leave it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr, the reasoning I used to include the http status code in the
error message format is if there is a need to send these messages to a
downstream system. For example, let's say a
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Just pushed out a commit to address Response Behavior. I defined an error
response type using the structure you proposed and added a RestExceptionHandler
as described in the link to the
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@merrimanr yes, I was thinking of something along these lines. At a high
level I was thinking that any exception that bubbled up through the controller
should be mapped to an error
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
@jjmeyer0 thank you for the feedback, I think they are good suggestions.
Just pushed out commits to address "Project Structure", "API Documentation",
and "API Structure". Let me know
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/316
**Project Structure:**
Personally I think the module, `metron-interface`, should be split up into
more modules. I think there should be `metron-rest` and
Github user merrimanr commented on the issue:
https://github.com/apache/incubator-metron/pull/316
Just updated this PR to include several changes/improvements:
- Licensing documentation
- Expanded to include more services: Kafka, SensorEnrichmentConfig,
GlobalConfig,
40 matches
Mail list logo
