[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-18 Thread GitBox
rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-337756887 Regarding org.apache.maven.indexer:maven-indexer:6.0-SNAPSHOT, I suggest we clone that into apache/netbeans owned git, apply the

[GitHub] junichi11 opened a new pull request #165: [NETBEANS-54] Module Review java.j2semodule

2017-10-19 Thread GitBox
junichi11 opened a new pull request #165: [NETBEANS-54] Module Review java.j2semodule URL: https://github.com/apache/incubator-netbeans/pull/165 Exclude module-info.java.template from rat This is an automated message from

[GitHub] geertjanw commented on a change in pull request #44: Testcases related fixes

2017-10-19 Thread GitBox
geertjanw commented on a change in pull request #44: Testcases related fixes URL: https://github.com/apache/incubator-netbeans/pull/44#discussion_r145621717 ## File path: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java ##

[GitHub] geertjanw commented on issue #106: Removed failing test UpdateFromNbmTest

2017-10-19 Thread GitBox
geertjanw commented on issue #106: Removed failing test UpdateFromNbmTest URL: https://github.com/apache/incubator-netbeans/pull/106#issuecomment-337827371 Makes sense and am merging this. This is an automated message from

[GitHub] geertjanw commented on issue #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource

2017-10-19 Thread GitBox
geertjanw commented on issue #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/156#issuecomment-337827796 It appears this branch has conflicts. Can you investigate?

[GitHub] geertjanw commented on issue #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource

2017-10-19 Thread GitBox
geertjanw commented on issue #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/155#issuecomment-337827606 Makes sense and am merging this.

[GitHub] geertjanw closed pull request #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource

2017-10-19 Thread GitBox
geertjanw closed pull request #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/155 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] junichi11 opened a new pull request #164: [NETBEANS-54] Module Review debugger.jpda.ui

2017-10-19 Thread GitBox
junichi11 opened a new pull request #164: [NETBEANS-54] Module Review debugger.jpda.ui URL: https://github.com/apache/incubator-netbeans/pull/164 - no external library - checked Rat report: add the license header to genfiles.properties and README.txt - skimmed through the module,

[GitHub] asfgit closed pull request #114: [NETBEANS-54] Module Review css.lib

2017-10-18 Thread GitBox
asfgit closed pull request #114: [NETBEANS-54] Module Review css.lib URL: https://github.com/apache/incubator-netbeans/pull/114 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] matthiasblaesing commented on issue #114: [NETBEANS-54] Module Review css.lib

2017-10-18 Thread GitBox
matthiasblaesing commented on issue #114: [NETBEANS-54] Module Review css.lib URL: https://github.com/apache/incubator-netbeans/pull/114#issuecomment-337710281 Agreed and merged. This is an automated message from the Apache

[GitHub] matthiasblaesing opened a new pull request #181: [NETBEANS-54] Module Review libs.osgi (followup)

2017-10-23 Thread GitBox
matthiasblaesing opened a new pull request #181: [NETBEANS-54] Module Review libs.osgi (followup) URL: https://github.com/apache/incubator-netbeans/pull/181 Maven central does not hold the original netbeans artifact osgi.cmpn-4.2, but a superset of that: org.osgi

[GitHub] junichi11 commented on issue #129: Sort rat excludes alphabetically

2017-10-23 Thread GitBox
junichi11 commented on issue #129: Sort rat excludes alphabetically URL: https://github.com/apache/incubator-netbeans/pull/129#issuecomment-338853778 I've fixed. #163 and https://github.com/emilianbold/incubator-netbeans/pull/324 have excludes. But it seems that they already conflict. If

[GitHub] junichi11 commented on issue #174: Add a license header template for new files of NetBeans modules

2017-10-23 Thread GitBox
junichi11 commented on issue #174: Add a license header template for new files of NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/174#issuecomment-338854190 Exclude license-*.txt from rat, then, I'll merge this.

[GitHub] vieiro commented on issue #175: [NETBEANS-54] Module Review extexecution.process (patch)

2017-10-23 Thread GitBox
vieiro commented on issue #175: [NETBEANS-54] Module Review extexecution.process (patch) URL: https://github.com/apache/incubator-netbeans/pull/175#issuecomment-338864765 Thanks, Matthias, for your review! :-) This is an

[GitHub] geertjanw commented on issue #104: [NETBEANS-54] Module Review libs.osgi

2017-10-22 Thread GitBox
geertjanw commented on issue #104: [NETBEANS-54] Module Review libs.osgi URL: https://github.com/apache/incubator-netbeans/pull/104#issuecomment-338555136 Apologies, I misunderstood. I thought you meant we shouldn't change anything for now. Sorry, a lot, for misunderstanding. How should

[GitHub] geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-23 Thread GitBox
geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338555667 I think I'd leave them unchanged for the moment, i.e., we do not have to get everything from Maven, right now this minute. Do as

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-23 Thread GitBox
rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338573634 No worries Geertjan. Everything else is done. I'll log an issue regarding the patch and update the Module Review doc , but you

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-23 Thread GitBox
rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338578153 actually on second thoughts I should add a copyright notice to the patch, so hold off merging.

[GitHub] struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338614332 +1 to apply it. This is an automated message from the Apache Git

[GitHub] geertjanw opened a new pull request #180: [NETBEANS-54] Module Review java.hints.declarative

2017-10-23 Thread GitBox
geertjanw opened a new pull request #180: [NETBEANS-54] Module Review java.hints.declarative URL: https://github.com/apache/incubator-netbeans/pull/180 This is an automated message from the Apache Git Service. To respond to

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338620579 In my environment, Before: 24 tests success, 8 tests fail After: 16 tests success, 16 tests fail So, perhaps, there are

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338618424 It seems that failed unit tests increase. This is an automated

[GitHub] struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338618680 Weird, the 2 commits just add ALv2 headers to a bunch of files.

[GitHub] geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338618636 Failed unit tests increase because of this pull request? This is

[GitHub] geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-22 Thread GitBox
geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338512219 Anything more needs to be done here? This is an automated message

[GitHub] JaroslavTulach commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-23 Thread GitBox
JaroslavTulach commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#discussion_r146254955 ## File path: o.apache.xml.resolver/build.xml ## @@ -20,5 +20,43 @@ --> +

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338651619 I attach results as screenshots. Sorry in Japanese UI. Before:

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338620579 In my environment, Before: 24 tests succeed, 8 tests fail After: 16 tests succeed, 16 tests fail So, perhaps, there are

[GitHub] geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans

2017-10-23 Thread GitBox
geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338635407 Can you see which ones fail? I don't see a difference in terms of failed tests.

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-23 Thread GitBox
juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-338632856 I've expanded the zip file and committed the changes. Let me know if I need to modify the license headers after the RAT

[GitHub] vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-23 Thread GitBox
vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-338665582 Mmm... I think this is a very simple use case that just compiles a jar file, not enough for a generalization?. I

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-18 Thread GitBox
rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-337756887 Regarding org.apache.maven.indexer:maven-indexer:6.0-SNAPSHOT, I suggest we clone that into apache/netbeans owned git, apply the

[GitHub] rosslamont opened a new pull request #163: [NETBEANS-54] Module Review maven.indexer

2017-10-18 Thread GitBox
rosslamont opened a new pull request #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163 - binaries-list updated to use maven coords where possible - Need solution for apache maven indexer-core SNAPSHOT - suggestion

[GitHub] rosslamont opened a new pull request #162: [NETBEANS-54] Module Review maven.embedder

2017-10-18 Thread GitBox
rosslamont opened a new pull request #162: [NETBEANS-54] Module Review maven.embedder URL: https://github.com/apache/incubator-netbeans/pull/162 - binaries-list updated to use maven coords - added notice for jdom license (please double check) - did not add notice for

[GitHub] matthiasblaesing closed pull request #160: [NETBEANS-54] Module Review maven.model

2017-10-19 Thread GitBox
matthiasblaesing closed pull request #160: [NETBEANS-54] Module Review maven.model URL: https://github.com/apache/incubator-netbeans/pull/160 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

2017-10-22 Thread GitBox
jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338476937 I've rebased the patch on the current master. If there are no objects, I'd like to merge to master tonight

[GitHub] matthiasblaesing commented on a change in pull request #175: [NETBEANS-54] Module Review extexecution.process (patch)

2017-10-22 Thread GitBox
matthiasblaesing commented on a change in pull request #175: [NETBEANS-54] Module Review extexecution.process (patch) URL: https://github.com/apache/incubator-netbeans/pull/175#discussion_r146135224 ## File path: extexecution.process/external/binaries-list ## @@ -16,8

[GitHub] matthiasblaesing commented on a change in pull request #175: [NETBEANS-54] Module Review extexecution.process (patch)

2017-10-22 Thread GitBox
matthiasblaesing commented on a change in pull request #175: [NETBEANS-54] Module Review extexecution.process (patch) URL: https://github.com/apache/incubator-netbeans/pull/175#discussion_r146135262 ## File path: extexecution.process/build.xml ## @@ -22,4 +22,49 @@

[GitHub] geertjanw commented on issue #177: Generate license/notice/dependencies

2017-10-22 Thread GitBox
geertjanw commented on issue #177: Generate license/notice/dependencies URL: https://github.com/apache/incubator-netbeans/pull/177#issuecomment-338500642 Looks great and exactly what's needed. This is an automated message

[GitHub] geertjanw opened a new pull request #178: [NETBEANS-54] Module Review schema2beans

2017-10-22 Thread GitBox
geertjanw opened a new pull request #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit closed pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-22 Thread GitBox
asfgit closed pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] vieiro commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-22 Thread GitBox
vieiro commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#discussion_r146131267 ## File path: o.apache.xml.resolver/build.xml ## @@ -20,5 +20,45 @@ --> + + +

[GitHub] jlahoda opened a new pull request #177: Generate license/notice/dependencies

2017-10-22 Thread GitBox
jlahoda opened a new pull request #177: Generate license/notice/dependencies URL: https://github.com/apache/incubator-netbeans/pull/177 A patch to add mandatory LICENSE/NOTICE/DISCLAIMER and recommended DEPENDENCIES files to the zip distributions (source and binary). Also tweaks several

[GitHub] matthiasblaesing commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

2017-10-22 Thread GitBox
matthiasblaesing commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338486174 @jlahoda I see nothing that would prevent merging. Some things might be worth looking into later:

[GitHub] geertjanw commented on issue #176: [NETBEANS-54] Module Review usersguide (part 2)

2017-10-22 Thread GitBox
geertjanw commented on issue #176: [NETBEANS-54] Module Review usersguide (part 2) URL: https://github.com/apache/incubator-netbeans/pull/176#issuecomment-338494155 Great, thanks. I got the feeling recently that we should use our apache.org address, in some recent discussion. I.e.,

[GitHub] geertjanw commented on issue #176: [NETBEANS-54] Module Review usersguide (part 2)

2017-10-22 Thread GitBox
geertjanw commented on issue #176: [NETBEANS-54] Module Review usersguide (part 2) URL: https://github.com/apache/incubator-netbeans/pull/176#issuecomment-338494155 Great, thanks. I got the feeling recently that our we should use our apache.org address, in some recent discussion. I.e.,

[GitHub] geertjanw commented on issue #129: Sort rat excludes alphabetically

2017-10-23 Thread GitBox
geertjanw commented on issue #129: Sort rat excludes alphabetically URL: https://github.com/apache/incubator-netbeans/pull/129#issuecomment-338882553 One reason I?d like this one to be merged is that I have unit test data to be added to the Rat excludes (from schema2beans and java.hints)

[GitHub] JaroslavTulach opened a new pull request #182: Using HTML/Java 1.5 release bits

2017-10-24 Thread GitBox
JaroslavTulach opened a new pull request #182: Using HTML/Java 1.5 release bits URL: https://github.com/apache/incubator-netbeans/pull/182 Updating the Maven co-ordinates of HTML/Java API to point to recently released 1.5 bits. The 1.5 bits are licensed under Apache license - e.g.

[GitHub] junichi11 commented on issue #153: [NETBEANS-54] Module Review maven.osgi

2017-10-23 Thread GitBox
junichi11 commented on issue #153: [NETBEANS-54] Module Review maven.osgi URL: https://github.com/apache/incubator-netbeans/pull/153#issuecomment-338873970 I'll close this. see https://github.com/emilianbold/incubator-netbeans/pull/325

[GitHub] junichi11 closed pull request #153: [NETBEANS-54] Module Review maven.osgi

2017-10-23 Thread GitBox
junichi11 closed pull request #153: [NETBEANS-54] Module Review maven.osgi URL: https://github.com/apache/incubator-netbeans/pull/153 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] junichi11 commented on issue #163: [NETBEANS-54] Module Review maven.indexer

2017-10-24 Thread GitBox
junichi11 commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338887894 I've sorted rat excludes. (This PR already had the conflicting file(nbbuild/build.xml))

[GitHub] junichi11 commented on issue #129: Sort rat excludes alphabetically

2017-10-24 Thread GitBox
junichi11 commented on issue #129: Sort rat excludes alphabetically URL: https://github.com/apache/incubator-netbeans/pull/129#issuecomment-338883612 I'll merge soon. This is an automated message from the Apache Git Service.

[GitHub] arusinha opened a new pull request #184: [NETBEANS-54] Module Review net.java.html.geo

2017-10-24 Thread GitBox
arusinha opened a new pull request #184: [NETBEANS-54] Module Review net.java.html.geo URL: https://github.com/apache/incubator-netbeans/pull/184 This is an automated message from the Apache Git Service. To respond to the

[GitHub] arusinha opened a new pull request #185: [NETBEANS-54] Module Review net.java.html.boot.script

2017-10-24 Thread GitBox
arusinha opened a new pull request #185: [NETBEANS-54] Module Review net.java.html.boot.script URL: https://github.com/apache/incubator-netbeans/pull/185 Added license file for external resource net.java.html.boot.script-1.4.jar

[GitHub] arusinha opened a new pull request #186: [NETBEANS-54] Module Review net.java.html.boot.fx

2017-10-24 Thread GitBox
arusinha opened a new pull request #186: [NETBEANS-54] Module Review net.java.html.boot.fx URL: https://github.com/apache/incubator-netbeans/pull/186 Added license file for external resource net.java.html.boot.fx-1.4.jar

[GitHub] geertjanw opened a new pull request #187: [NETBEANS-54] adding schema2beans test data to Rat exceptions

2017-10-24 Thread GitBox
geertjanw opened a new pull request #187: [NETBEANS-54] adding schema2beans test data to Rat exceptions URL: https://github.com/apache/incubator-netbeans/pull/187 This is an automated message from the Apache Git Service. To

[GitHub] arusinha opened a new pull request #188: [NETBEANS-54] Module Review net.java.html.boot

2017-10-24 Thread GitBox
arusinha opened a new pull request #188: [NETBEANS-54] Module Review net.java.html.boot URL: https://github.com/apache/incubator-netbeans/pull/188 Added license file for external resource net.java.html.boot-1.4.jar This is

[GitHub] vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver

2017-10-24 Thread GitBox
vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-338942929 You need a command-line "patch" program. I'm not sure how to install int in Windows (I don't use Windows myself).

[GitHub] geertjanw commented on issue #129: Sort rat excludes alphabetically

2017-10-23 Thread GitBox
geertjanw commented on issue #129: Sort rat excludes alphabetically URL: https://github.com/apache/incubator-netbeans/pull/129#issuecomment-338742982 I don't think there are any PR's right now that have excludes, or am I wrong? If true, can we merge this one, have more to add to it,

[GitHub] arusinha opened a new pull request #183: Added license file for external resource net.java.html-1.4.jar

2017-10-24 Thread GitBox
arusinha opened a new pull request #183: Added license file for external resource net.java.html-1.4.jar URL: https://github.com/apache/incubator-netbeans/pull/183 This is an automated message from the Apache Git Service. To

[GitHub] vikasprabhakar opened a new pull request #189: [NETBEANS-54] Module Review web.browser.api

2017-10-24 Thread GitBox
vikasprabhakar opened a new pull request #189: [NETBEANS-54] Module Review web.browser.api URL: https://github.com/apache/incubator-netbeans/pull/189 Added license header for webpreview.wsmode This is an automated message

[GitHub] arusinha commented on issue #183: [NETBEANS-54] Module Review net.java.html

2017-10-24 Thread GitBox
arusinha commented on issue #183: [NETBEANS-54] Module Review net.java.html URL: https://github.com/apache/incubator-netbeans/pull/183#issuecomment-338957738 Closing the pull request as Jan Lahoda will work on the same This

[GitHub] arusinha closed pull request #183: [NETBEANS-54] Module Review net.java.html

2017-10-24 Thread GitBox
arusinha closed pull request #183: [NETBEANS-54] Module Review net.java.html URL: https://github.com/apache/incubator-netbeans/pull/183 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] arusinha commented on issue #188: [NETBEANS-54] Module Review net.java.html.boot

2017-10-24 Thread GitBox
arusinha commented on issue #188: [NETBEANS-54] Module Review net.java.html.boot URL: https://github.com/apache/incubator-netbeans/pull/188#issuecomment-338958063 Closing the pull request as Jan Lahoda will work on the same

[GitHub] jlahoda commented on issue #183: [NETBEANS-54] Module Review net.java.html

2017-10-24 Thread GitBox
jlahoda commented on issue #183: [NETBEANS-54] Module Review net.java.html URL: https://github.com/apache/incubator-netbeans/pull/183#issuecomment-338953182 I am sorry, but Jarda sent a pull request this morning changing the Html4J binaries for version 1.5, which is Apache licensed. I am

[GitHub] geertjanw commented on issue #168: adding insane dependency for tests in keyring.fallback

2017-10-24 Thread GitBox
geertjanw commented on issue #168: adding insane dependency for tests in keyring.fallback URL: https://github.com/apache/incubator-netbeans/pull/168#issuecomment-338957182 Nice, thanks. This is an automated message from the

[GitHub] geertjanw closed pull request #168: adding insane dependency for tests in keyring.fallback

2017-10-24 Thread GitBox
geertjanw closed pull request #168: adding insane dependency for tests in keyring.fallback URL: https://github.com/apache/incubator-netbeans/pull/168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sarveshkesharwani commented on issue #168: adding insane dependency for tests in keyring.fallback

2017-10-24 Thread GitBox
sarveshkesharwani commented on issue #168: adding insane dependency for tests in keyring.fallback URL: https://github.com/apache/incubator-netbeans/pull/168#issuecomment-338957056 This fixes the failing tests in "MasterPasswordEncryptionTest.java" and "FallbackProviderTest.java" in the

[GitHub] arusinha commented on issue #184: [NETBEANS-54] Module Review net.java.html.geo

2017-10-24 Thread GitBox
arusinha commented on issue #184: [NETBEANS-54] Module Review net.java.html.geo URL: https://github.com/apache/incubator-netbeans/pull/184#issuecomment-338957833 Closing the pull request as Jan Lahoda will work on the same

[GitHub] arusinha commented on issue #185: [NETBEANS-54] Module Review net.java.html.boot.script

2017-10-24 Thread GitBox
arusinha commented on issue #185: [NETBEANS-54] Module Review net.java.html.boot.script URL: https://github.com/apache/incubator-netbeans/pull/185#issuecomment-338957892 Closing the pull request as Jan Lahoda will work on the same

[GitHub] arusinha closed pull request #185: [NETBEANS-54] Module Review net.java.html.boot.script

2017-10-24 Thread GitBox
arusinha closed pull request #185: [NETBEANS-54] Module Review net.java.html.boot.script URL: https://github.com/apache/incubator-netbeans/pull/185 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] arusinha closed pull request #184: [NETBEANS-54] Module Review net.java.html.geo

2017-10-24 Thread GitBox
arusinha closed pull request #184: [NETBEANS-54] Module Review net.java.html.geo URL: https://github.com/apache/incubator-netbeans/pull/184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] arusinha closed pull request #188: [NETBEANS-54] Module Review net.java.html.boot

2017-10-24 Thread GitBox
arusinha closed pull request #188: [NETBEANS-54] Module Review net.java.html.boot URL: https://github.com/apache/incubator-netbeans/pull/188 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] arusinha commented on issue #186: [NETBEANS-54] Module Review net.java.html.boot.fx

2017-10-24 Thread GitBox
arusinha commented on issue #186: [NETBEANS-54] Module Review net.java.html.boot.fx URL: https://github.com/apache/incubator-netbeans/pull/186#issuecomment-338957969 Closing the pull request as Jan Lahoda will work on the same

[GitHub] arusinha closed pull request #186: [NETBEANS-54] Module Review net.java.html.boot.fx

2017-10-24 Thread GitBox
arusinha closed pull request #186: [NETBEANS-54] Module Review net.java.html.boot.fx URL: https://github.com/apache/incubator-netbeans/pull/186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] arusinha opened a new pull request #190: [NETBEANS-54] Module Review o.apache.commons.io

2017-10-24 Thread GitBox
arusinha opened a new pull request #190: [NETBEANS-54] Module Review o.apache.commons.io URL: https://github.com/apache/incubator-netbeans/pull/190 Added maven coordinate for external resource commons-io-1.4.jar This is an

[GitHub] geertjanw commented on issue #187: [NETBEANS-54] adding schema2beans test data to Rat exceptions

2017-10-24 Thread GitBox
geertjanw commented on issue #187: [NETBEANS-54] adding schema2beans test data to Rat exceptions URL: https://github.com/apache/incubator-netbeans/pull/187#issuecomment-338976315 OK, these updates are modifications to the existing Rat exclusions, and a simplification of part of it, only

[GitHub] geertjanw closed pull request #178: [NETBEANS-54] Module Review schema2beans

2017-10-24 Thread GitBox
geertjanw closed pull request #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw closed pull request #187: [NETBEANS-54] adding schema2beans test data to Rat exceptions

2017-10-24 Thread GitBox
geertjanw closed pull request #187: [NETBEANS-54] adding schema2beans test data to Rat exceptions URL: https://github.com/apache/incubator-netbeans/pull/187 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw closed pull request #182: Using HTML/Java 1.5 release bits

2017-10-24 Thread GitBox
geertjanw closed pull request #182: Using HTML/Java 1.5 release bits URL: https://github.com/apache/incubator-netbeans/pull/182 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] geertjanw commented on issue #182: Using HTML/Java 1.5 release bits

2017-10-24 Thread GitBox
geertjanw commented on issue #182: Using HTML/Java 1.5 release bits URL: https://github.com/apache/incubator-netbeans/pull/182#issuecomment-338977529 Makes sense, thanks, merging. This is an automated message from the Apache

[GitHub] junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-10 Thread GitBox
junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-343459163 @sarveshkesharwani Great to hear. We can merge your change without problems after you send it.

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

2017-11-10 Thread GitBox
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343432026 The shortcut is set here: https://github.com/apache/incubator-netbeans/pull/1/commits/67bdd60109474c543c010d3f818cfb36abb9c0c9#r150193869

[GitHub] ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore

2017-11-10 Thread GitBox
ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore URL: https://github.com/apache/incubator-netbeans/pull/252#issuecomment-343466528 connect to NETBEANS-134 This is an automated message

[GitHub] JaroslavTulach commented on issue #268: Run verify libs and licenses and rat for platform for pull requests

2017-11-10 Thread GitBox
JaroslavTulach commented on issue #268: Run verify libs and licenses and rat for platform for pull requests URL: https://github.com/apache/incubator-netbeans/pull/268#issuecomment-343430969 Excellent. I believe we shall add more and more tests of the platform once we stabilize them.

[GitHub] Chris2011 commented on a change in pull request #1: Feature/248233 - Shortcuts for document splitting

2017-11-10 Thread GitBox
Chris2011 commented on a change in pull request #1: Feature/248233 - Shortcuts for document splitting URL: https://github.com/apache/incubator-netbeans/pull/1#discussion_r150193869 ## File path:

[GitHub] junichi11 commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.

2017-11-10 Thread GitBox
junichi11 commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343457986 @jlahoda It seems that there is no license header in README-bin.txt and

[GitHub] jlahoda commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.

2017-11-10 Thread GitBox
jlahoda commented on issue #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267#issuecomment-343462476 Uh, I thought Rat excludes "notices", but apparently is doing so based on filenames

[GitHub] JaroslavTulach commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo?

2017-11-10 Thread GitBox
JaroslavTulach commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo? URL: https://github.com/apache/incubator-netbeans/pull/265#issuecomment-343432251 Nicely done. This is an

[GitHub] matthiasblaesing commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries.

2017-11-15 Thread GitBox
matthiasblaesing commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries. URL: https://github.com/apache/incubator-netbeans/pull/152#issuecomment-344691047 I agree Antonio, feel free to just close this.

[GitHub] jtulach commented on issue #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f?

2017-11-13 Thread GitBox
jtulach commented on issue #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f? URL: https://github.com/apache/incubator-netbeans/pull/270#issuecomment-343866750 Looks good to me. I would integrate the change.

[GitHub] geertjanw commented on issue #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat

2017-11-13 Thread GitBox
geertjanw commented on issue #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat URL: https://github.com/apache/incubator-netbeans/pull/271#issuecomment-343864526 So, should I simply close this one, is everything handled in #272?

[GitHub] vieiro commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries.

2017-11-15 Thread GitBox
vieiro commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries. URL: https://github.com/apache/incubator-netbeans/pull/152#issuecomment-344741806 Ok. Closing then. This is an automated message

[GitHub] vieiro closed pull request #152: Case insensitive SHA-1 comparisons for downloaded binaries.

2017-11-15 Thread GitBox
vieiro closed pull request #152: Case insensitive SHA-1 comparisons for downloaded binaries. URL: https://github.com/apache/incubator-netbeans/pull/152 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] vieiro commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries.

2017-11-14 Thread GitBox
vieiro commented on issue #152: Case insensitive SHA-1 comparisons for downloaded binaries. URL: https://github.com/apache/incubator-netbeans/pull/152#issuecomment-344495225 Matthias, I don't think this is worthwhile any longer. We can already do the builds perfectly without this,

[GitHub] geertjanw commented on issue #294: [NETBEANS-70] Remove bundled mysql driver (GPL licensed) and build sampledb from source

2017-11-27 Thread GitBox
geertjanw commented on issue #294: [NETBEANS-70] Remove bundled mysql driver (GPL licensed) and build sampledb from source URL: https://github.com/apache/incubator-netbeans/pull/294#issuecomment-347185474 This looks great and is critical for the 9.0 Beta release. But what's the problem

[GitHub] ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore

2017-11-28 Thread GitBox
ebarboni commented on issue #252: NETBEANS-134 wip attempt to get ignore from .gitgnore URL: https://github.com/apache/incubator-netbeans/pull/252#issuecomment-347463609 RatReportTask is build using the same assumption of having the version control tool available with "no issue so far".

[GitHub] Chris2011 commented on issue #301: Skin HTML components like the Swing ones

2017-11-28 Thread GitBox
Chris2011 commented on issue #301: Skin HTML components like the Swing ones URL: https://github.com/apache/incubator-netbeans/pull/301#issuecomment-347521289 Can you make a little example or do you have a documentation for this? Because I created a plugin called NbScratchFile and I use

[GitHub] emilianbold opened a new pull request #300: Exclude the GPL beansbinding library

2017-11-28 Thread GitBox
emilianbold opened a new pull request #300: Exclude the GPL beansbinding library URL: https://github.com/apache/incubator-netbeans/pull/300 This commit excludes the GPLed beansbinding library. It also disabled the Matisse Beans binding feature (which depends on the library). In the

[GitHub] JaroslavTulach opened a new pull request #301: Skin HTML components like the Swing ones

2017-11-28 Thread GitBox
JaroslavTulach opened a new pull request #301: Skin HTML components like the Swing ones URL: https://github.com/apache/incubator-netbeans/pull/301 This PR contains several bugfixes and a major initial step forward - any HTML component created by one of `@HTMLComponent`, `@HTMLDialog`,

  1   2   3   4   5   6   7   8   9   10   >