[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-10-15 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Merged - thank you! ---

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-10-15 Thread geertjanw
Github user geertjanw commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Is anything more needed to be done here or can this one be merged? ---

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-10-10 Thread dschoorl
Github user dschoorl commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 I added notice file for jcip-annotations instead of a jcip-license file. I changed the jsr305 license file based on the info in http://wiki.netbeans.org/DevFaqExternalLibraries as pointed

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-10-02 Thread jlahoda
Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Description of the current -license.txt processing is here: http://wiki.netbeans.org/DevFaqExternalLibraries I think details under Apache are still somewhat unclear, but I think

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-10-01 Thread dschoorl
Github user dschoorl commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Hi Jan, Thanks for reviewing again. In no way, I am a legal expert. But I think that by providing the jcip-license.txt file, we meet the requirements of the license

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-10-01 Thread jlahoda
Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Hi Dave, Sorry for belated answer. I think the jcip license text should be merged into the existing -license.txt file. Also the "License: " tag should probably be changed

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Can one of the admins verify this patch? ---

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-09-25 Thread jlahoda
Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 I am afraid the license here is a little bit more complex. I think the license is probably BSD, at least based on FindBugs: