[GitHub] nifi pull request: NIFI-1762: Use Lambda Expressions in StandardNi...

2016-04-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/352 NIFI-1762: Use Lambda Expressions in StandardNiFIServiceFacade to simplify codebase Changed Java dependency to 1.8 instead of 1.7 and refactored StandardNiFiServiceFacade to make use of Lambda

[GitHub] nifi pull request: Nifi 1214

2016-04-15 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/321#discussion_r59908921 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/TestRunner.java --- @@ -865,4 +866,21 @@ * @return the State Manager that is used to store and

[GitHub] nifi pull request: NIFI-1551: Prepare for introduction of Authoriz...

2016-04-15 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/359#issuecomment-210612644 Looks good. I verified that I was able to start NiFi using both secure and non-secure ports. I was then able to verify that I was able to add each component, update it

[GitHub] nifi pull request: NIFI-1551: Prepare for introduction of Authoriz...

2016-04-15 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/359#issuecomment-210618998 Looks like the latest commit addresses both issues outlined above. Will merge into master. Thanks for knocking this out! --- If your project is set up for it, you

[GitHub] nifi pull request: NIFI-1785 added NON_BLANK_VALIDATOR

2016-04-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/365#discussion_r60290762 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/StandardValidators.java --- @@ -127,12 +127,26 @@ public

[GitHub] nifi pull request: NIFI-1785 added NON_BLANK_VALIDATOR

2016-04-19 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/365#issuecomment-212085785 +1 this looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1790: Updated the URI patterns used in NCM...

2016-04-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/369 NIFI-1790: Updated the URI patterns used in NCM for determining whether or not responses should be merged NIFI-1790: Updated the URI patterns used in NCM for determining whether or not responses

[GitHub] nifi pull request: NIFI-981 [REVIEW-ONLY]: Initial addition of Hiv...

2016-04-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/372#discussion_r60474156 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java --- @@ -0,0 +1,184

[GitHub] nifi pull request: NIFI-981 [REVIEW-ONLY]: Initial addition of Hiv...

2016-04-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/372#discussion_r60474410 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java --- @@ -0,0 +1,184

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60781310 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60781488 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60781637 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60782150 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60782213 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60782403 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60782492 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60782754 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60782947 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/impl

[GitHub] nifi pull request: NIFI-1824: If attempting to archive content, an...

2016-04-28 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/391 NIFI-1824: If attempting to archive content, and there are no claimant counts for it, ensure that the stream is closed. NIFI-1824: If attempting to archive content, and there are no claimant counts

[GitHub] nifi pull request: NIFI-1816 Added provenance event SEND in Handle...

2016-04-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/389#discussion_r61485635 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java

[GitHub] nifi pull request: NIFI-1805

2016-04-28 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/377#issuecomment-215533199 We have talked before about having some sort of icon on a connection that indicates that back pressure is configured and then some sort of indicator that back pressure

[GitHub] nifi pull request: NIFI-1816 Added provenance event SEND in Handle...

2016-04-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/389#discussion_r61509041 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java

[GitHub] nifi pull request: NIFI-1830: Fixed problems in the merging logic ...

2016-04-29 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/394 NIFI-1830: Fixed problems in the merging logic for Drop FlowFile Requests NIFI-1830: Fixed problems in the merging logic for Drop FlowFile Requests You can merge this pull request into a Git

[GitHub] nifi pull request: NIFI-1824: If attempting to archive content, an...

2016-05-03 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1745: Refactor how requests are replicated...

2016-05-05 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/413 NIFI-1745: Refactor how requests are replicated across cluster This still has some work to be done, but I believe it's worth merging into master now, only because we need to merge these changes

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-05-06 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62700624 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFilterCSVColumns.java

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62700767 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFilterCSVColumns.java

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62700756 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFilterCSVColumns.java

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62700846 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62701139 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62700516 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestFilterCSVColumns/US500.csv --- @@ -0,0 +1

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62701269 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r62701492 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1800: Tie Controller Services to Process G...

2016-05-10 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/431 NIFI-1800: Tie Controller Services to Process Groups You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-1800 Alternatively you

[GitHub] nifi pull request: NIFI-1800: Tie Controller Services to Process G...

2016-05-11 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/431#issuecomment-218459759 @mcgilman sorry - it appears that I messed up with I pushed the changes to the branch, before I created the PR. What you looked at was an incomplete version from a few

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-11 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/420#issuecomment-218520423 I don't think we can use the provided test data as-is. Looking at http://www.briandunning.com/sample-data/ I don't see any sort of LICENSE info. Probably be

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-11 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/420#issuecomment-218531630 @ToivoAdams After looking at this a bit more, I've got a few very high-level thoughts. First is that what you have built here is incredibly awesome and powerful! I

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-11 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/420#issuecomment-218543143 @ToivoAdams as I think even more about this, it's opening up a lot of awesome possibilities. I think we could expand this Processor even more into really a "SQ

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-11 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62906404 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-11 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62906556 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-11 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62907252 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-11 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62906770 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1280 Create FilterCSVColumns Processor.

2016-05-11 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/420#issuecomment-218563978 Excellent. Yes, I'm thinking potentially Avro, JSON, Parquet... perhaps others. For 0.7.0 we may only have CSV and perhaps JSON but will have things in place to add

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-11 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62914873 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-11 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/419#issuecomment-218585975 @bbende I merged this to 0.x branch. However, it cannot be merged to the 'master' branch as-is. Can you create a PR That will merge to master? --- If your

[GitHub] nifi pull request: NIFI-1872: Ignore failing unit test for now unt...

2016-05-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/437 NIFI-1872: Ignore failing unit test for now until we can properly address Since it is on master it's best to ignore, since the problem appears to be the lifecycle of the unit test You can

[GitHub] nifi pull request: NIFI-1872: Allow sufficient time for embedded s...

2016-05-13 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/440 NIFI-1872: Allow sufficient time for embedded server to startup for u… …nit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14

[GitHub] nifi pull request: NIFI-1872: Allow for adequate time for embedded...

2016-05-13 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/441 NIFI-1872: Allow for adequate time for embedded zookeeper server to startup for unit tests PR for 0.x baseline You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi pull request: NIFI-1801: Scope Templates to Process Groups

2016-05-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/446 NIFI-1801: Scope Templates to Process Groups Also includes a few bug fixes that were not necessarily explicitly related to templates being scoped to Process Groups but that are required in order to

[GitHub] nifi pull request: NIFI-1801: Scope Templates to Process Groups

2016-05-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/446#discussion_r63344217 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/Template.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1866 ProcessException handling in Standard...

2016-05-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/439#discussion_r63344780 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository

[GitHub] nifi pull request: NIFI-1866 ProcessException handling in Standard...

2016-05-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/439#discussion_r63425128 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository

[GitHub] nifi pull request: NIFI-1866 ProcessException handling in Standard...

2016-05-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/439#discussion_r63425553 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository

[GitHub] nifi pull request: NIFI-1866 ProcessException handling in Standard...

2016-05-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/439#discussion_r63425823 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository

[GitHub] nifi pull request: NIFI-1745: Refactor how revisions are handled a...

2016-05-18 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/454 NIFI-1745: Refactor how revisions are handled at NCM/Distributed to Node This is part 2 of NIFI-1745, which provides user info to revision claims/locks and removes the cluster context, as it is no

[GitHub] nifi pull request: NIFI-1745: Refactor how revisions are handled a...

2016-05-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/454#discussion_r64043396 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-optimistic-locking/src/main/java/org/apache/nifi/web/revision

[GitHub] nifi pull request: NIFI-1745: Refactor how revisions are handled a...

2016-05-20 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/454#issuecomment-220610191 @mcgilman I agree, I do think it makes more sense to handle that in the Revision. Have updated the PR to back that out so that we can instead do it in the Resource in

[GitHub] nifi pull request: NIFI-1909 Adding ability to process schemaless ...

2016-05-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/459#discussion_r64097258 --- Diff: nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/ConvertAvroToJSON.java --- @@ -92,6 +103,7

[GitHub] nifi pull request: NIFI-1909 Adding ability to process schemaless ...

2016-05-20 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/459#discussion_r64097658 --- Diff: nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/ConvertAvroToJSON.java --- @@ -128,49 +141,77

[GitHub] nifi pull request: NIFI-1660 - Enhance the expression language wit...

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/303#discussion_r64234770 --- Diff: nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/JsonPathEvaluator.java

[GitHub] nifi pull request: NIFI-1660 - Enhance the expression language wit...

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/303#discussion_r64235176 --- Diff: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java --- @@ -233,6 +233,24 @@ public

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64247888 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java --- @@ -46,6

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64248023 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java --- @@ -46,6

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64248276 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64249465 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64256311 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java --- @@ -321,6

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64256472 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java --- @@ -321,6

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64257999 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64258489 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64259092 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/SnippetResource.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/461#issuecomment-221046258 @mcgilman looks good for the most part. I left some comments in-line (most of which you've already addressed before I finished the review even!) Excellent. Once the

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64259242 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/SnippetResource.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

2016-05-26 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/324#issuecomment-221935156 Agreed - I think moving the FlowController lifecycle to @Before and @After should address the issues. I do think that the validateIdempotencyOfProcessorStartOperation

[GitHub] nifi pull request: NIFI-1800: Providing access to Controller Servi...

2016-05-26 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/469#issuecomment-221951022 +1 looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request: NIFI-1554: Updating Cluster endpoints

2016-05-26 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/470#issuecomment-221954497 +1 looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #488: NIFI-1897: Refactoring to allow requests to be repli...

2016-06-02 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/488 NIFI-1897: Refactoring to allow requests to be replicated from a node to other nodes Nodes are now capable of replicating requests across the cluster and a Cluster Coordinator is auto-elected to

[GitHub] nifi issue #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/472 @mcgilman I merged this to master but forgot to update the commit message. Can you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/488 Modifications that you proposed look good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/491 NIFI-1960: Update admin guide regarding documentation for clustering You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-1960

[GitHub] nifi issue #303: NIFI-1660 - Enhance the expression language with jsonPath f...

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/303 @ckmcd an example would be something like: ${ hello:jsonPath( '$.${elementOfInterest}.items[0]') } Here, we are referencing an attribute within the JSON Path, so it is not

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65755030 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65755455 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65755845 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65756026 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65757147 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/458 I'm having trouble understanding the naming convention here. "DebugFlow" would indicate that it is debugging the flow that you are putting together, but the comment states "Create

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #491: NIFI-1960: Update admin guide regarding documentation for c...

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/491 Thanks, @alopresto. I have merged to master. I am sure that we will end up updating this a few more times before 1.0.0 is released, but at least I wanted to get this into master so that those trying

[GitHub] nifi pull request #499: NIFI-1052: Added "Ghost" Processors, Reporting Tasks...

2016-06-06 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/499 NIFI-1052: Added "Ghost" Processors, Reporting Tasks, Controller Services If we try to create a component for which the NAR is missing, we previously would throw an Exception that would

[GitHub] nifi issue #497: NIFI-1857: HTTPS Site-to-Site

2016-06-07 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/497 @ijokarumawak I can't seem to get this to work properly. I configured nifi to allow http site-to-site only, not secure. I then connected a GenerateFlowFile processor to a Remote Process Group

[GitHub] nifi issue #303: NIFI-1660 - Enhance the expression language with jsonPath f...

2016-06-07 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/303 @ckmcd looks good! I was able to test it locally. Unit tests are good. I did find that a Reader was opened in a unit test and not closed, which i addressed, and a couple of NOTICE files needed to be

[GitHub] nifi issue #506: NIFI-1660 - Enhance the expression language with jsonPath f...

2016-06-07 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/506 Hey @ckmcd I just realized that you had a different PR for the 0.x branch. I ended up just creating a patch from PR 303 and applying that to the 0.x baseline. So this should all be taken care of. Do

[GitHub] nifi pull request #501: NIFI-1974 - Support Custom Properties in Expression ...

2016-06-07 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r66142774 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/FileVariableRegistry.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request #501: NIFI-1974 - Support Custom Properties in Expression ...

2016-06-07 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r66142811 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/FileVariableRegistry.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request #501: NIFI-1974 - Support Custom Properties in Expression ...

2016-06-07 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r66143013 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/FileVariableRegistry.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request #501: NIFI-1974 - Support Custom Properties in Expression ...

2016-06-07 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r66143984 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/FileVariableRegistry.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request #501: NIFI-1974 - Support Custom Properties in Expression ...

2016-06-07 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r66144229 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/MultiMap.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] nifi pull request #501: NIFI-1974 - Support Custom Properties in Expression ...

2016-06-07 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r66145081 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/MultiMap.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] nifi pull request #501: NIFI-1974 - Support Custom Properties in Expression ...

2016-06-07 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/501#discussion_r66145563 --- Diff: nifi-api/src/main/java/org/apache/nifi/registry/MultiMap.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF

  1   2   3   4   5   >