[FYI] reftests

2016-08-29 Thread Jacques Le Roux
Hi, I found this interesting so wanted to share http://testthewebforward.org/docs/reftests.html Jacques

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

2016-08-29 Thread Scott Gray
Hi Jacques, None whatsoever. I was just trying to offer a design that would truly decouple the tracking code functionality from the order component. Has this commit been reverted yet? I think that might be a good first step. Regards Scott On 29 August 2016 at 08:02, Jacques Le Roux

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

2016-08-29 Thread Scott Gray
Keep in mind though that dealing with silent exceptions wasn't in the scope of the commit. Code reviews are great but we shouldn't expect committers to fix issues they didn't introduce. On 29 August 2016 at 21:04, Jacques Le Roux wrote: > Hi Harsh, > > Please

Re: Should we do binary releases?

2016-08-29 Thread Jacques Le Roux
Hi Nicolas, Taher, All, I also agree about not creating binary releases. At least not yet, this can be revisited... I just tried something which seemed very simple after reading Taher's suggestion in OFBIZ-7783 "For example if your problem is simply that you cannot build on a disconnected

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

2016-08-29 Thread Jacques Le Roux
Hi Scott, Yes, this has been reverted one week ago: https://issues.apache.org/jira/browse/OFBIZ-7966?focusedCommentId=15431090 Jacques Le 29/08/2016 à 23:38, Scott Gray a écrit : Hi Jacques, None whatsoever. I was just trying to offer a design that would truly decouple the tracking code

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

2016-08-29 Thread Jacques Le Roux
Mmm, then who should fix it? Of course I could have fixed it myself, but I thought that by providing an advice I'd help more. As we say "If you give a man a *fish*, you have fed him for a day. If you teach a man to *fish*, you have fed him for a lifetime." Jacques Le 29/08/2016 à 23:41,

Re: Some questions on plugin system

2016-08-29 Thread Taher Alkhateeb
Yup sure, I'll fine tune some issues and upload a patch just as was done in Gradle. Wanted initial feedback first on the idea. On Aug 29, 2016 10:10 AM, "Pierre Smits" wrote: > Hi Taher, > > Like I said earlier: I need to be able to see it working. Could you upload >

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

2016-08-29 Thread Jacques Le Roux
Hi Harsh, Please refer to what is usually done for that, eg in a service } catch (GenericEntityException e) { Debug.logWarning(e, module); Map messageMap = UtilMisc.toMap("errMessage", e.getMessage()); errMsg =

Re: Using Steve for OFBiz votes

2016-08-29 Thread Jacques Le Roux
Yes I agree, good point! Jacques Le 29/08/2016 à 09:32, Jacopo Cappellato a écrit : While it is always nice to experiment new tools, I don't see any advantage in using Steve for the usual votes we run in these lists. However we could consider it to run special votes that require features that

Re: Using Steve for OFBiz votes

2016-08-29 Thread Jacopo Cappellato
While it is always nice to experiment new tools, I don't see any advantage in using Steve for the usual votes we run in these lists. However we could consider it to run special votes that require features that a mailing list doesn't easily provide, like the recent vote we had about our logo. Just

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

2016-08-29 Thread Harsh Vijaywargiya
Thanks Jacques for review comment. I think in such case it could be better to uncomment such log statements from Exception block, right? or we should leave it as is? Thanks & Regards, Harsh On Saturday 27 August 2016 06:19 PM, Jacques Le Roux wrote: Hi Ashish, Harsh, Please don't let

Re: Some questions on plugin system

2016-08-29 Thread Taher Alkhateeb
Hi Pierre, - The system can and does work with zip and tar.gz and normal folders. - The maven repo provides everything we need especially dependency management. I think upgrading from from your solution to the one I suggested below might be difficult once an ecosystem builds around the plug-in

Re: Some questions on plugin system

2016-08-29 Thread Pierre Smits
This solutions must be able to work with: - zip files - tar files and other zip variants (tar.gz, etc) - folder structures. That will enable the adopter to use local storage, but also releases stored in GitHub or even svn repos. At the moment I see the use of maven repos as overkill,

Re: Some questions on plugin system

2016-08-29 Thread Pierre Smits
Hi Taher, Like I said earlier: I need to be able to see it working. Could you upload your solution as a patch to the issue you created earlier? Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace

Re: Using Steve for OFBiz votes

2016-08-29 Thread Pierre Smits
Steve is a great tool for various kinds of votes, not only community wide votes (open to everyone) like the vote on the logo, but also in OFBiz PMC private votes like onboarding contributors in the realms of the privileged. It provides functions for both open and controlled circulation. As a

Re: Using Steve for OFBiz votes

2016-08-29 Thread Taher Alkhateeb
I agree with Jacopo, I prefer not to use solutions to problems that do not exist. If / when voting becomes a problem because of volume or other reasons then we can give it a try. On Mon, Aug 29, 2016 at 2:21 PM, Pierre Smits wrote: > Steve is a great tool for various

Shorter ASL2 header in short files

2016-08-29 Thread Jacques Le Roux
Hi, At https://issues.apache.org/jira/browse/OFBIZ-6243 we had a discussion about "ASL2 header in short files" I'd like to propose as a project policy that we use this sentence proposed at http://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available "Licensed