Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-23 Thread Pierre Smits
Thanks Jacques, forellen staking care of thuis. Op za 23 mei 2020 11:28 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: > Actually we have also this information nicely coming to ofbiz-*@ > noreply.github.com > > So we don't need the ugly couples (added then removed) at >

Re: New Online Help, base on ci.apache.org/projects/ofbiz/site/ofbizdoc

2020-05-23 Thread Jacques Le Roux
Hi Olivier: It's only in R17, see content of a https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins build If you want to know more look at 'f_ofb_branch17_framework_plugins' in https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf/

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Pawan Verma
Hi Jacques, I care for the *checkstyle* issues but I also feel we should abandon it. -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Sat, May 23, 2020 at 6:08 PM Jacques Le Roux <

Re: Modify OFBiz commit message template

2020-05-23 Thread Mridul Pathak
+1 Thanks. -- Mridul Pathak > On 20-May-2020, at 2:31 PM, Jacques Le Roux > wrote: > > Hi, > > With Git IMO it's convenient (more information) to have the Jira number in > the title, eg: https://markmail.org/message/cyslglyoh5gf7l7t > > If nobody disagree I'd like to modify > >

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Jacques Le Roux
Thanks Suraj! Jacques Le 23/05/2020 à 14:04, Suraj Khurana a écrit : Hello team, All tests passed on my local machine. I used: ./gradlew testIntegration -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 23, 2020 at 5:17 PM wrote: The Buildbot has detected a new

Re: @deprecated No replacement

2020-05-23 Thread Mridul Pathak
+1 to remove references. Thanks. -- Mridul Pathak > On 22-May-2020, at 1:03 PM, Jacques Le Roux > wrote: > > Hi, > > We have 5, 8 years old, , "@deprecated No replacement" references in Java > code: > https://ofbiz.markmail.org/search/?q=%22%40deprecated+No+replacement%22 > > It seems

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Suraj Khurana
Hello team, All tests passed on my local machine. I used: ./gradlew testIntegration -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 23, 2020 at 5:17 PM wrote: > The Buildbot has detected a new failure on builder > ofbizTrunkFrameworkPlugins while building

Re: @deprecated No replacement

2020-05-23 Thread Devanshu Vyas
+1 to remove references. Thanks & Regards, Devanshu Vyas. On Sat, May 23, 2020 at 11:54 AM Mridul Pathak < mridul.pat...@hotwaxsystems.com> wrote: > +1 to remove references. > > Thanks. > -- > Mridul Pathak > > > > On 22-May-2020, at 1:03 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com>

Re: EntityBatchIterator for large data set queries

2020-05-23 Thread Pritam Kute
Hello Pawan, I just had a look into the EntityQuery.queryIterator() method and looks like we can achieve that by using fetchSize(), fowardOnly(), cursorScrollInsensitive(), cursorScrollSensitive() and offset() methods in EntityQuery class. Let me know if I am missing anything. It will be good if

Re: @deprecated No replacement

2020-05-23 Thread Pierre Smits
+1 forellen removing refs Op za 23 mei 2020 08:27 schreef Devanshu Vyas : > +1 to remove references. > > Thanks & Regards, > Devanshu Vyas. > > > On Sat, May 23, 2020 at 11:54 AM Mridul Pathak < > mridul.pat...@hotwaxsystems.com> wrote: > > > +1 to remove references. > > > > Thanks. > > -- > >

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-23 Thread Jacques Le Roux
Actually we have also this information nicely coming to ofbiz-*@noreply.github.com So we don't need the ugly couples (added then removed) at notificati...@ofbiz.apache.org If nobody disagree I'll see if Infra can do something about that in a week... Jacques Le 20/05/2020 à 20:24, Pierre

Re: @deprecated No replacement

2020-05-23 Thread Aditya Sharma
+1 Thanks Jacques! Thanks and Regards, Aditya Sharma On Sat, May 23, 2020 at 12:13 PM Pierre Smits wrote: > +1 forellen removing refs > > Op za 23 mei 2020 08:27 schreef Devanshu Vyas : > > > +1 to remove references. > > > > Thanks & Regards, > > Devanshu Vyas. > > > > > > On Sat, May 23, 2020

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Jacques Le Roux
Ha wait I confused w/ something else. Aas I said when starting this thread "this is a *checkstyle* issue. It's not clear to me why it happened." Currently BuildBot makes erratic exceptions trying to pull. I have created for that (and just updated)

Re: New Online Help, base on ci.apache.org/projects/ofbiz/site/ofbizdoc

2020-05-23 Thread Olivier Heintz
Thanks Jacques for the clarification, But, I'm not sure to understand, currently, doc is generated only for R17 and are only included in buildbot job for trunkFrameworkPlugin ? Work to do is to add for job R17Framework and R18Framework ? Infra help is needed to publish for multi-release ? can

Re: Ordermgr errors on demo-trunk.ofbiz.apache.org

2020-05-23 Thread Jacques Le Roux
Hi Pawan, It seems related to this error: Caused by: org.apache.ofbiz.service.GenericServiceException: Error running Groovy method [getPartyNameForDate] in Groovy file [component://party/groovyScripts/party/PartyServices.groovy]: (The field name (or key) [gender] is not valid for entity

Re: LineLength for checkstyle

2020-05-23 Thread Pawan Verma
+1 Pawan

Re: Ordermgr errors on demo-trunk.ofbiz.apache.org

2020-05-23 Thread Jacques Le Roux
Hi Pawan, It seems related to this error: Caused by: org.apache.ofbiz.service.GenericServiceException: Error running Groovy method [getPartyNameForDate] in Groovy file [component://party/groovyScripts/party/PartyServices.groovy]: (The field name (or key) [gender] is not valid for entity

LineLength for checkstyle

2020-05-23 Thread Suraj Khurana
Hello Devs, Recently we are facing some checkstyle issues and one cause of it is LineLength property. Currently we have set it to 120, I think we should make it to 150 instead. It is pretty visible in 13/14 font sizes as well. Please share your thoughts on this. -- Best Regards, Suraj Khurana

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Aditya Sharma
Hi Jacques, I think *check styles* plugin is important for us and we should think of introducing a pre-commit hook that checks only for the staged changes. This will help developers to know about the lint issues before the commit itself. Some reference I found that achieves the above case.

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Suraj Khurana
+1 Aditya If we can do that, that would be great. -- Suraj khurana On Sat 23 May, 2020, 6:55 PM Aditya Sharma, wrote: > Hi Jacques, > > I think *check styles* plugin is important for us and we should think of > introducing a pre-commit hook that checks only for the staged changes. This >

Re: LineLength for checkstyle

2020-05-23 Thread Jacques Le Roux
+1 Jacques Le 23/05/2020 à 17:29, Suraj Khurana a écrit : Hello Devs, Recently we are facing some checkstyle issues and one cause of it is LineLength property. Currently we have set it to 120, I think we should make it to 150 instead. It is pretty visible in 13/14 font sizes as well. Please

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Jacques Le Roux
FYI: I cloned INFRA-20297 at https://issues.apache.org/jira/browse/INFRA-20303 for that Le 23/05/2020 à 07:40, build...@apache.org a écrit : The Buildbot has detected a build exception on builder ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are available at:

Re: Ordermgr errors on demo-trunk.ofbiz.apache.org

2020-05-23 Thread Pawan Verma
Hello Everyone, I dig around the issue and found that getPartyNameForDate is the main culprit for this issue. It can be easily generated on the local instance by updating the admin's name. Updating name will create a new record in PartyNameHistory entity and service getPartyNameForDate has an

Re: Ordermgr errors on demo-trunk.ofbiz.apache.org

2020-05-23 Thread Pierre Smits
Thanks Pawan, for the quick action. Op za 23 mei 2020 20:16 schreef Pawan Verma : > Hello Everyone, > > I dig around the issue and found that getPartyNameForDate is the main > culprit for this issue. It can be easily generated on the local instance by > updating the admin's name. > > Updating

Ordermgr errors on demo-trunk.ofbiz.apache.org

2020-05-23 Thread Pawan Verma
Hello Devs, Just saw some unusual errors on demo-trunk.ofbiz.apache.org for ordermgr component. Most of the Order screens are broken. At first glance, it seems some deployment issues because most of the screens are broken. At my local, after the latest update these screens seem to be working