Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/28
@ellisonanne yes, this is ready to merge pls.
There may be minor changes but this is the bulk of the clean-up
restructuring I intend to do right now.
---
If your project is set up
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/28#discussion_r72583147
--- Diff: src/main/java/org/apache/pirk/schema/data/DataSchemaLoader.java
---
@@ -181,19 +172,34 @@ public DataSchema loadSchema(InputStream stream
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72586620
--- Diff: src/main/java/org/apache/pirk/utils/SystemConfiguration.java ---
@@ -24,8 +24,6 @@
import java.io.InputStream;
import
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72588302
--- Diff: src/main/java/org/apache/pirk/utils/SystemConfiguration.java ---
@@ -160,4 +138,74 @@ public static void resetProperties
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72589271
--- Diff: pom.xml ---
@@ -117,6 +117,7 @@
3.3
+
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72588602
--- Diff: src/main/resources/pirk.properties ---
@@ -31,7 +31,8 @@ local.pirk.properties=/root/local.pirk.properties
##
##Spark path
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72592297
--- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierProps.java
---
@@ -0,0 +1,202 @@
+package org.apache.pirk.querier.wideskies
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72701770
--- Diff: src/main/java/org/apache/pirk/utils/SystemConfiguration.java ---
@@ -160,4 +139,78 @@ public static void resetProperties
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72702440
--- Diff: src/main/resources/pirk.properties-repo ---
@@ -0,0 +1,243
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72702338
--- Diff: src/main/resources/pirk.properties-repo ---
@@ -0,0 +1,243
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/27
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72698216
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/QuerierDriverCLI.java ---
@@ -136,192 +111,26 @@ private boolean parseOptions
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/27#discussion_r72703868
--- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierProps.java
---
@@ -0,0 +1,202 @@
+package org.apache.pirk.querier.wideskies
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/30
Ensure stop list property is set for tests.
- Now throws a PIR exception if the required property is not set.
- Includes some tidy-up of temp file creation.
You can merge this pull
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/26
Thanks. Your call, but you may want to hold off regenerating the JavaDoc
until this task is completed, as there are more doc changes coming too.
---
If your project is set up for it, you
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/28
[PIRK-19] Further restructuring in schema loading.
- Additional re-factoring of the query schema loading code.
- Pull out XML document parsing to helper methods.
- Narrowing
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/57
[PIRK-49] PrimitivePartioner does not account for locale settings
- Ensure bytes are always encoded in network byte ordering.
- Remove primitive type partitioner's unhealthy obsession
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/3
Ignore logs created at runtime.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk master
Alternatively you can
Github user tellison closed the pull request at:
https://github.com/apache/incubator-pirk/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/9
Sorry Ellison Anne, I broke it. Let me close this and open a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/17
As well as supporting the original format, this PR allows for a more
concise form, like this:
```
fakeDataSchema
elementName1
string
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/8
[PIRK-9] Exclude Travis directives from RAT checks.
Caused a build break by conflict between adding Travis and adding RAT
checks commits.
This PR simply ignores the Travis yml file from
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/9
[WIP] XML schema for Pirk's Data and Query Schemas
This is currently a work in progress. Taken from the website
documentation, here are some XML schemas to check the correctness of the Pirk
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/2
The configuration of providers is made in the runtime (in the
lib/security/java.security) rather than the application. Why would Pirk need
to specify a specific provider?
---
If your
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/29
Add a no-arguments version of EncryptQuery#encrypt().
- defaults to the system configured number of threads.
- special case single threaded encryptions (following lead in
Query
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/29
Does this make sense for EncryptQuery to depend upon SystemConfiguration?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/64#discussion_r74917596
--- Diff:
src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java
---
@@ -90,12 +89,20
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/64#discussion_r74917728
--- Diff:
src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java
---
@@ -48,8 +48,7 @@
public static final
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/64
Enhancements to partitioners, keyedHash, and prime generator.
- Convert last few remaining ArrayList return types on partitioners to
List interface, and deal with the flow through
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/68
Convert DecryptResponseRunnable to a Callable.
- Allows task to return a value and throw checked exceptions.
- Further tidy-up in decrypt response.
Passing results between
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/73#discussion_r75501927
--- Diff: src/main/java/org/apache/pirk/encryption/PrimeGenerator.java ---
@@ -18,15 +18,15 @@
*/
package org.apache.pirk.encryption
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/73
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/75
Not tested on distributed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/75
Enhancements to parallelism of query encryption.
- Switch parallel encrypt task to use callable interface.
- Use parallelStream to generate the (in-memory) exponent table.
- Run
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/80#discussion_r76224576
--- Diff: README.md ---
@@ -86,6 +86,32 @@ Pirk employs generic [data and query
schemas](http://pirk.incubator.apache.org/f
See
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/83
Pass query elements into Query constructor.
- Compute encrypted query elements, and pass in as part of query
construction rather than adding them afterwards to an existing query
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/105#discussion_r81305924
--- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierProps.java
---
@@ -60,154 +59,179 @@
// Decryption properties
static
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/105#discussion_r81304556
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/EncryptionPropertiesBuilder.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/105#discussion_r81305132
--- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierCLI.java
---
@@ -131,12 +125,28 @@ private boolean parseOptions
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/105#discussion_r81306398
--- Diff: src/main/java/org/apache/pirk/test/utils/StandaloneQuery.java ---
@@ -77,25 +76,16 @@
logger.info("fileQu
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r79351660
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java ---
@@ -49,83 +41,111 @@
public class ResponderDriver
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r79352002
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java ---
@@ -49,83 +41,111 @@
public class ResponderDriver
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/93
I've merged the PR Darin. That's not to say that the debate is over, but
this does move us forward and we can use new PRs to address ongoing
improvements.
---
If your project is set up
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/100
[WIP] Create Paillier bridge to hide test constructor
For discussion:
Paillier currently exposes a public constructor that is only for testing.
This is one way to make it default
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r79988418
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java ---
@@ -50,103 +40,31 @@
{
private static final Logger
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r79987737
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/ResponderService.java ---
@@ -0,0 +1,73 @@
+package
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r79988975
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/spi/ResponderPlugin.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r80012564
--- Diff:
src/main/resources/META-INF/services/org.apache.pirk.responder.wideskies.spi.ResponderPlugin
---
@@ -0,0 +1,5
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r80030927
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java ---
@@ -50,103 +40,31 @@
{
private static final Logger
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/94
Update a number of Pirk's pom dependencies.
- move Pirk to later versions of JMH, Hadoop, commons-math3, commons-net,
json-simple, jacoco-maven-plugin, coveralls-maven-plugin, Surefire
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/65#discussion_r75086172
--- Diff: LICENSE ---
@@ -199,4 +199,64 @@
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/66
[PIRK-55] Move all tests under src/test directory
- Moves test files under src/test.
- Rename packages to ensure consistency with org.apache.pirk.test.
- Update pom exclusion
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75324999
--- Diff: src/main/java/org/apache/pirk/schema/query/QuerySchemaLoader.java
---
@@ -296,7 +296,7 @@ private Document parseXMLDocument(InputStream
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75324702
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java ---
@@ -316,23 +311,15 @@ public void performQuery() throws
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76517695
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -163,8 +144,8 @@ public void encrypt(int numThreads
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76517506
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -56,103 +56,84 @@
{
private static final
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76516765
--- Diff:
src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java
---
@@ -32,7 +32,7 @@
* Class for partitioning
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/81
Enhancements to Wideskies encrypt/decrypt.
- encrypt/decrypt now return their results, rather than have
side-effect on their instances.
- decryptor no longer responsible
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/81
Not tested on distributed test suite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/76
+1, it is good enough to merge into master and refine from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/74#discussion_r76493503
--- Diff: src/main/java/org/apache/pirk/query/wideskies/QueryInfo.java ---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/74#discussion_r76494100
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/common/ComputeEncryptedRow.java
---
@@ -321,4 +316,80 @@ public static void
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/74#discussion_r76493783
--- Diff: src/main/java/org/apache/pirk/query/wideskies/QueryInfo.java ---
@@ -96,6 +98,33 @@ public QueryInfo(UUID identifierInput, int
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/74#discussion_r76494284
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/storm/EncColMultBolt.java ---
@@ -0,0 +1,130
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/76#discussion_r75834426
--- Diff: src/main/resources/pirk.properties ---
@@ -28,7 +28,8 @@ local.pirk.properties.dir=/root/
##
##Spark path for SparkLauncher
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/76#discussion_r75835110
--- Diff: src/main/resources/META-INF/bin-license-notice/LICENSE-bin ---
@@ -0,0 +1,262 @@
+
--- End diff --
I think these license
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/76#discussion_r75834938
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/spark/streaming/ComputeStreamingResponse.java
---
@@ -0,0 +1,467
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/76#discussion_r75834645
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/spark/streaming/ComputeStreamingResponse.java
---
@@ -0,0 +1,467
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/75#discussion_r75758251
--- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java ---
@@ -136,89 +124,30 @@ public boolean containsElement(BigInteger element
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/102#discussion_r80862797
--- Diff: src/main/java/org/apache/pirk/encryption/Paillier.java ---
@@ -95,140 +95,185 @@
}
}
- private BigInteger p
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/102#discussion_r80863023
--- Diff: src/main/java/org/apache/pirk/encryption/Paillier.java ---
@@ -95,140 +95,185 @@
}
}
- private BigInteger p
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/100
Ok, thanks for the comment. Let's update the javadoc instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/111#discussion_r85321545
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -156,10 +149,23 @@ public Querier encrypt(int numThreads
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/111#discussion_r85321593
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -156,10 +149,23 @@ public Querier encrypt(int numThreads
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/114
Improve in-memory exponent table creation
Accumulate values in expTable rather than repeatedly compute powers.
Please take a look. This benches faster for me.
You can merge
Github user tellison closed the pull request at:
https://github.com/apache/incubator-pirk/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user tellison reopened a pull request:
https://github.com/apache/incubator-pirk/pull/114
Improve in-memory exponent table creation
Accumulate values in expTable rather than repeatedly compute powers.
Please take a look. This benches faster for me.
You can merge
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/114
Sigh, I don't know why this Maven plugin is failing. I will close and
re-open this PR to cause a retest and see if that fixes it.
---
If your project is set up for it, you can reply
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/113#discussion_r85607855
--- Diff: pom.xml ---
@@ -86,7 +86,7 @@
4.12
log4j2.xml
2.7.3
-1.6.1
+2.0.0
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/111#discussion_r84031817
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -178,11 +217,14 @@ public Querier encrypt(int numThreads
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/111#discussion_r84029515
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/encrypt/EncryptQuery.java ---
@@ -64,9 +67,33 @@
// Paillier encryption
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/111
Ripe for a test case then!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/112#discussion_r84772832
--- Diff: src/main/java/org/apache/pirk/schema/query/QuerySchemaLoader.java
---
@@ -226,50 +215,28 @@ public QuerySchema loadSchema(InputStream
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/112#discussion_r84773126
--- Diff:
src/test/java/org/apache/pirk/schema/query/LoadQuerySchemaTest.java ---
@@ -389,49 +320,42 @@ private void createDataSchema(String
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/117
My bad, I should have created a new branch for the broken link.
Please review this addition as part of the JIRA, and merge as a resolution
to PIRK-81 ++
---
If your project is set up
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/116
Revert PIRK-35 and update some dependencies
- Roll back the changes to PIRK-35 Execute Tests in Parallel to improve
stability.
- Update Pirk's dependency versions for JMH, Spark
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/112
The local tests, and my travis-ci instance passes the tests ok. I see the
failure is caused by a Maven PluginExecutionException.
I will push new changes to force a re-test
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/113
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/107#discussion_r82813992
--- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java ---
@@ -26,41 +26,51 @@
import java.util.concurrent.ConcurrentHashMap
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/107#discussion_r82814228
--- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java ---
@@ -114,8 +124,7 @@ public void generateExpTable
90 matches
Mail list logo
