Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Dave Fisher
-1 - What artifacts are we voting on? Where is the source package on the Apache servers? Packages here https://github.com/apache/pulsar-client-go/releases are not immutable. There are no checksums or signatures. No update to the KEYS file. Please put release candidates here:

[GitHub] [pulsar-client-node] yosiat commented on issue #83: Consumer with message listener dies after some time

2020-03-26 Thread GitBox
yosiat commented on issue #83: Consumer with message listener dies after some time URL: https://github.com/apache/pulsar-client-node/pull/83#issuecomment-604554560 @sijie re-wrote this a bit, so: - Call `Ref()` when we a have message listener, to make sure this reference is kept alive.

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Dave Fisher
Hi - There is an official release policy - http://www.apache.org/legal/release-policy.html#policy It does not include GitHub as a source of official releases. Releases are acts of the Foundation through each PMC. Perhaps that is something to be discussed on legal-discuss@, but that would

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Matteo Merli
Hi Dave, we discussed in past to only release a Git tag for Go. All the users of this library will just fetch the library directly from Github, specifying a tag in their Go dependencies tool. While we could publish a source tar.gz, it would be of little practical utility to users. Having said

Fwd: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Sijie Guo
Hi legal team, I'd like to raise a discussion about what is the best way to release a Golang client for the ASF projects. Since Golang is a static linking language, Go applications just reference to a Git tag of the source code to use. People don't download the source code package and compile it.

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Matteo Merli
+1 -- Matteo Merli On Thu, Mar 26, 2020 at 4:52 AM Yong Zhang wrote: > > +1 > > Thanks > Yong > > On Thu, 26 Mar 2020 at 19:44, PengHui Li wrote: > > > +1 > > > > Sijie Guo 于2020年3月26日周四 上午8:28写道: > > > > > +1 > > > > > > On Tue, Mar 24, 2020 at 11:26 PM anonymitaet _ > > > > > wrote: > >

[GitHub] [pulsar-client-node] yosiat commented on issue #83: Consumer with message listener dies after some time

2020-03-26 Thread GitBox
yosiat commented on issue #83: Consumer with message listener dies after some time URL: https://github.com/apache/pulsar-client-node/pull/83#issuecomment-604550699 Did some changes in this PR so I can pass consumer as argument. But it one test is crashing when closing consumer, I am

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Dave Fisher
Hi Sijie, Good plan. Pulsar should keep doing what it is doing, but don’t call these clients “official”. The answer may vary with the client technology. For example maven archives do go through an official repository of Apache’s. NPMs are different and are distributed in different ways. Still

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Dave Fisher
Sent from my iPhone > On Mar 26, 2020, at 1:28 PM, Sijie Guo wrote: > > Hi Dave, > > Thank you for your response! > > I know there would be no immediate conclusion about the release policy of > golang client since it seems that it requires some discussions on the legal > side. > > We can

[GitHub] [pulsar-client-node] alexyans commented on issue #78: Error: Failed to send message: AlreadyClosed

2020-03-26 Thread GitBox
alexyans commented on issue #78: Error: Failed to send message: AlreadyClosed URL: https://github.com/apache/pulsar-client-node/issues/78#issuecomment-604658303 @yosiat thank you!! This is an automated message from the

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Sijie Guo
Hi Dave, Thank you for your response! I know there would be no immediate conclusion about the release policy of golang client since it seems that it requires some discussions on the legal side. We can publish a tarball of the released source code and distribute it to the ASF svn dist repo for

[GitHub] [pulsar-client-node] yosiat commented on issue #78: Error: Failed to send message: AlreadyClosed

2020-03-26 Thread GitBox
yosiat commented on issue #78: Error: Failed to send message: AlreadyClosed URL: https://github.com/apache/pulsar-client-node/issues/78#issuecomment-604705233 @alexyans happy to help :) This is an automated message from the

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Sijie Guo
Sounds good to me. I think we need to do this for node clients as well. - Sijie On Thu, Mar 26, 2020 at 1:37 PM Dave Fisher wrote: > > > Sent from my iPhone > > > On Mar 26, 2020, at 1:28 PM, Sijie Guo wrote: > > > > Hi Dave, > > > > Thank you for your response! > > > > I know there would

Slack digest for #dev - 2020-03-26

2020-03-26 Thread Apache Pulsar Slack
2020-03-25 16:38:10 UTC - Alexandre DUVAL: Seems tests related to encryption required on servercnxtest are broken on master. Right? 2020-03-25 16:38:48 UTC - Alexandre DUVAL: Like `ServerCnxTest.testProducerFailureOnEncryptionRequiredTopic()`

Jenkins build is back to normal : pulsar-website-build #945

2020-03-26 Thread Apache Jenkins Server
See

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread PengHui Li
+1 Sijie Guo 于2020年3月26日周四 上午8:28写道: > +1 > > On Tue, Mar 24, 2020 at 11:26 PM anonymitaet _ > wrote: > > > +1 > > > > Thanks xiaolong for your great work > > > > On 2020/3/25, 13:43, "xiaolong ran" wrote: > > > > Hi everyone, > > > > Please review and vote on the release candidate

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread 丛搏
+1 good work! On 2020/03/25 05:43:04, xiaolong ran wrote: > Hi everyone, > > Please review and vote on the release candidate #1 for the version 0.1.0, as > follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > This is the first

Re: [VOTE] Pulsar Client Go Release 0.1.0 Candidate 1

2020-03-26 Thread Yong Zhang
+1 Thanks Yong On Thu, 26 Mar 2020 at 19:44, PengHui Li wrote: > +1 > > Sijie Guo 于2020年3月26日周四 上午8:28写道: > > > +1 > > > > On Tue, Mar 24, 2020 at 11:26 PM anonymitaet _ > > > wrote: > > > > > +1 > > > > > > Thanks xiaolong for your great work > > > > > > On 2020/3/25, 13:43, "xiaolong ran"

Build failed in Jenkins: pulsar_release_nightly_snapshot #764

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] Fix function related test issue. (#6604) [github] [blog]update pic in this blog (#6608) [github] [docker]Docker standalone build error (#6586) [github] Do not apply env