[GitHub] astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465779208 Having said all that on the whole if the Windows CI build works and the Linux CI build is unaffected I'm ok with merging this cha

[GitHub] astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465778368 > > 1. **File name casing**. The windows API is not really very consistent when is comes to the casing of file names (can

[GitHub] astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465677673 You don't explain what problem you are solving with these changes. Please give more details about why you need to - 1. change