astitcher commented on issue #156: PROTON-1936: lower case include and updated 
ifdefs
URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465779208
 
 
   Having said all that on the whole if the Windows CI build works and the 
Linux CI build is unaffected I'm ok with merging this change. I'd just prefer 
to make the platform/compiler selection logic as simple and clear as possible, 
without explanationless voodoo present.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to