astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465677673 You don't explain what problem you are solving with these changes. Please give more details about why you need to - 1. change the case of the includes - I thought windows filesystems are case insensitive. 2. Add some platform detection as well as compiler detection - I think that in openssl.c the detection should probably be platform detection instead of compiler detection. But in the other cases it platform detection makes no sense to me as things being selected are compiler things not platform things.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
