[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670471#comment-15670471
 ] 

ASF GitHub Bot commented on PROTON-1330:


Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/88


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670469#comment-15670469
 ] 

ASF subversion and git services commented on PROTON-1330:
-

Commit 62f9d149f11516fdec35bdb1e0fa1998c3c1 in qpid-proton's branch 
refs/heads/master from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=62f ]

PROTON-1330: [python] bundle the C source in the python source distribution

This closes #88


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668341#comment-15668341
 ] 

ASF GitHub Bot commented on PROTON-1330:


Github user astitcher commented on the issue:

https://github.com/apache/qpid-proton/pull/88
  
I like this approach.

I was expecting to see the file lists substituted in setup.py.in somewhere. 
I didn't see that - how are the CMake file lists used inside setup.py to 
generate the source bundle?


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668322#comment-15668322
 ] 

ASF GitHub Bot commented on PROTON-1330:


Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/88#discussion_r88113144
  
--- Diff: proton-c/bindings/python/CMakeLists.txt ---
@@ -122,3 +129,55 @@ install(TARGETS ${SWIG_MODULE_cproton_REAL_NAME}
 COMPONENT Python)
 
 set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES 
"html;tutorial")
+
+#
+# Set up the directory 'dist' for building the python native package
+# source distribution for Pypi/pip
+#
+
+set(py_dist_dir ${CMAKE_CURRENT_BINARY_DIR}/dist)
+
+configure_file(${CMAKE_CURRENT_SOURCE_DIR}/setup.py.in
+   ${py_dist_dir}/setup.py
+)
+configure_file(${CMAKE_CURRENT_SOURCE_DIR}/README.rst.in
+   ${py_dist_dir}/README.rst
+)
+
+file(COPY ${py_dist_files} DESTINATION ${py_dist_dir})
+
+file(MAKE_DIRECTORY ${py_dist_dir}/proton)
+file(COPY ${pysrc} DESTINATION ${py_dist_dir}/proton)
+
+#file(COPY ${py_dist_proton_c_files}
--- End diff --

Do you really want to add commented out lines?


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668215#comment-15668215
 ] 

ASF GitHub Bot commented on PROTON-1330:


GitHub user kgiusti opened a pull request:

https://github.com/apache/qpid-proton/pull/88

PROTON-1330: [python] bundle the C source in the python source distribution

This alters the previous approach:  All c source files are enumerated in 
the CMakeLists.txt in the proton-c directory.  The python CMakeLists.txt 
introduces a new target for the python source distribution, using the source 
lists from the parent CMakeLists.txt


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kgiusti/qpid-proton PROTON-1330-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit 6017faf49e61d0cb2b393f1166d53582a3523a9c
Author: Kenneth Giusti 
Date:   2016-11-01T17:21:15Z

PROTON-1330: [python] bundle the C source in the python source distribution




> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668199#comment-15668199
 ] 

ASF GitHub Bot commented on PROTON-1330:


Github user kgiusti closed the pull request at:

https://github.com/apache/qpid-proton/pull/85


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668198#comment-15668198
 ] 

ASF GitHub Bot commented on PROTON-1330:


Github user kgiusti commented on the issue:

https://github.com/apache/qpid-proton/pull/85
  
I've got a different approach that may address the issues you've raised 
Andrew.



> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664699#comment-15664699
 ] 

ASF GitHub Bot commented on PROTON-1330:


Github user kgiusti commented on the issue:

https://github.com/apache/qpid-proton/pull/85
  
re: encoding.h and protocol.h:

I didn't want to duplicate the generation of these files in the python 
CMakeLists.txt but as it stands now these files are generated during the build 
phase - not the cmake configuration pass.   I can either 1) require the C 
compilation is done prior to building the Python source distribution or 2) move 
the file generation to the cmake configuration phase.  

re: packaging C source

I'm not entirely sure I understand - are you suggesting some of the C files 
are not needed by the Python bindings?  I assume I can hunt around for these 
files, but isn't all Proton/C functionality accessible via the python bindings, 
since the binding is used by the python unit tests?


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659874#comment-15659874
 ] 

ASF subversion and git services commented on PROTON-1330:
-

Commit 770ef8fe3c65ea62d64efbbaf4be21b3ce772b4e in qpid-proton's branch 
refs/heads/0.15.x from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=770ef8f ]

PROTON-1330: [python] bundle the C source in the python source distribution


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645370#comment-15645370
 ] 

ASF GitHub Bot commented on PROTON-1330:


Github user astitcher commented on the issue:

https://github.com/apache/qpid-proton/pull/85
  
A couple of comments:

* It seems entirely arbitrary (to me anyway) to move generating encoding.h 
and protocol.h from the C build process to generating them when producing the C 
part of the python install. We know that we have python available at the time 
of build the C code (well duh!) so we could keep on generating at C build time 
when we do the python install.

This seems to me to minimise the divergence between the packaged C source 
for the python package and the real C source tree.

* Given the c code built by the python install is somewhat selective anyway 
- it makes sense (again to me anyway) only to package C source which is 
actually used in the library used by the python installation.


> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644314#comment-15644314
 ] 

ASF GitHub Bot commented on PROTON-1330:


GitHub user kgiusti opened a pull request:

https://github.com/apache/qpid-proton/pull/85

PROTON-1330: [python] bundle the C source in the python source distri…



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kgiusti/qpid-proton PROTON-1330

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit c917fe870e3f8e41a9ac7d295cc48cb08e002682
Author: Kenneth Giusti 
Date:   2016-11-01T17:21:15Z

PROTON-1330: [python] bundle the C source in the python source distribution




> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[Ken Giusti (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644200#comment-15644200
 ] 

Ken Giusti commented on PROTON-1330:


Andrew,

I agree - that hardcoded list isn't the best idea.  I've opened a new JIRA to 
track this change:

https://issues.apache.org/jira/browse/PROTON-1345

> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution

[Andrew Stitcher (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637552#comment-15637552
 ] 

Andrew Stitcher commented on PROTON-1330:
-

As an additional (probably optional) aspect to this issue, I note that the list 
of files to compile from within the c source is hardcoded into the setup.py 
file.

This strikes me as bad! I recently discovered to my irritation that creating 
new directories and moving some files around in the proton tree made the tox 
tests fail and it took me a little time to figure out why.

I'd suggest that the same process that packages up the source tree for use in 
the pytoh installation either also packages up a list of the files to compile, 
OR omits all the files that are not supposed to be compiled. In any event it 
would be *much* better if rearranging the C source tree didn't involve changing 
anything in the python setup.

> Include the C sources in the python source distribution
> ---
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.15.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the 
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by 
> apache infrastructure maintainers.  This will lead to failures when 
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the 
> necessary proton-c source files for inclusion in the python bindings package. 
>  Instead of fetching the necessary sources from apache, setup.py can simply 
> build and install the proton library using the bundled sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org